diff mbox series

[net-next,v2,1/3] net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()

Message ID 20240904151018.71967-2-vassilisamir@gmail.com (mailing list archive)
State Accepted
Commit 517c29247557bf4a28065cb758a59ad545fe925d
Delegated to: Netdev Maintainers
Headers show
Series Use functionality of irq_get_trigger_type() | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 16 this patch: 16
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 9 of 9 maintainers
netdev/build_clang success Errors and warnings before: 16 this patch: 16
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 16 this patch: 16
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-09-06--21-00 (tests: 721)

Commit Message

Vasileios Amoiridis Sept. 4, 2024, 3:10 p.m. UTC 
Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alvin Šipraga Sept. 4, 2024, 3:40 p.m. UTC | #1 
On Wed, Sep 04, 2024 at 05:10:16PM GMT, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
>  drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks like you missed my review here, you can add it :)

Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Vasileios Amoiridis Sept. 10, 2024, 9:58 p.m. UTC | #2 
On Wed, Sep 04, 2024 at 03:40:56PM +0000, Alvin Šipraga wrote:
> On Wed, Sep 04, 2024 at 05:10:16PM GMT, Vasileios Amoiridis wrote:
> > Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> > simple irq_get_trigger_type(irq).
> > 
> > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> > ---
> >  drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Looks like you missed my review here, you can add it :)
> 
> Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>

Hi Alvin,

Sorry for missing that, but thank you for reminding :)
diff mbox series

Patch

diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
index b9674f68b756..ad7044b295ec 100644
--- a/drivers/net/dsa/realtek/rtl8365mb.c
+++ b/drivers/net/dsa/realtek/rtl8365mb.c
@@ -1740,7 +1740,7 @@  static int rtl8365mb_irq_setup(struct realtek_priv *priv)
 	}
 
 	/* Configure chip interrupt signal polarity */
-	irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
+	irq_trig = irq_get_trigger_type(irq);
 	switch (irq_trig) {
 	case IRQF_TRIGGER_RISING:
 	case IRQF_TRIGGER_HIGH: