diff mbox series

net: phy: qca83xx: use PHY_ID_MATCH_EXACT

Message ID 20240904205659.7470-1-rosenp@gmail.com (mailing list archive)
State Accepted
Commit cca0d69baf950e5a82c21d09917b4cc654c83fe9
Delegated to: Netdev Maintainers
Headers show
Series net: phy: qca83xx: use PHY_ID_MATCH_EXACT | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 16 this patch: 16
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 2 maintainers not CCed: hkallweit1@gmail.com linux-arm-msm@vger.kernel.org
netdev/build_clang success Errors and warnings before: 16 this patch: 16
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 16 this patch: 16
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 34 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-09-06--21-00 (tests: 721)

Commit Message

Rosen Penev Sept. 4, 2024, 8:56 p.m. UTC 
No need for the mask when there's already a macro for this.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/net/phy/qcom/qca83xx.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

Comments

Andrew Lunn Sept. 4, 2024, 9:43 p.m. UTC | #1 
On Wed, Sep 04, 2024 at 01:56:59PM -0700, Rosen Penev wrote:
> No need for the mask when there's already a macro for this.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

The Subject should be [PATCH net-next]. Yes, we all keep forgetting
it, but it is important to the CI.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Rosen Penev Sept. 4, 2024, 10:02 p.m. UTC | #2 
On Wed, Sep 4, 2024 at 2:43 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Wed, Sep 04, 2024 at 01:56:59PM -0700, Rosen Penev wrote:
> > No need for the mask when there's already a macro for this.
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
>
> The Subject should be [PATCH net-next]. Yes, we all keep forgetting
> it, but it is important to the CI.
Procedural mistake. Need to use --subject-prefix looks like. Should I resend?
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
>     Andrew
Andrew Lunn Sept. 4, 2024, 10:06 p.m. UTC | #3 
> Procedural mistake. Need to use --subject-prefix looks like. Should I resend?

Wait 3 days. If it does not get merged, please do resend.

     Andrew
patchwork-bot+netdevbpf@kernel.org Sept. 7, 2024, 1:30 a.m. UTC | #4 
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  4 Sep 2024 13:56:59 -0700 you wrote:
> No need for the mask when there's already a macro for this.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  drivers/net/phy/qcom/qca83xx.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)

Here is the summary with links:
  - net: phy: qca83xx: use PHY_ID_MATCH_EXACT
    https://git.kernel.org/netdev/net-next/c/cca0d69baf95

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/phy/qcom/qca83xx.c b/drivers/net/phy/qcom/qca83xx.c
index 5d083ef0250e..a05d0df6fa16 100644
--- a/drivers/net/phy/qcom/qca83xx.c
+++ b/drivers/net/phy/qcom/qca83xx.c
@@ -15,7 +15,6 @@ 
 #define QCA8327_A_PHY_ID			0x004dd033
 #define QCA8327_B_PHY_ID			0x004dd034
 #define QCA8337_PHY_ID				0x004dd036
-#define QCA8K_PHY_ID_MASK			0xffffffff
 
 #define QCA8K_DEVFLAGS_REVISION_MASK		GENMASK(2, 0)
 
@@ -216,8 +215,7 @@  static int qca8327_suspend(struct phy_device *phydev)
 static struct phy_driver qca83xx_driver[] = {
 {
 	/* QCA8337 */
-	.phy_id			= QCA8337_PHY_ID,
-	.phy_id_mask		= QCA8K_PHY_ID_MASK,
+	PHY_ID_MATCH_EXACT(QCA8337_PHY_ID),
 	.name			= "Qualcomm Atheros 8337 internal PHY",
 	/* PHY_GBIT_FEATURES */
 	.probe			= qca83xx_probe,
@@ -231,8 +229,7 @@  static struct phy_driver qca83xx_driver[] = {
 	.resume			= qca83xx_resume,
 }, {
 	/* QCA8327-A from switch QCA8327-AL1A */
-	.phy_id			= QCA8327_A_PHY_ID,
-	.phy_id_mask		= QCA8K_PHY_ID_MASK,
+	PHY_ID_MATCH_EXACT(QCA8327_A_PHY_ID),
 	.name			= "Qualcomm Atheros 8327-A internal PHY",
 	/* PHY_GBIT_FEATURES */
 	.link_change_notify	= qca83xx_link_change_notify,
@@ -247,8 +244,7 @@  static struct phy_driver qca83xx_driver[] = {
 	.resume			= qca83xx_resume,
 }, {
 	/* QCA8327-B from switch QCA8327-BL1A */
-	.phy_id			= QCA8327_B_PHY_ID,
-	.phy_id_mask		= QCA8K_PHY_ID_MASK,
+	PHY_ID_MATCH_EXACT(QCA8327_B_PHY_ID),
 	.name			= "Qualcomm Atheros 8327-B internal PHY",
 	/* PHY_GBIT_FEATURES */
 	.link_change_notify	= qca83xx_link_change_notify,