diff mbox series

[1/1] can: esd_usb: Remove CAN_CTRLMODE_3_SAMPLES for CAN-USB/3-FD

Message ID 20240904222740.2985864-2-stefan.maetje@esd.eu (mailing list archive)
State Awaiting Upstream
Delegated to: Netdev Maintainers
Headers show
Series can: esd_usb: Remove CAN_CTRLMODE_3_SAMPLES for CAN-USB/3-FD | expand

Checks

Context Check Description
netdev/tree_selection success Series ignored based on subject

Commit Message

Stefan Mätje Sept. 4, 2024, 10:27 p.m. UTC
Remove the CAN_CTRLMODE_3_SAMPLES announcement for CAN-USB/3-FD devices
because these devices don't support it.

The hardware has a Microchip SAM E70 microcontroller that uses a Bosch
MCAN IP core as CAN FD controller. But this MCAN core doesn't support
triple sampling.

Fixes: 80662d943075 ("can: esd_usb: Add support for esd CAN-USB/3")
Cc: stable@vger.kernel.org
Signed-off-by: Stefan Mätje <stefan.maetje@esd.eu>
---
 drivers/net/can/usb/esd_usb.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Vincent Mailhol Sept. 4, 2024, 11:27 p.m. UTC | #1
Hi Stefan,

Thanks for the patch.

On Thu. 5 Sep. 2024 at 07:29, Stefan Mätje <stefan.maetje@esd.eu> wrote:
> Remove the CAN_CTRLMODE_3_SAMPLES announcement for CAN-USB/3-FD devices
> because these devices don't support it.
>
> The hardware has a Microchip SAM E70 microcontroller that uses a Bosch
> MCAN IP core as CAN FD controller. But this MCAN core doesn't support
> triple sampling.
>
> Fixes: 80662d943075 ("can: esd_usb: Add support for esd CAN-USB/3")
> Cc: stable@vger.kernel.org
> Signed-off-by: Stefan Mätje <stefan.maetje@esd.eu>

Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Marc Kleine-Budde Sept. 5, 2024, 6:24 a.m. UTC | #2
On 05.09.2024 00:27:40, Stefan Mätje wrote:
> Remove the CAN_CTRLMODE_3_SAMPLES announcement for CAN-USB/3-FD devices
> because these devices don't support it.
> 
> The hardware has a Microchip SAM E70 microcontroller that uses a Bosch
> MCAN IP core as CAN FD controller. But this MCAN core doesn't support
> triple sampling.
> 
> Fixes: 80662d943075 ("can: esd_usb: Add support for esd CAN-USB/3")
> Cc: stable@vger.kernel.org
> Signed-off-by: Stefan Mätje <stefan.maetje@esd.eu>

Applied to linux-can.

Thanks,
Marc
diff mbox series

Patch

diff --git a/drivers/net/can/usb/esd_usb.c b/drivers/net/can/usb/esd_usb.c
index 41a0e4261d15..03ad10b01867 100644
--- a/drivers/net/can/usb/esd_usb.c
+++ b/drivers/net/can/usb/esd_usb.c
@@ -3,7 +3,7 @@ 
  * CAN driver for esd electronics gmbh CAN-USB/2, CAN-USB/3 and CAN-USB/Micro
  *
  * Copyright (C) 2010-2012 esd electronic system design gmbh, Matthias Fuchs <socketcan@esd.eu>
- * Copyright (C) 2022-2023 esd electronics gmbh, Frank Jungclaus <frank.jungclaus@esd.eu>
+ * Copyright (C) 2022-2024 esd electronics gmbh, Frank Jungclaus <frank.jungclaus@esd.eu>
  */
 
 #include <linux/can.h>
@@ -1116,9 +1116,6 @@  static int esd_usb_3_set_bittiming(struct net_device *netdev)
 	if (priv->can.ctrlmode & CAN_CTRLMODE_LISTENONLY)
 		flags |= ESD_USB_3_BAUDRATE_FLAG_LOM;
 
-	if (priv->can.ctrlmode & CAN_CTRLMODE_3_SAMPLES)
-		flags |= ESD_USB_3_BAUDRATE_FLAG_TRS;
-
 	baud_x->nom.brp = cpu_to_le16(nom_bt->brp & (nom_btc->brp_max - 1));
 	baud_x->nom.sjw = cpu_to_le16(nom_bt->sjw & (nom_btc->sjw_max - 1));
 	baud_x->nom.tseg1 = cpu_to_le16((nom_bt->prop_seg + nom_bt->phase_seg1)
@@ -1219,7 +1216,6 @@  static int esd_usb_probe_one_net(struct usb_interface *intf, int index)
 	switch (le16_to_cpu(dev->udev->descriptor.idProduct)) {
 	case ESD_USB_CANUSB3_PRODUCT_ID:
 		priv->can.clock.freq = ESD_USB_3_CAN_CLOCK;
-		priv->can.ctrlmode_supported |= CAN_CTRLMODE_3_SAMPLES;
 		priv->can.ctrlmode_supported |= CAN_CTRLMODE_FD;
 		priv->can.bittiming_const = &esd_usb_3_nom_bittiming_const;
 		priv->can.data_bittiming_const = &esd_usb_3_data_bittiming_const;