| Message ID | 20240905062752.10883-1-saeed@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Wed, 4 Sep 2024 23:27:35 -0700 Saeed Mahameed wrote:
> - Fix sparse and checkpatch issue.
coccicheck also:
mellanox/mlx5/core/steering/hws/mlx5hws_pat_arg.c:179:2-9: WARNING opportunity for kmemdup
mellanox/mlx5/core/steering/hws/mlx5hws_definer.c:2053:11-18: WARNING opportunity for kmemdup
From: Saeed Mahameed <saeedm@nvidia.com> This series adds hardware steering support in mlx5. For more information please see tag log below. V1->V2: - Fix sparse and checkpatch issue. Please pull and let me know if there is any problem. Thanks, Saeed. The following changes since commit 43b7724487109368363bb5cda034b3f600278d14: Merge tag 'wireless-next-2024-09-04' of git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next (2024-09-04 17:20:14 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git tags/mlx5-updates-2024-09-02 for you to fetch changes up to bd24b72c3091313fe1b370f6ed17c1b028d993fd: net/mlx5: HWS, added API and enabled HWS support (2024-09-04 23:26:17 -0700) ---------------------------------------------------------------- mlx5-updates-2024-08-29 HW-Managed Flow Steering in mlx5 driver Yevgeny Kliteynik says: ======================= 1. Overview ----------- ConnectX devices support packet matching, modification, and redirection. This functionality is referred as Flow Steering. To configure a steering rule, the rule is written to the device-owned memory. This memory is accessed and cached by the device when processing a packet. The first implementation of Flow Steering was done in FW, and it is referred in the mlx5 driver as Device-Managed Flow Steering (DMFS). Later we introduced SW-managed Flow Steering (SWS or SMFS), where the driver is writing directly to the device's configuration memory (ICM) through RC QP using RDMA operations (RDMA-read and RDAM-write), thus achieving higher rates of rule insertion/deletion. Now we introduce a new flow steering implementation: HW-Managed Flow Steering (HWS or HMFS). In this new approach, the driver is configuring steering rules directly to the HW using the WQs with a special new type of WQE. This way we can reach higher rule insertion/deletion rate with much lower CPU utilization compared to SWS. The key benefits of HWS as opposed to SWS: + HW manages the steering decision tree - HW calculates CRC for each entry - HW handles tree hash collisions - HW & FW manage objects refcount + HW keeps cache coherency: - HW provides tree access locking and synchronization - HW provides notification on completion + Insertion rate isn’t affected by background traffic - Dedicated HW components that handle insertion 2. Performance -------------- Measuring Connection Tracking with simple IPv4 flows w/o NAT, we are able to get ~5 times more flows offloaded per second using HWS. 3. Configuration ---------------- The enablement of HWS mode in eswitch manager is done using the same devlink param that is already used for switching between FW-managed steering and SW-managed steering modes: # devlink dev param set pci/<PCI_ID> name flow_steering_mode cmod runtime value hmfs 4. Upstream Submission ---------------------- HWS support consists of 3 main components: + Steering: - The lower layer that exposes HWS API to upper layers and implements all the management of flow steering building blocks + FS-Core - Implementation of fs_hws layer to enable fs_core to use HWS instead of FW or SW steering - Create HW steering action pools to utilize the ability of HWS to share steering actions among different rules - Add support for configuring HWS mode through devlink command, similar to configuring SWS mode + Connection Tracking - Implementation of CT support for HW steering - Hooks up the CT ops for the new steering mode and uses the HWS API to implement connection tracking. Because of the large number of patches, we need to perform the submission in several separate patch series. This series is the first submission that lays the ground work for the next submissions, where an actual user of HWS will be added. 5. Patches in this series ------------------------- This patch series contains implementation of the first bullet from above. The patches are: [patch 01/15] net/mlx5: Added missing mlx5_ifc definition for HW Steering [patch 02/15] net/mlx5: Added missing definitions in preparation for HW Steering [patch 03/15] net/mlx5: HWS, added actions handling [patch 04/15] net/mlx5: HWS, added tables handling [patch 05/15] net/mlx5: HWS, added rules handling [patch 06/15] net/mlx5: HWS, added definers handling [patch 07/15] net/mlx5: HWS, added matchers functionality [patch 08/15] net/mlx5: HWS, added FW commands handling [patch 09/15] net/mlx5: HWS, added modify header pattern and args handling [patch 10/15] net/mlx5: HWS, added vport handling [patch 11/15] net/mlx5: HWS, added memory management handling [patch 12/15] net/mlx5: HWS, added backward-compatible API handling [patch 13/15] net/mlx5: HWS, added debug dump and internal headers [patch 14/15] net/mlx5: HWS, added send engine and context handling [patch 15/15] net/mlx5: HWS, added API and enabled HWS support ======================= ---------------------------------------------------------------- Yevgeny Kliteynik (15): net/mlx5: Added missing mlx5_ifc definition for HW Steering net/mlx5: Added missing definitions in preparation for HW Steering net/mlx5: HWS, added actions handling net/mlx5: HWS, added tables handling net/mlx5: HWS, added rules handling net/mlx5: HWS, added definers handling net/mlx5: HWS, added matchers functionality net/mlx5: HWS, added FW commands handling net/mlx5: HWS, added modify header pattern and args handling net/mlx5: HWS, added vport handling net/mlx5: HWS, added memory management handling net/mlx5: HWS, added backward-compatible API handling net/mlx5: HWS, added debug dump and internal headers net/mlx5: HWS, added send engine and context handling net/mlx5: HWS, added API and enabled HWS support .../ethernet/mellanox/mlx5/kconfig.rst | 3 + drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 10 + drivers/net/ethernet/mellanox/mlx5/core/Makefile | 21 + drivers/net/ethernet/mellanox/mlx5/core/fs_core.h | 8 +- .../ethernet/mellanox/mlx5/core/steering/dr_cmd.c | 12 +- .../mellanox/mlx5/core/steering/hws/Makefile | 2 + .../mellanox/mlx5/core/steering/hws/mlx5hws.h | 954 +++++++ .../mlx5/core/steering/hws/mlx5hws_action.c | 2604 ++++++++++++++++++++ .../mlx5/core/steering/hws/mlx5hws_action.h | 307 +++ .../mlx5/core/steering/hws/mlx5hws_buddy.c | 149 ++ .../mlx5/core/steering/hws/mlx5hws_buddy.h | 21 + .../mellanox/mlx5/core/steering/hws/mlx5hws_bwc.c | 997 ++++++++ .../mellanox/mlx5/core/steering/hws/mlx5hws_bwc.h | 73 + .../mlx5/core/steering/hws/mlx5hws_bwc_complex.c | 86 + .../mlx5/core/steering/hws/mlx5hws_bwc_complex.h | 29 + .../mellanox/mlx5/core/steering/hws/mlx5hws_cmd.c | 1300 ++++++++++ .../mellanox/mlx5/core/steering/hws/mlx5hws_cmd.h | 361 +++ .../mlx5/core/steering/hws/mlx5hws_context.c | 260 ++ .../mlx5/core/steering/hws/mlx5hws_context.h | 64 + .../mlx5/core/steering/hws/mlx5hws_debug.c | 480 ++++ .../mlx5/core/steering/hws/mlx5hws_debug.h | 40 + .../mlx5/core/steering/hws/mlx5hws_definer.c | 2148 ++++++++++++++++ .../mlx5/core/steering/hws/mlx5hws_definer.h | 834 +++++++ .../mlx5/core/steering/hws/mlx5hws_internal.h | 59 + .../mlx5/core/steering/hws/mlx5hws_matcher.c | 1216 +++++++++ .../mlx5/core/steering/hws/mlx5hws_matcher.h | 107 + .../mlx5/core/steering/hws/mlx5hws_pat_arg.c | 582 +++++ .../mlx5/core/steering/hws/mlx5hws_pat_arg.h | 101 + .../mellanox/mlx5/core/steering/hws/mlx5hws_pool.c | 640 +++++ .../mellanox/mlx5/core/steering/hws/mlx5hws_pool.h | 151 ++ .../mellanox/mlx5/core/steering/hws/mlx5hws_prm.h | 514 ++++ .../mellanox/mlx5/core/steering/hws/mlx5hws_rule.c | 780 ++++++ .../mellanox/mlx5/core/steering/hws/mlx5hws_rule.h | 84 + .../mellanox/mlx5/core/steering/hws/mlx5hws_send.c | 1202 +++++++++ .../mellanox/mlx5/core/steering/hws/mlx5hws_send.h | 270 ++ .../mlx5/core/steering/hws/mlx5hws_table.c | 493 ++++ .../mlx5/core/steering/hws/mlx5hws_table.h | 68 + .../mlx5/core/steering/hws/mlx5hws_vport.c | 86 + .../mlx5/core/steering/hws/mlx5hws_vport.h | 13 + include/linux/mlx5/mlx5_ifc.h | 189 +- include/linux/mlx5/qp.h | 1 + 41 files changed, 17283 insertions(+), 36 deletions(-) create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/Makefile create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_action.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_action.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_buddy.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_buddy.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_bwc.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_bwc.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_bwc_complex.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_bwc_complex.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_cmd.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_cmd.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_context.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_context.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_debug.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_debug.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_definer.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_definer.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_internal.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_matcher.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_matcher.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_pat_arg.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_pat_arg.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_pool.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_pool.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_prm.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_rule.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_rule.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_send.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_send.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_table.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_table.h create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_vport.c create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_vport.h