| Message ID | 20240905143248.203153-1-ada@thorsis.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: mdiobus: Debug print fwnode handle instead of raw pointer | expand |
On Thu, Sep 05, 2024 at 04:32:47PM +0200, Alexander Dahl wrote: > Was slightly misleading before, because printed is pointer to fwnode, > not to phy device, as placement in message suggested. Include header > for dev_dbg() declaration while at it. > > Output before: > > [ +0.001247] mdio_bus f802c000.ethernet-ffffffff: registered phy 2612f00a fwnode at address 3 > > Output after: > > [ +0.001229] mdio_bus f802c000.ethernet-ffffffff: registered phy fwnode /ahb/apb/ethernet@f802c000/ethernet-phy@3 at address 3 > > Signed-off-by: Alexander Dahl <ada@thorsis.com> The patch itself looks good. But i think this should be for net-next, not net. '2612f00a' is not particularly useful, but i don't think it causes problems for anybody as required by the Stable rules. So the Subject should be [PATCH net-next] https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 9/5/24 07:32, Alexander Dahl wrote: > Was slightly misleading before, because printed is pointer to fwnode, > not to phy device, as placement in message suggested. Include header > for dev_dbg() declaration while at it. > > Output before: > > [ +0.001247] mdio_bus f802c000.ethernet-ffffffff: registered phy 2612f00a fwnode at address 3 > > Output after: > > [ +0.001229] mdio_bus f802c000.ethernet-ffffffff: registered phy fwnode /ahb/apb/ethernet@f802c000/ethernet-phy@3 at address 3 > > Signed-off-by: Alexander Dahl <ada@thorsis.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c index fd02f5cbc853..b156493d7084 100644 --- a/drivers/net/mdio/fwnode_mdio.c +++ b/drivers/net/mdio/fwnode_mdio.c @@ -7,6 +7,7 @@ */ #include <linux/acpi.h> +#include <linux/dev_printk.h> #include <linux/fwnode_mdio.h> #include <linux/of.h> #include <linux/phy.h> @@ -104,7 +105,7 @@ int fwnode_mdiobus_phy_device_register(struct mii_bus *mdio, return rc; } - dev_dbg(&mdio->dev, "registered phy %p fwnode at address %i\n", + dev_dbg(&mdio->dev, "registered phy fwnode %pfw at address %i\n", child, addr); return 0; }
Was slightly misleading before, because printed is pointer to fwnode, not to phy device, as placement in message suggested. Include header for dev_dbg() declaration while at it. Output before: [ +0.001247] mdio_bus f802c000.ethernet-ffffffff: registered phy 2612f00a fwnode at address 3 Output after: [ +0.001229] mdio_bus f802c000.ethernet-ffffffff: registered phy fwnode /ahb/apb/ethernet@f802c000/ethernet-phy@3 at address 3 Signed-off-by: Alexander Dahl <ada@thorsis.com> --- drivers/net/mdio/fwnode_mdio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) base-commit: 8e69c96df771ab469cec278edb47009351de4da6