[bpf-next] bpf: change int cmd argument in __sys_bpf into typed enum bpf_cmd

Commit Message

Andrii Nakryiko Sept. 5, 2024, 9:05 p.m. UTC

This improves BTF data recorded about this function and makes
debugging/tracing better, because now command can be displayed as
symbolic name, instead of obscure number.

Signed-off-by: Andrii Nakryiko <[e-mail]>
---
 kernel/bpf/syscall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

[e-mail] Sept. 6, 2024, 12:10 a.m. UTC | #1

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <[e-mail]>:

On Thu,  5 Sep 2024 14:05:20 -0700 you wrote:
> This improves BTF data recorded about this function and makes
> debugging/tracing better, because now command can be displayed as
> symbolic name, instead of obscure number.
> 
> Signed-off-by: Andrii Nakryiko <[e-mail]>
> ---
>  kernel/bpf/syscall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [bpf-next] bpf: change int cmd argument in __sys_bpf into typed enum bpf_cmd
    https://git.kernel.org/bpf/bpf-next/c/2db2b8cb8f96

You are awesome, thank you!

Patch

diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index fc62f5c4faf9..6988e432fc3d 100644
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -5670,7 +5670,7 @@  static int token_create(union bpf_attr *attr)
 	return bpf_token_create(attr);
 }
 
-static int __sys_bpf(int cmd, bpfptr_t uattr, unsigned int size)
+static int __sys_bpf(enum bpf_cmd cmd, bpfptr_t uattr, unsigned int size)
 {
 	union bpf_attr attr;
 	int err;