| Message ID | 20240906055950.729327-1-roheetchavan@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | sfc: It's a small cleanup to use ERR_CAST() here. | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
This was already done as https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=74ce94ac38a6 Thanks, Martin On Fri, Sep 06, 2024 at 11:29:50AM +0530, Rohit Chavan wrote: > Using ERR_CAST() is more reasonable and safer, When it is necessary > to convert the type of an error pointer and return it. > > Signed-off-by: Rohit Chavan <roheetchavan@gmail.com> > --- > drivers/net/ethernet/sfc/tc_counters.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/tc_counters.c b/drivers/net/ethernet/sfc/tc_counters.c > index c44088424323..76d32641202b 100644 > --- a/drivers/net/ethernet/sfc/tc_counters.c > +++ b/drivers/net/ethernet/sfc/tc_counters.c > @@ -249,7 +249,7 @@ struct efx_tc_counter_index *efx_tc_flower_get_counter_index( > &ctr->linkage, > efx_tc_counter_id_ht_params); > kfree(ctr); > - return (void *)cnt; /* it's an ERR_PTR */ > + return ERR_CAST(cnt); /* it's an ERR_PTR */ > } > ctr->cnt = cnt; > refcount_set(&ctr->ref, 1); > -- > 2.34.1 >
diff --git a/drivers/net/ethernet/sfc/tc_counters.c b/drivers/net/ethernet/sfc/tc_counters.c index c44088424323..76d32641202b 100644 --- a/drivers/net/ethernet/sfc/tc_counters.c +++ b/drivers/net/ethernet/sfc/tc_counters.c @@ -249,7 +249,7 @@ struct efx_tc_counter_index *efx_tc_flower_get_counter_index( &ctr->linkage, efx_tc_counter_id_ht_params); kfree(ctr); - return (void *)cnt; /* it's an ERR_PTR */ + return ERR_CAST(cnt); /* it's an ERR_PTR */ } ctr->cnt = cnt; refcount_set(&ctr->ref, 1);
Using ERR_CAST() is more reasonable and safer, When it is necessary to convert the type of an error pointer and return it. Signed-off-by: Rohit Chavan <roheetchavan@gmail.com> --- drivers/net/ethernet/sfc/tc_counters.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)