diff mbox series

[bpf-next] MAINTAINERS: record lib/buildid.c as owned by BPF subsystem

Message ID 20240909190426.2229940-1-andrii@kernel.org (mailing list archive)
State Accepted
Commit 58ff04e2e22319e63ea646d9a38890c17836a7f6
Delegated to: BPF
Headers show
Series [bpf-next] MAINTAINERS: record lib/buildid.c as owned by BPF subsystem | expand

Checks

Context Check Description
bpf/vmtest-bpf-next-PR success PR summary
bpf/vmtest-bpf-next-VM_Test-0 success Logs for Lint
bpf/vmtest-bpf-next-VM_Test-1 success Logs for ShellCheck
bpf/vmtest-bpf-next-VM_Test-2 success Logs for Unittests
bpf/vmtest-bpf-next-VM_Test-3 success Logs for Validate matrix.py
bpf/vmtest-bpf-next-VM_Test-5 success Logs for aarch64-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-4 success Logs for aarch64-gcc / build / build for aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-10 success Logs for aarch64-gcc / veristat
bpf/vmtest-bpf-next-VM_Test-12 success Logs for s390x-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-11 success Logs for s390x-gcc / build / build for s390x with gcc
bpf/vmtest-bpf-next-VM_Test-16 success Logs for s390x-gcc / veristat
bpf/vmtest-bpf-next-VM_Test-17 success Logs for set-matrix
bpf/vmtest-bpf-next-VM_Test-18 success Logs for x86_64-gcc / build / build for x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-19 success Logs for x86_64-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-27 success Logs for x86_64-llvm-17 / build / build for x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-28 success Logs for x86_64-llvm-17 / build-release / build for x86_64 with llvm-17-O2
bpf/vmtest-bpf-next-VM_Test-33 success Logs for x86_64-llvm-17 / veristat
bpf/vmtest-bpf-next-VM_Test-34 success Logs for x86_64-llvm-18 / build / build for x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-35 success Logs for x86_64-llvm-18 / build-release / build for x86_64 with llvm-18-O2
bpf/vmtest-bpf-next-VM_Test-41 success Logs for x86_64-llvm-18 / veristat
bpf/vmtest-bpf-next-VM_Test-9 success Logs for aarch64-gcc / test (test_verifier, false, 360) / test_verifier on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-6 success Logs for aarch64-gcc / test (test_maps, false, 360) / test_maps on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-14 success Logs for s390x-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-15 success Logs for s390x-gcc / test (test_verifier, false, 360) / test_verifier on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-32 success Logs for x86_64-llvm-17 / test (test_verifier, false, 360) / test_verifier on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-7 success Logs for aarch64-gcc / test (test_progs, false, 360) / test_progs on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-22 success Logs for x86_64-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-20 success Logs for x86_64-gcc / test (test_maps, false, 360) / test_maps on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-8 success Logs for aarch64-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-13 success Logs for s390x-gcc / test (test_progs, false, 360) / test_progs on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-23 success Logs for x86_64-gcc / test (test_progs_no_alu32_parallel, true, 30) / test_progs_no_alu32_parallel on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-26 success Logs for x86_64-gcc / veristat / veristat on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-24 success Logs for x86_64-gcc / test (test_progs_parallel, true, 30) / test_progs_parallel on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-30 success Logs for x86_64-llvm-17 / test (test_progs, false, 360) / test_progs on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-29 success Logs for x86_64-llvm-17 / test (test_maps, false, 360) / test_maps on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-31 success Logs for x86_64-llvm-17 / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-36 success Logs for x86_64-llvm-18 / test (test_maps, false, 360) / test_maps on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-25 success Logs for x86_64-gcc / test (test_verifier, false, 360) / test_verifier on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-39 success Logs for x86_64-llvm-18 / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-21 success Logs for x86_64-gcc / test (test_progs, false, 360) / test_progs on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-37 success Logs for x86_64-llvm-18 / test (test_progs, false, 360) / test_progs on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-40 success Logs for x86_64-llvm-18 / test (test_verifier, false, 360) / test_verifier on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-38 success Logs for x86_64-llvm-18 / test (test_progs_cpuv4, false, 360) / test_progs_cpuv4 on x86_64 with llvm-18
netdev/tree_selection success Clearly marked for bpf-next
netdev/apply success Patch already applied to bpf-next-0

Commit Message

Andrii Nakryiko Sept. 9, 2024, 7:04 p.m. UTC 
Build ID fetching code originated from ([0]), and is still both owned
and heavily relied upon by BPF subsystem.

Fix the original omission in [0] to record this fact in MAINTAINERS.

  [0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

Comments

Alexei Starovoitov Sept. 9, 2024, 10:24 p.m. UTC | #1 
On Mon, Sep 9, 2024 at 12:04 PM Andrii Nakryiko <andrii@kernel.org> wrote:
>
> Build ID fetching code originated from ([0]), and is still both owned
> and heavily relied upon by BPF subsystem.

Song,

since you've added this logic back in
commit 615755a77b24 ("bpf: extend stackmap to save
binary_build_id+offset instead of address")

Pls provide your Ack.

> Fix the original omission in [0] to record this fact in MAINTAINERS.
>
>   [0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")

Jiri,

since you moved it in that commit pls Ack as well.

This change to the MAINTAINERS file should have been done back then.

So it's obvious who understands and maintains this code.

Currently get_maintainer.pl script is not helpful:

$ ./scripts/get_maintainer.pl lib/buildid.c
Andrew Morton <akpm@linux-foundation.org> (supporter:LIBRARY CODE)
linux-kernel@vger.kernel.org (open list:LIBRARY CODE)
Song Liu Sept. 9, 2024, 10:38 p.m. UTC | #2 
On Mon, Sep 9, 2024 at 12:04 PM Andrii Nakryiko <andrii@kernel.org> wrote:
>
> Build ID fetching code originated from ([0]), and is still both owned
> and heavily relied upon by BPF subsystem.
>
> Fix the original omission in [0] to record this fact in MAINTAINERS.
>
>   [0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")
>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>

Acked-by: Song Liu <song@kernel.org>

Thanks for making buildid parsing more reliable!

Song
Jiri Olsa Sept. 10, 2024, 6:51 p.m. UTC | #3 
On Mon, Sep 09, 2024 at 12:04:26PM -0700, Andrii Nakryiko wrote:
> Build ID fetching code originated from ([0]), and is still both owned
> and heavily relied upon by BPF subsystem.
> 
> Fix the original omission in [0] to record this fact in MAINTAINERS.
> 
>   [0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")
> 
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f328373463b0..a86834bb4c25 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4098,6 +4098,7 @@ F:	include/uapi/linux/btf*
>  F:	include/uapi/linux/filter.h
>  F:	kernel/bpf/
>  F:	kernel/trace/bpf_trace.c
> +F:	lib/buildid.c
>  F:	lib/test_bpf.c
>  F:	net/bpf/
>  F:	net/core/filter.c
> @@ -4218,6 +4219,7 @@ L:	bpf@vger.kernel.org
>  S:	Maintained
>  F:	kernel/bpf/stackmap.c
>  F:	kernel/trace/bpf_trace.c
> +F:	lib/buildid.c
>  
>  BROADCOM ASP 2.0 ETHERNET DRIVER
>  M:	Justin Chen <justin.chen@broadcom.com>
> -- 
> 2.43.5
>
patchwork-bot+netdevbpf@kernel.org Sept. 10, 2024, 9:40 p.m. UTC | #4 
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Mon,  9 Sep 2024 12:04:26 -0700 you wrote:
> Build ID fetching code originated from ([0]), and is still both owned
> and heavily relied upon by BPF subsystem.
> 
> Fix the original omission in [0] to record this fact in MAINTAINERS.
> 
>   [0] bd7525dacd7e ("bpf: Move stack_map_get_build_id into lib")
> 
> [...]

Here is the summary with links:
  - [bpf-next] MAINTAINERS: record lib/buildid.c as owned by BPF subsystem
    https://git.kernel.org/bpf/bpf-next/c/58ff04e2e223

You are awesome, thank you!
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index f328373463b0..a86834bb4c25 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4098,6 +4098,7 @@  F:	include/uapi/linux/btf*
 F:	include/uapi/linux/filter.h
 F:	kernel/bpf/
 F:	kernel/trace/bpf_trace.c
+F:	lib/buildid.c
 F:	lib/test_bpf.c
 F:	net/bpf/
 F:	net/core/filter.c
@@ -4218,6 +4219,7 @@  L:	bpf@vger.kernel.org
 S:	Maintained
 F:	kernel/bpf/stackmap.c
 F:	kernel/trace/bpf_trace.c
+F:	lib/buildid.c
 
 BROADCOM ASP 2.0 ETHERNET DRIVER
 M:	Justin Chen <justin.chen@broadcom.com>