| Message ID | 20240910075942.1270054-9-shaojijie@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add support of HIBMCGE Ethernet Driver | expand |
On Tue, Sep 10, 2024 at 1:36 PM Jijie Shao <shaojijie@huawei.com> wrote: > > Implement the .get_drvinfo .get_link .get_link_ksettings to get > the basic information and working status of the driver. > Implement the .set_link_ksettings to modify the rate, duplex, > and auto-negotiation status. > > Signed-off-by: Jijie Shao <shaojijie@huawei.com> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> > --- > ChangeLog: > RFC v1 -> RFC v2: > - Use ethtool_op_get_link(), phy_ethtool_get_link_ksettings(), > and phy_ethtool_set_link_ksettings() to simplify the code, suggested by Andrew. > - Delete workqueue for this patch set, suggested by Jonathan. > RFC v1: https://lore.kernel.org/all/20240731094245.1967834-1-shaojijie@huawei.com/ > --- > .../ethernet/hisilicon/hibmcge/hbg_ethtool.c | 17 +++++++++++++++++ > .../ethernet/hisilicon/hibmcge/hbg_ethtool.h | 11 +++++++++++ > .../net/ethernet/hisilicon/hibmcge/hbg_main.c | 2 ++ > 3 files changed, 30 insertions(+) > create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c > create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.h > > diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c b/drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c > new file mode 100644 > index 000000000000..c3370114aef3 > --- /dev/null > +++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c > @@ -0,0 +1,17 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +// Copyright (c) 2024 Hisilicon Limited. > + > +#include <linux/ethtool.h> > +#include <linux/phy.h> > +#include "hbg_ethtool.h" > + > +static const struct ethtool_ops hbg_ethtool_ops = { > + .get_link = ethtool_op_get_link, > + .get_link_ksettings = phy_ethtool_get_link_ksettings, > + .set_link_ksettings = phy_ethtool_set_link_ksettings, > +}; > + > +void hbg_ethtool_set_ops(struct net_device *netdev) > +{ > + netdev->ethtool_ops = &hbg_ethtool_ops; > +} > diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.h b/drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.h > new file mode 100644 > index 000000000000..628707ec2686 > --- /dev/null > +++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.h > @@ -0,0 +1,11 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* Copyright (c) 2024 Hisilicon Limited. */ > + > +#ifndef __HBG_ETHTOOL_H > +#define __HBG_ETHTOOL_H > + > +#include <linux/netdevice.h> > + > +void hbg_ethtool_set_ops(struct net_device *netdev); > + > +#endif > diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c b/drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c > index a8d0e951633b..b06524c336e2 100644 > --- a/drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c > +++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c > @@ -6,6 +6,7 @@ > #include <linux/netdevice.h> > #include <linux/pci.h> > #include "hbg_common.h" > +#include "hbg_ethtool.h" > #include "hbg_hw.h" > #include "hbg_irq.h" > #include "hbg_mdio.h" > @@ -235,6 +236,7 @@ static int hbg_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > netdev->min_mtu = priv->dev_specs.min_mtu; > hbg_change_mtu(priv, HBG_DEFAULT_MTU_SIZE); > hbg_net_set_mac_address(priv->netdev, &priv->dev_specs.mac_addr); > + hbg_ethtool_set_ops(netdev); > ret = devm_register_netdev(dev, netdev); > if (ret) > return dev_err_probe(dev, ret, "failed to register netdev\n"); > -- > 2.33.0 >
diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c b/drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c new file mode 100644 index 000000000000..c3370114aef3 --- /dev/null +++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c @@ -0,0 +1,17 @@ +// SPDX-License-Identifier: GPL-2.0+ +// Copyright (c) 2024 Hisilicon Limited. + +#include <linux/ethtool.h> +#include <linux/phy.h> +#include "hbg_ethtool.h" + +static const struct ethtool_ops hbg_ethtool_ops = { + .get_link = ethtool_op_get_link, + .get_link_ksettings = phy_ethtool_get_link_ksettings, + .set_link_ksettings = phy_ethtool_set_link_ksettings, +}; + +void hbg_ethtool_set_ops(struct net_device *netdev) +{ + netdev->ethtool_ops = &hbg_ethtool_ops; +} diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.h b/drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.h new file mode 100644 index 000000000000..628707ec2686 --- /dev/null +++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.h @@ -0,0 +1,11 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* Copyright (c) 2024 Hisilicon Limited. */ + +#ifndef __HBG_ETHTOOL_H +#define __HBG_ETHTOOL_H + +#include <linux/netdevice.h> + +void hbg_ethtool_set_ops(struct net_device *netdev); + +#endif diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c b/drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c index a8d0e951633b..b06524c336e2 100644 --- a/drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c +++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c @@ -6,6 +6,7 @@ #include <linux/netdevice.h> #include <linux/pci.h> #include "hbg_common.h" +#include "hbg_ethtool.h" #include "hbg_hw.h" #include "hbg_irq.h" #include "hbg_mdio.h" @@ -235,6 +236,7 @@ static int hbg_probe(struct pci_dev *pdev, const struct pci_device_id *ent) netdev->min_mtu = priv->dev_specs.min_mtu; hbg_change_mtu(priv, HBG_DEFAULT_MTU_SIZE); hbg_net_set_mac_address(priv->netdev, &priv->dev_specs.mac_addr); + hbg_ethtool_set_ops(netdev); ret = devm_register_netdev(dev, netdev); if (ret) return dev_err_probe(dev, ret, "failed to register netdev\n");