| Message ID | 20240910091044.3044568-1-danieller@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 716425d6f3fb7354023069042f240eddbc557504 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ethtool: Enhance error messages sent to user space | expand |
On Tue, Sep 10, 2024 at 12:10:44PM +0300, Danielle Ratson wrote: > During the firmware flashing process, notifications are sent to user > space to provide progress updates. When an error occurs, an error > message is sent to indicate what went wrong. > > In some cases, appropriate error messages are missing. > > Add relevant error messages where applicable, allowing user space to better > understand the issues encountered. > > Signed-off-by: Danielle Ratson <danieller@nvidia.com> > Reviewed-by: Petr Machata <petrm@nvidia.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 10 Sep 2024 12:10:44 +0300 you wrote: > During the firmware flashing process, notifications are sent to user > space to provide progress updates. When an error occurs, an error > message is sent to indicate what went wrong. > > In some cases, appropriate error messages are missing. > > Add relevant error messages where applicable, allowing user space to better > understand the issues encountered. > > [...] Here is the summary with links: - [net-next] net: ethtool: Enhance error messages sent to user space https://git.kernel.org/netdev/net-next/c/716425d6f3fb You are awesome, thank you!
diff --git a/net/ethtool/cmis_cdb.c b/net/ethtool/cmis_cdb.c index e27cad17505e..d159dc121bde 100644 --- a/net/ethtool/cmis_cdb.c +++ b/net/ethtool/cmis_cdb.c @@ -116,7 +116,8 @@ static u8 cmis_cdb_advert_rpl_inst_supported(struct cmis_cdb_advert_rpl *rpl) } static int cmis_cdb_advertisement_get(struct ethtool_cmis_cdb *cdb, - struct net_device *dev) + struct net_device *dev, + struct ethnl_module_fw_flash_ntf_params *ntf_params) { const struct ethtool_ops *ops = dev->ethtool_ops; struct ethtool_module_eeprom page_data = {}; @@ -135,8 +136,12 @@ static int cmis_cdb_advertisement_get(struct ethtool_cmis_cdb *cdb, return err; } - if (!cmis_cdb_advert_rpl_inst_supported(&rpl)) + if (!cmis_cdb_advert_rpl_inst_supported(&rpl)) { + ethnl_module_fw_flash_ntf_err(dev, ntf_params, + "CDB functionality is not supported", + NULL); return -EOPNOTSUPP; + } cdb->read_write_len_ext = rpl.read_write_len_ext; @@ -299,7 +304,7 @@ ethtool_cmis_cdb_init(struct net_device *dev, goto err; } - err = cmis_cdb_advertisement_get(cdb, dev); + err = cmis_cdb_advertisement_get(cdb, dev, ntf_params); if (err < 0) goto err; @@ -461,6 +466,9 @@ static void cmis_cdb_status_fail_msg_get(u8 status, char **err_msg) case 0b01000101: *err_msg = "CDB status failed: CdbChkCode error"; break; + case 0b01000110: + *err_msg = "CDB status failed: Password error"; + break; default: *err_msg = "Unknown failure reason"; }