diff mbox series

[net-next] net/smc: remove useless macros in smc_close.h

Message ID 20240912144240.8635-1-shaozhengchao@163.com (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series [net-next] net/smc: remove useless macros in smc_close.h | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 16 this patch: 16
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 10 of 10 maintainers
netdev/build_clang success Errors and warnings before: 16 this patch: 16
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 16 this patch: 16
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-09-13--03-00 (tests: 764)

Commit Message

shaozhengchao Sept. 12, 2024, 2:42 p.m. UTC 
After commit 51f1de79ad8e("net/smc: replace sock_put worker by
socket refcounting") is merged, SMC-COSES_SOCK_PUT_DELAY is no
longer used. So, remove it.

Signed-off-by: Zhengchao Shao <shaozhengchao@163.com>
---
 net/smc/smc_close.h | 1 -
 1 file changed, 1 deletion(-)

Comments

D. Wythe Sept. 13, 2024, 7:43 a.m. UTC | #1 
On 9/12/24 10:42 PM, Zhengchao Shao wrote:
> After commit 51f1de79ad8e("net/smc: replace sock_put worker by
> socket refcounting") is merged, SMC-COSES_SOCK_PUT_DELAY is no
> longer used. So, remove it.

SMC_CLOSE_SOCK_PUT_DELAY

> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@163.com>
> ---
>   net/smc/smc_close.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/net/smc/smc_close.h b/net/smc/smc_close.h
> index 634fea2b7c95..9baee2eafc3b 100644
> --- a/net/smc/smc_close.h
> +++ b/net/smc/smc_close.h
> @@ -17,7 +17,6 @@
>   #include "smc.h"
>   
>   #define SMC_MAX_STREAM_WAIT_TIMEOUT		(2 * HZ)
> -#define SMC_CLOSE_SOCK_PUT_DELAY		HZ
>   
>   void smc_close_wake_tx_prepared(struct smc_sock *smc);
>   int smc_close_active(struct smc_sock *smc);
shaozhengchao Sept. 13, 2024, 1:53 p.m. UTC | #2 
On 2024/9/13 15:43, D. Wythe wrote:
>
>
> On 9/12/24 10:42 PM, Zhengchao Shao wrote:
>> After commit 51f1de79ad8e("net/smc: replace sock_put worker by
>> socket refcounting") is merged, SMC-COSES_SOCK_PUT_DELAY is no
>> longer used. So, remove it.
>
> SMC_CLOSE_SOCK_PUT_DELAY

My mistake. Thank you for your review.

Zhengchao Shao

>
>>
>> Signed-off-by: Zhengchao Shao <shaozhengchao@163.com>
>> ---
>>   net/smc/smc_close.h | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/net/smc/smc_close.h b/net/smc/smc_close.h
>> index 634fea2b7c95..9baee2eafc3b 100644
>> --- a/net/smc/smc_close.h
>> +++ b/net/smc/smc_close.h
>> @@ -17,7 +17,6 @@
>>   #include "smc.h"
>>     #define SMC_MAX_STREAM_WAIT_TIMEOUT        (2 * HZ)
>> -#define SMC_CLOSE_SOCK_PUT_DELAY        HZ
>>     void smc_close_wake_tx_prepared(struct smc_sock *smc);
>>   int smc_close_active(struct smc_sock *smc);
diff mbox series

Patch

diff --git a/net/smc/smc_close.h b/net/smc/smc_close.h
index 634fea2b7c95..9baee2eafc3b 100644
--- a/net/smc/smc_close.h
+++ b/net/smc/smc_close.h
@@ -17,7 +17,6 @@ 
 #include "smc.h"
 
 #define SMC_MAX_STREAM_WAIT_TIMEOUT		(2 * HZ)
-#define SMC_CLOSE_SOCK_PUT_DELAY		HZ
 
 void smc_close_wake_tx_prepared(struct smc_sock *smc);
 int smc_close_active(struct smc_sock *smc);