From patchwork Fri Sep 13 19:17:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Borkmann X-Patchwork-Id: 13803973 X-Patchwork-Delegate: bpf@iogearbox.net Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BA48146A73 for ; Fri, 13 Sep 2024 19:18:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.133.104.62 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726255089; cv=none; b=JONUBnTx0jp5IbTur6ksfviypmkqX7kActyKnkItdCVZnogK0oizPd4bQq0gquMalMwHegcdwZ7/Vy3Ucrn6y3XYXzpaMhgZpPTtwYhZaFN4457nFJPmpqF2h5TmnJb+YxpIf9TVnF0tKLQMlrozp84Nrkx/gmxEHeHlM2HCtRg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726255089; c=relaxed/simple; bh=RPmrRJBqM9SpPwnx4H+4PK2CC89J5q2nxbJQ/NHX1hk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=I6NsVR6bVmmR15/TEY2OLjWp8zfgL+HGzs4zLXmCAUt7Ps22ixULPFMv6TWpdYQHP282UtoyG4sxboEcJh4TSL9CjLXZwJvHbMhx68fMrYPCXuG+7yrK9TrsRLoS9ViuoKn1Mq0YYAqWa8ygBZ3m+kr9ZS8oItC0ApiSZwtDdv0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iogearbox.net; spf=pass smtp.mailfrom=iogearbox.net; dkim=pass (2048-bit key) header.d=iogearbox.net header.i=@iogearbox.net header.b=hA9MVwMX; arc=none smtp.client-ip=213.133.104.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iogearbox.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iogearbox.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iogearbox.net header.i=@iogearbox.net header.b="hA9MVwMX" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=iogearbox.net; s=default2302; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=i1K3Fe5xrxK4db1zvKv5ra0JJIKXN5ZQxMI7s8bMBCM=; b=hA9MVwMXjaHkJgRhoBnsOci8Hp ggK3jo6ZrZlAjNJRgmblmLCZyLEUDJrLLOcZeUIxdknad8pA4XVBqZU3qJvcIJGHu0xgPh6sHn1jR YHVEFHoUhI5DyFphhapL+LgCrKhk43Nw6MFS2Jcrq3JLI0TWpvrO6FahR+6NE1tSgUcLOPkQD0C+3 Qg7NosgR5qkVo55OIN/N2m6v6+nPmjU9uUwtENXusZAbcEtOmXzVU9rHy4ZE862Eb3mv6gUHxT1rn Vjf2DCZpGBQOLn+dm5PZ1IqI2HaT8X9nqhEC1U7RyZivmrJY/vntc4hBdhLV+3vDBkXrVONTxsIz2 +lU+NFkw==; Received: from 43.249.197.178.dynamic.cust.swisscom.net ([178.197.249.43] helo=localhost) by www62.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1spBnr-000KtO-CK; Fri, 13 Sep 2024 21:17:59 +0200 From: Daniel Borkmann To: bpf@vger.kernel.org Cc: shung-hsi.yu@suse.com, andrii@kernel.org, ast@kernel.org, kongln9170@gmail.com, Daniel Borkmann Subject: [PATCH bpf-next v5 6/9] selftests/bpf: Fix ARG_PTR_TO_LONG {half-,}uninitialized test Date: Fri, 13 Sep 2024 21:17:51 +0200 Message-Id: <20240913191754.13290-6-daniel@iogearbox.net> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20240913191754.13290-1-daniel@iogearbox.net> References: <20240913191754.13290-1-daniel@iogearbox.net> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.10/27397/Fri Sep 13 10:48:01 2024) X-Patchwork-Delegate: bpf@iogearbox.net The assumption of 'in privileged mode reads from uninitialized stack locations are permitted' is not quite correct since the verifier was probing for read access rather than write access. Both tests need to be annotated as __success for privileged and unprivileged. Signed-off-by: Daniel Borkmann Acked-by: Andrii Nakryiko --- tools/testing/selftests/bpf/progs/verifier_int_ptr.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/testing/selftests/bpf/progs/verifier_int_ptr.c b/tools/testing/selftests/bpf/progs/verifier_int_ptr.c index 9fc3fae5cd83..87206803c025 100644 --- a/tools/testing/selftests/bpf/progs/verifier_int_ptr.c +++ b/tools/testing/selftests/bpf/progs/verifier_int_ptr.c @@ -8,7 +8,6 @@ SEC("socket") __description("ARG_PTR_TO_LONG uninitialized") __success -__failure_unpriv __msg_unpriv("invalid indirect read from stack R4 off -16+0 size 8") __naked void arg_ptr_to_long_uninitialized(void) { asm volatile (" \ @@ -36,9 +35,7 @@ __naked void arg_ptr_to_long_uninitialized(void) SEC("socket") __description("ARG_PTR_TO_LONG half-uninitialized") -/* in privileged mode reads from uninitialized stack locations are permitted */ -__success __failure_unpriv -__msg_unpriv("invalid indirect read from stack R4 off -16+4 size 8") +__success __retval(0) __naked void ptr_to_long_half_uninitialized(void) {