From patchwork Tue Sep 17 16:42:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Shenwei Wang X-Patchwork-Id: 13806345 X-Patchwork-Delegate: kuba@kernel.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062.outbound.protection.outlook.com [40.107.22.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80E2E175D5D for ; Tue, 17 Sep 2024 16:42:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726591358; cv=fail; b=CjFxlBsyiTTYK0aGzUYuj3QXHqa1uadDpretwrKQWme+tUjVcecpJZ0Vb3FwywlvJ7YzLuMbjELNnMeqgJwznJlNCPwVnUMq5FIyrxT/w/XG7njuGbdMw6hMEk6ryT+DOYPGXtCgudmAKxLretBL35492kF/hXvUlpLIWEbrS88= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726591358; c=relaxed/simple; bh=qEZhv7Mn1OyZb+6pt7dL6OgZS2o6e2nXNuMkcWFfDkQ=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=IHn+hUzPuk9ez7xSPW7Whcz7jCzTHjpLJQs0DJdUU0vwfIxGeoJ5sPU1CJHRbBysBwFS/k3eUbLxUUlsxqtWF92+DV/AYDO5Z79bv3HYoudosSpKtlaXfeXeqpsCJS/Q/IDhceWH0xnHFBgRUVeEoQdk6Hz13Qe9vgHbZZfkxYY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=TvUg1HVp; arc=fail smtp.client-ip=40.107.22.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="TvUg1HVp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VNWkGa6EB3wyKntziDr6at9jQ1GO5KAOQkqSNTOCKnuePGOBX2NHjzGlNtdLmP2bdO1xf6zg97oyAFSej9vHuWt5YxV9ADFPSeQDdBNHep/TVayoIUtdZ96tOWDaA2dgbnSf5UwRrRuaWBV1dRIQjwrO/KaUuLrI0XLwguerFfL6qlQwKECOSnVByZDMaA1xlqNwcMuC/YjW2D0kIuPzl6QkJF4TAQ5tltLEC+Us0afxZr6GgbTcEkIDmnGci840DU5fsjkI6S8TlqKDyK8UbsFNpK7LHzC0wTYWVgacUm4YzmeC8z1nJ7eLnDPk/MiwcJztIncIFic0mrgIWVab0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OKw+6S7SzqON/bK+GxEyJcna+fdmcTcNSLZYUOnesQI=; b=TM4I5o68GlFc44FDRQhm3kdOwGUlQTSzIkQ8phQPZ1MGEO5Qi0YmUG6g2K2EJO2o9rGY5S9cC6YlxApDRs+UjDs3fUu1FlR97hxt2xNpPGlwaDmo0eVeuOJh11zTau24NCSCPzqVh+S3wtRhAIdpp6EYQTA8CUqUicFIejq/9lXr7xnMuwI26C5rpFM9JScOiwtLIwuu+M/XmGAXJq52Whi6X3lPFkOLNGr5eSYz2ROswKpNlb1ZY/9HqNm8ajn7pnbIDAjTHmMuICC1g609qKUu40XzKVLbr2K/9htMKz7rOWOBPpL7O8cS2x2GmF7alvSKC/ZQrOePy9DQjBmmDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OKw+6S7SzqON/bK+GxEyJcna+fdmcTcNSLZYUOnesQI=; b=TvUg1HVpr6f48zhmxb9XzfmQDr1Eu+KV9cY0l5/FwFzqLyaRV+VL2B55FYUsy1Oa4+P6495ZWb1CKuHR8UmC74IWTGWvrDmilddwjB77nWVpCzYch5tTxHtazp6HwAGoRgmJ9Wf0vwaYIBXs5dRfO4hWkjdFYArbyZTyxOLV4h5iLKTx3VvRPc+qEU8vjSM4O3As6q3Anm0/7P7zjzdkPAxcq3f5SZ8oOHar47+rDEUAD0AbGoSe/OvbZZe5GizulCjkPhmoRg/O0N2wSA0CAa9qwKFL7c30VXT69UtDhGlgpyGkvm1htNl6SwfOSokL7jJ8VbpOTZIfd7D5RIVWVQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9185.eurprd04.prod.outlook.com (2603:10a6:102:231::11) by GVXPR04MB10633.eurprd04.prod.outlook.com (2603:10a6:150:225::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.23; Tue, 17 Sep 2024 16:42:33 +0000 Received: from PAXPR04MB9185.eurprd04.prod.outlook.com ([fe80::21bf:975e:f24d:1612]) by PAXPR04MB9185.eurprd04.prod.outlook.com ([fe80::21bf:975e:f24d:1612%3]) with mapi id 15.20.7939.022; Tue, 17 Sep 2024 16:42:33 +0000 From: Shenwei Wang To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: Alexandre Torgue , Jose Abreu , Wong Vee Khee , Ong Boon Leong , Chuah Kim Tatt , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-imx@nxp.com, Shenwei Wang Subject: [PATCH net] net: stmmac: dwmac4: extend timeout for VLAN Tag register busy bit check Date: Tue, 17 Sep 2024 11:42:06 -0500 Message-Id: <20240917164206.414714-1-shenwei.wang@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: BY5PR16CA0031.namprd16.prod.outlook.com (2603:10b6:a03:1a0::44) To PAXPR04MB9185.eurprd04.prod.outlook.com (2603:10a6:102:231::11) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9185:EE_|GVXPR04MB10633:EE_ X-MS-Office365-Filtering-Correlation-Id: db4d92bd-cc18-4fcc-131a-08dcd737ba4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|376014|7416014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?6hvGWaJDQ4W1KwMeXEWQ7kaUnutkmfz?= =?utf-8?q?Vda6RPHpc9tgPVNZUw1eo0b6l04R3XK9YRZHQPuB6lfbCyF4zQLKrcAhV86jF9RvT?= =?utf-8?q?1JAVE3L/xCTlVAkiLF/1wnu5vhB0nKowtXgSaiJExzr3gLOUX/wjMnpHhK2QMLmaR?= =?utf-8?q?sUWE4dODgn5YmNJUivIC26N/AmUKUb2EbGcarF9ZLMaKe+ho7qs6t6W77en3W3OUH?= =?utf-8?q?fSZGUdbEcV+RsOs/gjeSgfmLSL9pACjj1SnALQppyV+X++TmPhIXst1qTxDh0zizv?= =?utf-8?q?dVJGJqkY9qcdHUFQyTOwUniLaouNdm5o5BSlk11mJWtRT+OKju8y4Ww4j+jKDNlfS?= =?utf-8?q?DygBybMtTU80tisp/Ivy+/HYu2vDJstbCu2KT0TMv7ydlQ7BZr+UoGkQ3fhylV2gg?= =?utf-8?q?Gzle70hGDyjgSCXFvlYM19u163LpRV3qm/Z2EhMwodSiAEjt6eWc1Rpc4HoL4fvnp?= =?utf-8?q?H0lQ7Wm8E93zQyISL2rBb/uQIS+rFstGqz2/jpGUVE3FVZK21wNy8tlx7Tar3SG+E?= =?utf-8?q?0ggHCNa/V0yBmJwnZ292EbrRp8618fNHmJH7mAPSSndpARZnGlk3twr+ZMNYnGaiX?= =?utf-8?q?1ElqySC7RH7c41w7EDQF38UUWdBIH9WsZ/xX0tPwbcLMyCUhItsxGm6ztG0Cr7IOE?= =?utf-8?q?2xC6hNlJlBdaKbaV67bNkkXW3DEhLMExtODJJ+OMgiCsRnomOqjC9th0nwXmverDD?= =?utf-8?q?UcevbfArl98YEERAa9EyoPvqHtIarJVnJpdIjf0BtQN0wcR3HJXA2uCOq8PvJVW1F?= =?utf-8?q?Uj7A5Et2cKFgMQ3XiVqJssG7fG+ctYwP5V3p9UuukHQCRIKb4RclB0u95QWB2kpjg?= =?utf-8?q?MbCBtZf2sfVbxP/Dx+mR2v28TZX7rYiD5h08Ks/mO2BT4iG8hhPfvrpeuLVICBC2c?= =?utf-8?q?wwqAlm5orgRBfE60opaLd2as6hBGzBA37kUpSUzyV9iSNEmJBE8M3pflYMWFDmq7D?= =?utf-8?q?7Hnnb6HJz+NUgehNqQrWnPQttLIsCt37amGlelBneBEYIyKJ8BbHctsrPhiu8nnoI?= =?utf-8?q?qkh7lV9XHJkDLFBseWxnnm3iqPYpE15akHrk/SA0Bw+O06oRa5QrVxANUISeLA8Oh?= =?utf-8?q?T1Uq76KRmpVoHnBotCIX2y46VE5owgOqlNN1iTM2TTZlrUaq1vGeMaYDh61UlKco3?= =?utf-8?q?dYwk+yJQZiZgrWnwKx4+vHad73GVAsAjWrNWBmYX5pW8GE74sfSa9PoMxSKhghpkh?= =?utf-8?q?inLBP4p/IpyYVGCG8yZPcQIw8ZuiXGscLTz5sDpPeNJ9cZCyVggNl0io0bZ0maEeI?= =?utf-8?q?es48QFzDkA36w+K4Q0yGsDJ7MeKwziRXxeoq44QNydoPl1V1uw/WDNpsZSAJSadbC?= =?utf-8?q?AMA2DH+kM11/+pfll0X+1SqYi+VkK31lTA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9185.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(376014)(7416014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?SJ6yRgjCwoU787hczkv//Vsbbwg3?= =?utf-8?q?O7ART32yX7K5YH5p4OzSkQaf81SpVwy7lwjnjNV9EQ2uAH/CN3bNcKLWryIhSde8H?= =?utf-8?q?QsyjvvxSCUWvJmShB6ZkXeCawB4npXJNypd7PrtpodOve/L/tIVg87CvUDzrnesJo?= =?utf-8?q?WBoPGCujPA7IvOpmk44/UWEhKG5/RM3En2VlihGLZc8jlsirjJwNKHyNpIsZNU74s?= =?utf-8?q?LzgKMtPD6Y1GuapCYHHWjY9uJ6fh5ejDsD8XVKPAJ7LzUVCWgiKbvh/gRyETjW9Eg?= =?utf-8?q?6I0FbtQwpgjbO+14KYeSC3aPcsP77atCGXYJI+QSFXxuR3w0v7R2n2InmOnINYQSF?= =?utf-8?q?6178xu8KKs5VYzVKarDdQWMzrCy3TVFk7jWdiEbeQgMQ0eXNFUlw0zVBmOAencCyU?= =?utf-8?q?wUiYd4HeY1ozXft1KVOJSIKfaPv2q9lUHWRwfbzIGi7S6swU5i/9hgetglGSHTufo?= =?utf-8?q?D0EX3r+MJ2PAAEUfOAhn7j2RY9shj6IR7Mg60vskOHvBTpgSQ7GBEjqtuZBT7vcS4?= =?utf-8?q?AtYPjvR+LTtIZ08eEE7IUmxsZC7OhQ7DVYv0v54P6z9HJqY4OriSEnPb7zqt8QBpt?= =?utf-8?q?lIdu0IE2dYvLNDwmd0PhUIXnYjhJAsXaHb7quyAMBmG6KCjTAZ9mW0JSCUEJM6/bP?= =?utf-8?q?lCIu8iML7dCaevR7KuxdGI+/8++n7xidrGM8kGwpBxYLpjPcGwAqqxadc1R2JYBvh?= =?utf-8?q?KvFY0SRHRy2h7k+EVWLyKQ20EKR+nuY5rYjUCifTudMq6nuUzW3ecgNcmOTJiFTQ6?= =?utf-8?q?gAtLteumxUpz4CL9f0muNcoH2Pw4q+XYIBf9qAzs1BoC614ljXe4ztltTyxkJQg7/?= =?utf-8?q?n+t6xcju7kWq/TMbPaXzqklh8fBj7ciwPXL0CXSIb0QQVRWegzcBEwEK0MRZnO9ri?= =?utf-8?q?zMrN+kXEvZw805PIyw50Ny6DVOTTpwXa0uLBTY3U/3Y1A7SpB6RjYoF7bSQX2+N6y?= =?utf-8?q?ZHrrdVwdNTAi0/QSDQViANzZADKqdhNwz0AniNWRsucFeqZBtemOISsTxJrgauzvL?= =?utf-8?q?FOcgwq97B2w1pjBRGFDH+IR3zB3HtXAmKy52gMJ6kCxTqPe29fTefK4pLdJn2hs1K?= =?utf-8?q?RiniBMuq4tj2hU2bdUq2AKCzW6BRq/aO8cC9ZKLNawijE7/dH629UMsXx7oI0CtUC?= =?utf-8?q?E/aQfiJTUTTQ+e/TyXsM0600wGCyVXP6qpQFt5qeYNHCNRioiiRSE5+mC+UCxM0yo?= =?utf-8?q?IS2T/ham+7sJQMrJqwV4RDsksHaHGEzGay9aZcwjZQAm3GfO2QjRdJ36ygKuOSQPM?= =?utf-8?q?5Dlqrw41P4pSojH6hyMnRnWAGCA8TM4iDLz/v8mSUXlMlIpRlOxGelqm0UPjkFo3h?= =?utf-8?q?W97uE4F5VNzsch7qo5jkgKNVHrA6KyghJ6ENtuttLyjoS4RkG12Ii32i7tgeE7WkG?= =?utf-8?q?ovGQlXT2jh6bgCs+7k4sI+zqUwrK+JJSiVsNa+mEHeuzNYzNtQfS24coY9FLuz62X?= =?utf-8?q?59bgjoLhpDNjCseFzEm5ddRwOK2tpKd516apvCn/+oL08QHS5ch+dHNhxcu1GI2Jr?= =?utf-8?q?XUaPstaqQrbI?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: db4d92bd-cc18-4fcc-131a-08dcd737ba4b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2024 16:42:33.1595 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BTlOjNmO9ayg9cmbmJe3UPw1Vv60nD+1zrsyavdG3oFjm2Ev0dxyiAB6ktYpl99F888scrCHYy0WKzqvN3NHbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10633 X-Patchwork-Delegate: kuba@kernel.org Increase the timeout for checking the busy bit of the VLAN Tag register from 10µs to 500ms. This change is necessary to accommodate scenarios where Energy Efficient Ethernet (EEE) is enabled. Overnight testing revealed that when EEE is active, the busy bit can remain set for up to approximately 300ms. The new 500ms timeout provides a safety margin. This modification does not impact normal success path, as the function typically returns within 1µs in non-EEE scenarios. The extended timeout only affects the failure path. Fixes: ed64639bc1e0 ("net: stmmac: Add support for VLAN Rx filtering") Signed-off-by: Shenwei Wang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c index a1858f083eef..cd5e5434ac52 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c @@ -471,7 +471,7 @@ static int dwmac4_write_vlan_filter(struct net_device *dev, u8 index, u32 data) { void __iomem *ioaddr = (void __iomem *)dev->base_addr; - int i, timeout = 10; + int i, timeout = 500000; u32 val; if (index >= hw->num_vlan)