| Message ID | 20240919085746.16904-1-tklauser@distanz.ch (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] wireguard: Omit unnecessary memset of netdev private data | expand |
On Thu, Sep 19, 2024 at 10:57:46AM +0200, Tobias Klauser wrote: > The memory for netdev_priv is allocated using kvzalloc in > alloc_netdev_mqs before rtnl_link_ops->setup is called so there is no > need to zero it again in wg_setup. > > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Reviewed-by: Simon Horman <horms@kernel.org> ...
On Thu, Sep 19, 2024 at 10:57:46AM +0200, Tobias Klauser wrote: > The memory for netdev_priv is allocated using kvzalloc in > alloc_netdev_mqs before rtnl_link_ops->setup is called so there is no > need to zero it again in wg_setup. > > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Thanks. Seems reasonable to me. I'll queue it up in the wireguard tree. Jason
diff --git a/drivers/net/wireguard/device.c b/drivers/net/wireguard/device.c index 45e9b908dbfb..a2ba71fbbed4 100644 --- a/drivers/net/wireguard/device.c +++ b/drivers/net/wireguard/device.c @@ -302,7 +302,6 @@ static void wg_setup(struct net_device *dev) /* We need to keep the dst around in case of icmp replies. */ netif_keep_dst(dev); - memset(wg, 0, sizeof(*wg)); wg->dev = dev; }
The memory for netdev_priv is allocated using kvzalloc in alloc_netdev_mqs before rtnl_link_ops->setup is called so there is no need to zero it again in wg_setup. Signed-off-by: Tobias Klauser <tklauser@distanz.ch> --- drivers/net/wireguard/device.c | 1 - 1 file changed, 1 deletion(-)