| Message ID | 20240923063323.1935-1-kdipendra88@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net] net: Add error pointer check in otx2_flows.c | expand |
Hi, On 9/23/24 08:33, Dipendra Khadka wrote: > Adding error pointer check after calling otx2_mbox_get_rsp(). > > Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com> The commit message should include a 'Fixes' tag pointing to the commit introducing the issue. Also please include some actual wording in the commit message itself describing the issue and the fix. As Simon noted on the previous submission, please read carefully the process description under: https://www.kernel.org/doc/html/latest/process/ and especially: https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html Thanks, Paolo
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c index 98c31a16c70b..8a67c124b524 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c @@ -120,6 +120,11 @@ int otx2_alloc_mcam_entries(struct otx2_nic *pfvf, u16 count) rsp = (struct npc_mcam_alloc_entry_rsp *)otx2_mbox_get_rsp (&pfvf->mbox.mbox, 0, &req->hdr); + if (IS_ERR(rsp)) { + mutex_unlock(&pfvf->mbox.lock); + return PTR_ERR(rsp); + } + for (ent = 0; ent < rsp->count; ent++) flow_cfg->flow_ent[ent + allocated] = rsp->entry_list[ent]; @@ -198,6 +203,11 @@ int otx2_mcam_entry_init(struct otx2_nic *pfvf) rsp = (struct npc_mcam_alloc_entry_rsp *)otx2_mbox_get_rsp (&pfvf->mbox.mbox, 0, &req->hdr); + if (IS_ERR(rsp)) { + mutex_unlock(&pfvf->mbox.lock); + return PTR_ERR(rsp); + } + if (rsp->count != req->count) { netdev_info(pfvf->netdev, "Unable to allocate MCAM entries for ucast, vlan and vf_vlan\n"); @@ -233,6 +243,11 @@ int otx2_mcam_entry_init(struct otx2_nic *pfvf) frsp = (struct npc_get_field_status_rsp *)otx2_mbox_get_rsp (&pfvf->mbox.mbox, 0, &freq->hdr); + if (IS_ERR(frsp)) { + mutex_unlock(&pfvf->mbox.lock); + return PTR_ERR(frsp); + } + if (frsp->enable) { pfvf->flags |= OTX2_FLAG_RX_VLAN_SUPPORT; pfvf->flags |= OTX2_FLAG_VF_VLAN_SUPPORT;
Adding error pointer check after calling otx2_mbox_get_rsp(). Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com> --- v2: - Changed the subject to net - Changed the typo of the vairable from bfvp to pfvf v1: https://lore.kernel.org/all/20240922185235.50413-1-kdipendra88@gmail.com/ .../ethernet/marvell/octeontx2/nic/otx2_flows.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)