diff mbox series

[1/1] netlabel: Add missing comment to struct field

Message ID 20240923080733.2914087-1-dongtai.guo@linux.dev (mailing list archive)
State Deferred
Delegated to: Netdev Maintainers
Headers show
Series [1/1] netlabel: Add missing comment to struct field | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 16 this patch: 16
netdev/build_tools success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/build_clang success Errors and warnings before: 16 this patch: 16
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 25 this patch: 25
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 6 this patch: 5
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-09-24--03-00 (tests: 762)

Commit Message

George Guo Sept. 23, 2024, 8:07 a.m. UTC 
From: George Guo <guodongtai@kylinos.cn>

add a comment to doi_remove in struct netlbl_calipso_ops.

Flagged by ./scripts/kernel-doc -none.

Signed-off-by: George Guo <guodongtai@kylinos.cn>
---
 include/net/netlabel.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Paul Moore Sept. 23, 2024, 11:52 a.m. UTC | #1 
On Mon, Sep 23, 2024 at 4:08 AM George Guo <dongtai.guo@linux.dev> wrote:
>
> From: George Guo <guodongtai@kylinos.cn>
>
> add a comment to doi_remove in struct netlbl_calipso_ops.
>
> Flagged by ./scripts/kernel-doc -none.
>
> Signed-off-by: George Guo <guodongtai@kylinos.cn>
> ---
>  include/net/netlabel.h | 1 +
>  1 file changed, 1 insertion(+)

Looks good to me.

Acked-by: Paul Moore <paul@paul-moore.com>

> diff --git a/include/net/netlabel.h b/include/net/netlabel.h
> index 529160f76cac..4afd934b1238 100644
> --- a/include/net/netlabel.h
> +++ b/include/net/netlabel.h
> @@ -208,6 +208,7 @@ struct netlbl_lsm_secattr {
>   * struct netlbl_calipso_ops - NetLabel CALIPSO operations
>   * @doi_add: add a CALIPSO DOI
>   * @doi_free: free a CALIPSO DOI
> + * @doi_remove: remove a CALIPSO DOI
>   * @doi_getdef: returns a reference to a DOI
>   * @doi_putdef: releases a reference of a DOI
>   * @doi_walk: enumerate the DOI list
> --
> 2.34.1
Paolo Abeni Sept. 24, 2024, 10:43 a.m. UTC | #2 
On 9/23/24 10:07, George Guo wrote:
> From: George Guo <guodongtai@kylinos.cn>
> 
> add a comment to doi_remove in struct netlbl_calipso_ops.
> 
> Flagged by ./scripts/kernel-doc -none.
> 
> Signed-off-by: George Guo <guodongtai@kylinos.cn>

## Form letter - net-next-closed

The merge window for v6.12 and therefore net-next is closed for new
drivers, features, code refactoring and optimizations. We are currently
accepting bug fixes only.

Please repost when net-next reopens after Sept 30th.

RFC patches sent for review only are obviously welcome at any time.

See:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
diff mbox series

Patch

diff --git a/include/net/netlabel.h b/include/net/netlabel.h
index 529160f76cac..4afd934b1238 100644
--- a/include/net/netlabel.h
+++ b/include/net/netlabel.h
@@ -208,6 +208,7 @@  struct netlbl_lsm_secattr {
  * struct netlbl_calipso_ops - NetLabel CALIPSO operations
  * @doi_add: add a CALIPSO DOI
  * @doi_free: free a CALIPSO DOI
+ * @doi_remove: remove a CALIPSO DOI
  * @doi_getdef: returns a reference to a DOI
  * @doi_putdef: releases a reference of a DOI
  * @doi_walk: enumerate the DOI list