| Message ID | 20240923110633.3782-1-kdipendra88@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: ethernet: marvell: octeontx2: nic: Add error pointer check in otx2_common.c | expand |
Hi, On Mon, 23 Sep 2024 11:06:32 +0000 Dipendra Khadka <kdipendra88@gmail.com> wrote: > Add error pointer check after calling otx2_mbox_get_rsp(). As this is a fix, you need a Fixes: tag. > Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com> > --- > drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > index 87d5776e3b88..6e5f1b2e8c52 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > @@ -1838,6 +1838,11 @@ u16 otx2_get_max_mtu(struct otx2_nic *pfvf) > rsp = (struct nix_hw_info *) > otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr); > > + if (IS_ERR(rsp)) { > + mutex_unlock(&pfvf->mbox.lock); > + return PTR_ERR(rsp); > + } You're returning an error code as the max MTU, which will be propagated to netdev->max_mtu, that's not correct. There's already an error path in this function that you can use. Thanks, Maxime
Hi, On Mon, 23 Sept 2024 at 21:17, Maxime Chevallier <maxime.chevallier@bootlin.com> wrote: > > Hi, > > On Mon, 23 Sep 2024 11:06:32 +0000 > Dipendra Khadka <kdipendra88@gmail.com> wrote: > > > Add error pointer check after calling otx2_mbox_get_rsp(). > > As this is a fix, you need a Fixes: tag. > > > Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com> > > --- > > drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > > index 87d5776e3b88..6e5f1b2e8c52 100644 > > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > > @@ -1838,6 +1838,11 @@ u16 otx2_get_max_mtu(struct otx2_nic *pfvf) > > rsp = (struct nix_hw_info *) > > otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr); > > > > + if (IS_ERR(rsp)) { > > + mutex_unlock(&pfvf->mbox.lock); > > + return PTR_ERR(rsp); > > + } > > You're returning an error code as the max MTU, which will be propagated > to netdev->max_mtu, that's not correct. There's already an error path in > this function that you can use. > Sure, thanks for the response. I will send a v2 . > Thanks, > > Maxime Best regards, Dipendra
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c index 87d5776e3b88..6e5f1b2e8c52 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c @@ -1838,6 +1838,11 @@ u16 otx2_get_max_mtu(struct otx2_nic *pfvf) rsp = (struct nix_hw_info *) otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr); + if (IS_ERR(rsp)) { + mutex_unlock(&pfvf->mbox.lock); + return PTR_ERR(rsp); + } + /* HW counts VLAN insertion bytes (8 for double tag) * irrespective of whether SQE is requesting to insert VLAN * in the packet or not. Hence these 8 bytes have to be
Add error pointer check after calling otx2_mbox_get_rsp(). Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com> --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 5 +++++ 1 file changed, 5 insertions(+)