| Message ID | 20240924091117.8137-1-shenlichuan@vivo.com (mailing list archive) |
|---|---|
| State | Deferred |
| Headers | show |
| Series | [v1] isdn: mISDN: Correct typos in multiple comments across various files | expand |
On Tue, Sep 24, 2024 at 05:11:17PM +0800, Shen Lichuan wrote: > Fixed some confusing spelling errors that were currently identified, > the details are as follows: > > -in the code comments: > netjet.c: 382: overun ==> overrun > w6692.c: 776: reqest ==> request > dsp_audio.c: 208: tabels ==> tables > dsp_cmx.c: 575: suppoted ==> supported > hwchannel.c: 369: imediately ==> immediately > > Signed-off-by: Shen Lichuan <shenlichuan@vivo.com> > --- > drivers/isdn/hardware/mISDN/netjet.c | 2 +- > drivers/isdn/hardware/mISDN/w6692.c | 2 +- > drivers/isdn/mISDN/dsp_audio.c | 2 +- > drivers/isdn/mISDN/dsp_cmx.c | 2 +- > drivers/isdn/mISDN/hwchannel.c | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) Hi Shen, Thanks for your patch. Running codespell over the files modified by this patch indicates that the following spelling errors remain, I'd suggest addressing them too. drivers/isdn/hardware/mISDN/w6692.c:861: oscilator ==> oscillator drivers/isdn/mISDN/dsp_audio.c:181: aplitude ==> amplitude, aptitude drivers/isdn/mISDN/dsp_cmx.c:2: conferrencing ==> conferencing Or perhaps consider extending spelling fixes to cover all files under drivers/isdn/mISDN and drivers/isdn/hardware/mISDN. There seem to be a lot, so if so might consider one patch per sub-directory or something like that to break things up a bit. On process: It is my understanding that patches for drivers/isdn are handled by the netdev maintainers. That is non-bug fixes go into net-next, and bug fixes go into net. In this case it is not a but fix, so the patch should be targeted at net-next, like this. Subject: [PATCH net-next v2] ... Currently net-next is closed for the v6.12 merge window. It should reopen after v6.12-rc1 has been released, which I expect to take place a little under a week from now. Other than RFCs, patches shouldn't be posted for net-next while it is closed. So please repost your patch, or post an updated patch once it reopens. You can find out more about the development process for the Networking subsystem here: https://docs.kernel.org/process/maintainer-netdev.html ...
diff --git a/drivers/isdn/hardware/mISDN/netjet.c b/drivers/isdn/hardware/mISDN/netjet.c index d163850c295e..ecf20159bb4e 100644 --- a/drivers/isdn/hardware/mISDN/netjet.c +++ b/drivers/isdn/hardware/mISDN/netjet.c @@ -379,7 +379,7 @@ read_dma(struct tiger_ch *bc, u32 idx, int cnt) return; } stat = bchannel_get_rxbuf(&bc->bch, cnt); - /* only transparent use the count here, HDLC overun is detected later */ + /* only transparent use the count here, HDLC overrun is detected later */ if (stat == -ENOMEM) { pr_warn("%s.B%d: No memory for %d bytes\n", card->name, bc->bch.nr, cnt); diff --git a/drivers/isdn/hardware/mISDN/w6692.c b/drivers/isdn/hardware/mISDN/w6692.c index ee69212ac351..314f8ff42bbd 100644 --- a/drivers/isdn/hardware/mISDN/w6692.c +++ b/drivers/isdn/hardware/mISDN/w6692.c @@ -773,7 +773,7 @@ w6692_irq(int intno, void *dev_id) spin_lock(&card->lock); ista = ReadW6692(card, W_ISTA); if ((ista | card->imask) == card->imask) { - /* possible a shared IRQ reqest */ + /* possible a shared IRQ request */ spin_unlock(&card->lock); return IRQ_NONE; } diff --git a/drivers/isdn/mISDN/dsp_audio.c b/drivers/isdn/mISDN/dsp_audio.c index bbef98e7a16e..4ec8418215cd 100644 --- a/drivers/isdn/mISDN/dsp_audio.c +++ b/drivers/isdn/mISDN/dsp_audio.c @@ -205,7 +205,7 @@ dsp_audio_generate_seven(void) sorted_alaw[j] = i; } - /* generate tabels */ + /* generate tables */ for (i = 0; i < 256; i++) { /* spl is the source: the law-sample (converted to alaw) */ spl = i; diff --git a/drivers/isdn/mISDN/dsp_cmx.c b/drivers/isdn/mISDN/dsp_cmx.c index 53fad9487574..b4fbf4a7af65 100644 --- a/drivers/isdn/mISDN/dsp_cmx.c +++ b/drivers/isdn/mISDN/dsp_cmx.c @@ -572,7 +572,7 @@ dsp_cmx_hardware(struct dsp_conf *conf, struct dsp *dsp) __func__, member->dsp->name); goto conf_software; } - /* check if member changes volume at an not suppoted level */ + /* check if member changes volume at an not supported level */ if (member->dsp->tx_volume) { if (dsp_debug & DEBUG_DSP_CMX) printk(KERN_DEBUG diff --git a/drivers/isdn/mISDN/hwchannel.c b/drivers/isdn/mISDN/hwchannel.c index 8c93af06ed02..9e8decdb44b6 100644 --- a/drivers/isdn/mISDN/hwchannel.c +++ b/drivers/isdn/mISDN/hwchannel.c @@ -366,7 +366,7 @@ get_next_bframe(struct bchannel *bch) if (bch->tx_skb) { bch->next_skb = NULL; test_and_clear_bit(FLG_TX_NEXT, &bch->Flags); - /* confirm imediately to allow next data */ + /* confirm immediately to allow next data */ confirm_Bsend(bch); return 1; } else {
Fixed some confusing spelling errors that were currently identified, the details are as follows: -in the code comments: netjet.c: 382: overun ==> overrun w6692.c: 776: reqest ==> request dsp_audio.c: 208: tabels ==> tables dsp_cmx.c: 575: suppoted ==> supported hwchannel.c: 369: imediately ==> immediately Signed-off-by: Shen Lichuan <shenlichuan@vivo.com> --- drivers/isdn/hardware/mISDN/netjet.c | 2 +- drivers/isdn/hardware/mISDN/w6692.c | 2 +- drivers/isdn/mISDN/dsp_audio.c | 2 +- drivers/isdn/mISDN/dsp_cmx.c | 2 +- drivers/isdn/mISDN/hwchannel.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)