diff mbox series

[bpf-next] bpftool: Remove llvm-strip from Makefile

Message ID 20240924165202.1379930-1-chen.dylane@gmail.com (mailing list archive)
State Accepted
Commit 25bfc6333e32ceee7b9da9ba260aeb4ac3144faf
Delegated to: BPF
Headers show
Series [bpf-next] bpftool: Remove llvm-strip from Makefile | expand

Checks

Context Check Description
bpf/vmtest-bpf-next-PR success PR summary
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for bpf-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 9 this patch: 9
netdev/build_tools success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 9 maintainers not CCed: sdf@fomichev.me llvm@lists.linux.dev haoluo@google.com ndesaulniers@google.com nathan@kernel.org justinstitt@google.com morbo@google.com kpsingh@kernel.org john.fastabend@gmail.com
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 11 this patch: 11
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
bpf/vmtest-bpf-next-VM_Test-0 success Logs for Lint
bpf/vmtest-bpf-next-VM_Test-1 success Logs for ShellCheck
bpf/vmtest-bpf-next-VM_Test-2 success Logs for Unittests
bpf/vmtest-bpf-next-VM_Test-3 success Logs for Validate matrix.py
bpf/vmtest-bpf-next-VM_Test-5 success Logs for aarch64-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-12 success Logs for s390x-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-4 success Logs for aarch64-gcc / build / build for aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-10 success Logs for aarch64-gcc / veristat
bpf/vmtest-bpf-next-VM_Test-9 success Logs for aarch64-gcc / test (test_verifier, false, 360) / test_verifier on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-8 success Logs for aarch64-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-6 success Logs for aarch64-gcc / test (test_maps, false, 360) / test_maps on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-7 success Logs for aarch64-gcc / test (test_progs, false, 360) / test_progs on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-17 success Logs for set-matrix
bpf/vmtest-bpf-next-VM_Test-16 success Logs for s390x-gcc / veristat
bpf/vmtest-bpf-next-VM_Test-11 success Logs for s390x-gcc / build / build for s390x with gcc
bpf/vmtest-bpf-next-VM_Test-19 success Logs for x86_64-gcc / build-release
bpf/vmtest-bpf-next-VM_Test-15 success Logs for s390x-gcc / test (test_verifier, false, 360) / test_verifier on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-18 success Logs for x86_64-gcc / build / build for x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-27 success Logs for x86_64-llvm-17 / build / build for x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-33 success Logs for x86_64-llvm-17 / veristat
bpf/vmtest-bpf-next-VM_Test-14 success Logs for s390x-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-13 success Logs for s390x-gcc / test (test_progs, false, 360) / test_progs on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-28 success Logs for x86_64-llvm-17 / build-release / build for x86_64 with llvm-17-O2
bpf/vmtest-bpf-next-VM_Test-34 success Logs for x86_64-llvm-18 / build / build for x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-35 success Logs for x86_64-llvm-18 / build-release / build for x86_64 with llvm-18-O2
bpf/vmtest-bpf-next-VM_Test-41 success Logs for x86_64-llvm-18 / veristat
bpf/vmtest-bpf-next-VM_Test-25 success Logs for x86_64-gcc / test (test_verifier, false, 360) / test_verifier on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-20 success Logs for x86_64-gcc / test (test_maps, false, 360) / test_maps on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-32 success Logs for x86_64-llvm-17 / test (test_verifier, false, 360) / test_verifier on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-21 success Logs for x86_64-gcc / test (test_progs, false, 360) / test_progs on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-22 success Logs for x86_64-gcc / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-26 success Logs for x86_64-gcc / veristat / veristat on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-31 success Logs for x86_64-llvm-17 / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-24 success Logs for x86_64-gcc / test (test_progs_parallel, true, 30) / test_progs_parallel on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-23 success Logs for x86_64-gcc / test (test_progs_no_alu32_parallel, true, 30) / test_progs_no_alu32_parallel on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-30 success Logs for x86_64-llvm-17 / test (test_progs, false, 360) / test_progs on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-37 success Logs for x86_64-llvm-18 / test (test_progs, false, 360) / test_progs on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-36 success Logs for x86_64-llvm-18 / test (test_maps, false, 360) / test_maps on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-40 success Logs for x86_64-llvm-18 / test (test_verifier, false, 360) / test_verifier on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-29 success Logs for x86_64-llvm-17 / test (test_maps, false, 360) / test_maps on x86_64 with llvm-17
bpf/vmtest-bpf-next-VM_Test-38 success Logs for x86_64-llvm-18 / test (test_progs_cpuv4, false, 360) / test_progs_cpuv4 on x86_64 with llvm-18
bpf/vmtest-bpf-next-VM_Test-39 success Logs for x86_64-llvm-18 / test (test_progs_no_alu32, false, 360) / test_progs_no_alu32 on x86_64 with llvm-18

Commit Message

Tao Chen Sept. 24, 2024, 4:52 p.m. UTC 
As Quentin and Andrri said [0], bpftool gen object strips
out DWARF already, so remove the repeat operation.

[0] https://github.com/libbpf/bpftool/issues/161

Suggested-by: Andrii Nakryiko <andrii@kernel.org>
Suggested-by: Quentin Monnet <qmo@kernel.org>
Signed-off-by: Tao Chen <chen.dylane@gmail.com>
---
 tools/bpf/bpftool/Makefile | 1 -
 1 file changed, 1 deletion(-)

Comments

Quentin Monnet Sept. 24, 2024, 6:35 p.m. UTC | #1 
2024-09-25 00:52 UTC+0800 ~ Tao Chen <chen.dylane@gmail.com>
> As Quentin and Andrri said [0], bpftool gen object strips
> out DWARF already, so remove the repeat operation.
> 
> [0] https://github.com/libbpf/bpftool/issues/161
> 
> Suggested-by: Andrii Nakryiko <andrii@kernel.org>
> Suggested-by: Quentin Monnet <qmo@kernel.org>
> Signed-off-by: Tao Chen <chen.dylane@gmail.com>

Acked-by: Quentin Monnet <qmo@kernel.org>

Thank you!
patchwork-bot+netdevbpf@kernel.org Sept. 25, 2024, 9:50 a.m. UTC | #2 
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Wed, 25 Sep 2024 00:52:02 +0800 you wrote:
> As Quentin and Andrri said [0], bpftool gen object strips
> out DWARF already, so remove the repeat operation.
> 
> [0] https://github.com/libbpf/bpftool/issues/161
> 
> Suggested-by: Andrii Nakryiko <andrii@kernel.org>
> Suggested-by: Quentin Monnet <qmo@kernel.org>
> Signed-off-by: Tao Chen <chen.dylane@gmail.com>
> 
> [...]

Here is the summary with links:
  - [bpf-next] bpftool: Remove llvm-strip from Makefile
    https://git.kernel.org/bpf/bpf-next/c/25bfc6333e32

You are awesome, thank you!
Daniel Borkmann Sept. 25, 2024, 10:32 a.m. UTC | #3 
On 9/25/24 11:50 AM, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
>
> This patch was applied to bpf/bpf-next.git (master)
> by Daniel Borkmann <daniel@iogearbox.net>:
>
> On Wed, 25 Sep 2024 00:52:02 +0800 you wrote:
>> As Quentin and Andrri said [0], bpftool gen object strips
>> out DWARF already, so remove the repeat operation.
>>
>> [0] https://github.com/libbpf/bpftool/issues/161
>>
>> Suggested-by: Andrii Nakryiko <andrii@kernel.org>
>> Suggested-by: Quentin Monnet <qmo@kernel.org>
>> Signed-off-by: Tao Chen <chen.dylane@gmail.com>
>>
>> [...]
I'll toss this shortly from the tree again, this missed that bpftool gen 
object call
needs to strip out dwarf.
>> Here is the summary with links:
>>    - [bpf-next] bpftool: Remove llvm-strip from Makefile
>>      https://git.kernel.org/bpf/bpf-next/c/25bfc6333e32
>>
>> You are awesome, thank you!
Tao Chen Sept. 25, 2024, 4:25 p.m. UTC | #4 
在 2024/9/25 18:32, Daniel Borkmann 写道:
> On 9/25/24 11:50 AM, patchwork-bot+netdevbpf@kernel.org wrote:
>> Hello:
>>
>> This patch was applied to bpf/bpf-next.git (master)
>> by Daniel Borkmann <daniel@iogearbox.net>:
>>
>> On Wed, 25 Sep 2024 00:52:02 +0800 you wrote:
>>> As Quentin and Andrri said [0], bpftool gen object strips
>>> out DWARF already, so remove the repeat operation.
>>>
>>> [0] https://github.com/libbpf/bpftool/issues/161
>>>
>>> Suggested-by: Andrii Nakryiko <andrii@kernel.org>
>>> Suggested-by: Quentin Monnet <qmo@kernel.org>
>>> Signed-off-by: Tao Chen <chen.dylane@gmail.com>
>>>
>>> [...]
> I'll toss this shortly from the tree again, this missed that bpftool gen 
> object call
> needs to strip out dwarf.

Hi Daniel, i saw linker_sanity_check_elf will ignore the dwarf sec, 
which means bpftool gen object will strip, is my understanding correct?

static int linker_sanity_check_elf(struct src_obj *obj)
{
	...
	if (is_dwarf_sec_name(sec->sec_name))
		continue;
	...
}
>>> Here is the summary with links:
>>>    - [bpf-next] bpftool: Remove llvm-strip from Makefile
>>>      https://git.kernel.org/bpf/bpf-next/c/25bfc6333e32
>>>
>>> You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
index ba927379eb20..43bd826b0879 100644
--- a/tools/bpf/bpftool/Makefile
+++ b/tools/bpf/bpftool/Makefile
@@ -219,7 +219,6 @@  $(OUTPUT)%.bpf.o: skeleton/%.bpf.c $(OUTPUT)vmlinux.h $(LIBBPF_BOOTSTRAP)
 		-I$(LIBBPF_BOOTSTRAP_INCLUDE) \
 		-g -O2 -Wall -fno-stack-protector \
 		--target=bpf -c $< -o $@
-	$(Q)$(LLVM_STRIP) -g $@
 
 $(OUTPUT)%.skel.h: $(OUTPUT)%.bpf.o $(BPFTOOL_BOOTSTRAP)
 	$(QUIET_GEN)$(BPFTOOL_BOOTSTRAP) gen skeleton $< > $@