diff mbox series

tools/net:Fix the wrong format specifier

Message ID 20240925085524.3525-1-zhujun2@cmss.chinamobile.com (mailing list archive)
State Deferred
Headers show
Series tools/net:Fix the wrong format specifier | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 7 this patch: 7
netdev/build_tools success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 2 maintainers not CCed: kuba@kernel.org donald.hunter@gmail.com
netdev/build_clang success Errors and warnings before: 7 this patch: 7
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 7 this patch: 7
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-09-25--12-00 (tests: 761)

Commit Message

Zhu Jun Sept. 25, 2024, 8:55 a.m. UTC
The format specifier of "unsigned int" in printf() should be "%u", not
"%d".

Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
 tools/net/ynl/samples/page-pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Horman Sept. 25, 2024, 7:53 p.m. UTC | #1
On Wed, Sep 25, 2024 at 01:55:24AM -0700, Zhu Jun wrote:
> The format specifier of "unsigned int" in printf() should be "%u", not
> "%d".
> 
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>

Hi Zhu Jun,

Thanks for your patch.

While this change looks good to me it looks like it is for net-next.
Currently net-next is closed for the v6.12 merge window. So please
repost this patch once it reopens, after v6.12-rc1 has been released.
I expect that to happen early next week.

Also, please explicitly target net-next patches for that tree like this:

  Subject: [PATCH net-next]

For reference, netdev processes are documented here:
https://docs.kernel.org/process/maintainer-netdev.html
Simon Horman Sept. 25, 2024, 7:59 p.m. UTC | #2
On Wed, Sep 25, 2024 at 08:53:54PM +0100, Simon Horman wrote:
> On Wed, Sep 25, 2024 at 01:55:24AM -0700, Zhu Jun wrote:
> > The format specifier of "unsigned int" in printf() should be "%u", not
> > "%d".
> > 
> > Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> 
> Hi Zhu Jun,
> 
> Thanks for your patch.
> 
> While this change looks good to me it looks like it is for net-next.
> Currently net-next is closed for the v6.12 merge window. So please
> repost this patch once it reopens, after v6.12-rc1 has been released.
> I expect that to happen early next week.
> 
> Also, please explicitly target net-next patches for that tree like this:
> 
>   Subject: [PATCH net-next]
> 
> For reference, netdev processes are documented here:
> https://docs.kernel.org/process/maintainer-netdev.html

Sorry, one more thing, looking at git history I think the prefix
for the patch should be 'tools: ynl: '. So perhaps:

   Subject: [PATCH net-next] tools: ynl: correct page-pool stat format specifier
diff mbox series

Patch

diff --git a/tools/net/ynl/samples/page-pool.c b/tools/net/ynl/samples/page-pool.c
index 332f281ee5cb..e5d521320fbf 100644
--- a/tools/net/ynl/samples/page-pool.c
+++ b/tools/net/ynl/samples/page-pool.c
@@ -118,7 +118,7 @@  int main(int argc, char **argv)
 			name = if_indextoname(s->ifc, ifname);
 			if (name)
 				printf("%8s", name);
-			printf("[%d]\t", s->ifc);
+			printf("[%u]\t", s->ifc);
 		}
 
 		printf("page pools: %u (zombies: %u)\n",