From patchwork Sun Sep 29 20:57:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Olsa X-Patchwork-Id: 13815237 X-Patchwork-Delegate: bpf@iogearbox.net Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2FE9175D32; Sun, 29 Sep 2024 20:59:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727643577; cv=none; b=YVj/JRAVc9qkRdgti3xNGxARA44WmlNSWgDXV1db7jJ9g0n+bMgYRrxjBlfcrfJbEPNQOmCZF9hzMikx8Y/p8WiIuIcB+HoWhQan7aa3PKiloSgfOMRfF1e8ImfX4Xb0t8mDN5KLXeXrR611wGETiut6HIOZh0LtFMGL4xXY/qg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727643577; c=relaxed/simple; bh=iytPBV/coYs8uklN481sCB6sr+lO7xPubDoHnHmKQm4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mJX5u9vvROJB1P2X/DzbHz/Uw5Qz7j25cbH1Bdpy7MKDs2LqoLed1ndnSwR1fbHCA8anGIN43Cz7rfcJgIBryYfONuuolcIN3GKJ6YxrALvEKvdrfscYd2GWTPqp7hSsKotHAK1qC8gONbE47mgfaTHpKhcu+rn2OnAIxtk/0v8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dVbrTRuY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dVbrTRuY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E7A2C4CEC5; Sun, 29 Sep 2024 20:59:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727643577; bh=iytPBV/coYs8uklN481sCB6sr+lO7xPubDoHnHmKQm4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dVbrTRuYkpu0qtaqULHFtRDkT4JV3LTuPtF+JA1JO45W02jTV4k3iJ1oyIuuaYWAZ INgOpqb387zxBxke0rhi15UM/CZpRhQg+/qE5BW5U4IykMrmDKoFfF5DCzJrVba9yN vEiIVg5L3KvjDi/yz7rg1FpcqZFPhmAEIk9JyyZp+P9PsfqRPoSrnjd2R5EHugIQ3z jcTVgo9thAqsvNa3SBmjxjwkz+rSZZB6yntPax+IXX8o2blCewHjTrtFU3vAbTLp0I 2TNfCuVwveLqheABw+jUk/KzRLUx46ErNpW+032vW/tfV6Ov6Iqchp6Hmtc78pDKto AHwzlinwqK1wA== From: Jiri Olsa To: Oleg Nesterov , Peter Zijlstra , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: bpf@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Steven Rostedt , Masami Hiramatsu , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCHv5 bpf-next 11/13] selftests/bpf: Add kprobe session verifier test for return value Date: Sun, 29 Sep 2024 22:57:15 +0200 Message-ID: <20240929205717.3813648-12-jolsa@kernel.org> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20240929205717.3813648-1-jolsa@kernel.org> References: <20240929205717.3813648-1-jolsa@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: bpf@iogearbox.net Making sure kprobe.session program can return only [0,1] values. Signed-off-by: Jiri Olsa --- .../bpf/prog_tests/kprobe_multi_test.c | 2 ++ .../bpf/progs/kprobe_multi_verifier.c | 31 +++++++++++++++++++ 2 files changed, 33 insertions(+) create mode 100644 tools/testing/selftests/bpf/progs/kprobe_multi_verifier.c diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c index 960c9323d1e0..66ab1cae923e 100644 --- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c +++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c @@ -6,6 +6,7 @@ #include "kprobe_multi_override.skel.h" #include "kprobe_multi_session.skel.h" #include "kprobe_multi_session_cookie.skel.h" +#include "kprobe_multi_verifier.skel.h" #include "bpf/libbpf_internal.h" #include "bpf/hashmap.h" @@ -764,4 +765,5 @@ void test_kprobe_multi_test(void) test_session_skel_api(); if (test__start_subtest("session_cookie")) test_session_cookie_skel_api(); + RUN_TESTS(kprobe_multi_verifier); } diff --git a/tools/testing/selftests/bpf/progs/kprobe_multi_verifier.c b/tools/testing/selftests/bpf/progs/kprobe_multi_verifier.c new file mode 100644 index 000000000000..288577e81deb --- /dev/null +++ b/tools/testing/selftests/bpf/progs/kprobe_multi_verifier.c @@ -0,0 +1,31 @@ +// SPDX-License-Identifier: GPL-2.0 +#include "vmlinux.h" +#include +#include +#include +#include "bpf_misc.h" + +char _license[] SEC("license") = "GPL"; + + +SEC("kprobe.session") +__success +int kprobe_session_return_0(struct pt_regs *ctx) +{ + return 0; +} + +SEC("kprobe.session") +__success +int kprobe_session_return_1(struct pt_regs *ctx) +{ + return 1; +} + +SEC("kprobe.session") +__failure +__msg("At program exit the register R0 has smin=2 smax=2 should have been in [0, 1]") +int kprobe_session_return_2(struct pt_regs *ctx) +{ + return 2; +}