| Message ID | 20241001110542.5404-2-riyandhiman14@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c55ff46aeebed1704a9a6861777b799f15ce594d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v2] octeontx2-af: Change block parameter to const pointer in get_lf_str_list | expand |
On Tue, Oct 01, 2024 at 04:35:43PM +0530, Riyan Dhiman wrote: > Convert struct rvu_block block to const struct rvu_block *block in > get_lf_str_list() function parameter. This improves efficiency by > avoiding structure copying and reflects the function's read-only > access to block. > > Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com> > --- > v2: change target branch to net-next and remove fix tag. > Compile tested only Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 1 Oct 2024 16:35:43 +0530 you wrote: > Convert struct rvu_block block to const struct rvu_block *block in > get_lf_str_list() function parameter. This improves efficiency by > avoiding structure copying and reflects the function's read-only > access to block. > > Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com> > > [...] Here is the summary with links: - [net-next,v2] octeontx2-af: Change block parameter to const pointer in get_lf_str_list https://git.kernel.org/netdev/net-next/c/c55ff46aeebe You are awesome, thank you!
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c index 87ba77e5026a..8c700ee4a82b 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c @@ -663,16 +663,16 @@ static ssize_t rvu_dbg_lmtst_map_table_display(struct file *filp, RVU_DEBUG_FOPS(lmtst_map_table, lmtst_map_table_display, NULL); -static void get_lf_str_list(struct rvu_block block, int pcifunc, +static void get_lf_str_list(const struct rvu_block *block, int pcifunc, char *lfs) { - int lf = 0, seq = 0, len = 0, prev_lf = block.lf.max; + int lf = 0, seq = 0, len = 0, prev_lf = block->lf.max; - for_each_set_bit(lf, block.lf.bmap, block.lf.max) { - if (lf >= block.lf.max) + for_each_set_bit(lf, block->lf.bmap, block->lf.max) { + if (lf >= block->lf.max) break; - if (block.fn_map[lf] != pcifunc) + if (block->fn_map[lf] != pcifunc) continue; if (lf == prev_lf + 1) { @@ -719,7 +719,7 @@ static int get_max_column_width(struct rvu *rvu) if (!strlen(block.name)) continue; - get_lf_str_list(block, pcifunc, buf); + get_lf_str_list(&block, pcifunc, buf); if (lf_str_size <= strlen(buf)) lf_str_size = strlen(buf) + 1; } @@ -803,7 +803,7 @@ static ssize_t rvu_dbg_rsrc_attach_status(struct file *filp, continue; len = 0; lfs[len] = '\0'; - get_lf_str_list(block, pcifunc, lfs); + get_lf_str_list(&block, pcifunc, lfs); if (strlen(lfs)) flag = 1;
Convert struct rvu_block block to const struct rvu_block *block in get_lf_str_list() function parameter. This improves efficiency by avoiding structure copying and reflects the function's read-only access to block. Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com> --- v2: change target branch to net-next and remove fix tag. Compile tested only .../ethernet/marvell/octeontx2/af/rvu_debugfs.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)