| Message ID | 20241003162310.1310576-1-daniel.zahka@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5c2ab978f9c90384198000a032d10382f44c3530 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v1] ethtool: rss: fix rss key initialization warning | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 3 Oct 2024 09:23:10 -0700 you wrote: > This warning is emitted when a driver does not default populate an rss > key when one is not provided from userspace. Some devices do not > support individual rss keys per context. For these devices, it is ok > to leave the key zeroed out in ethtool_rxfh_context. Do not warn on > zeroed key when ethtool_ops.rxfh_per_ctx_key == 0. > > Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com> > > [...] Here is the summary with links: - [net-next,v1] ethtool: rss: fix rss key initialization warning https://git.kernel.org/netdev/net-next/c/5c2ab978f9c9 You are awesome, thank you!
diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c index 65cfe76dafbe..04b34dc6b369 100644 --- a/net/ethtool/ioctl.c +++ b/net/ethtool/ioctl.c @@ -1505,6 +1505,7 @@ static noinline_for_stack int ethtool_set_rxfh(struct net_device *dev, extack); /* Make sure driver populates defaults */ WARN_ON_ONCE(!ret && !rxfh_dev.key && + ops->rxfh_per_ctx_key && !memchr_inv(ethtool_rxfh_context_key(ctx), 0, ctx->key_size)); } else if (rxfh_dev.rss_delete) {
This warning is emitted when a driver does not default populate an rss key when one is not provided from userspace. Some devices do not support individual rss keys per context. For these devices, it is ok to leave the key zeroed out in ethtool_rxfh_context. Do not warn on zeroed key when ethtool_ops.rxfh_per_ctx_key == 0. Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com> --- net/ethtool/ioctl.c | 1 + 1 file changed, 1 insertion(+)