| Message ID | 20241003171941.8814-1-olek2@wp.pl (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8389cdb5c192bad690caf64a0746216c27f0c9b8 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: macb: Adding support for Jumbo Frames up to 10240 Bytes in SAMA5D2 | expand |
On Thu, Oct 03, 2024 at 07:19:41PM +0200, Aleksander Jan Bajkowski wrote: > As per the SAMA5D2 device specification it supports Jumbo frames. > But the suggested flag and length of bytes it supports was not updated > in this driver config_structure. > The maximum jumbo frames the device supports: > 10240 bytes as per the device spec. > > While changing the MTU value greater than 1500, it threw error: > sudo ifconfig eth1 mtu 9000 > SIOCSIFMTU: Invalid argument > > Add this support to driver so that it works as expected and designed. > > Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl> Thanks Aleksander, This appears to be consistent with: 233a15875396 ("net: macb: Adding Support for Jumbo Frames up to 10240 Bytes in SAMA5D3") Reviewed-by: Simon Horman <horms@kernel.org>
On 03/10/2024 at 19:19, Aleksander Jan Bajkowski wrote: > As per the SAMA5D2 device specification it supports Jumbo frames. > But the suggested flag and length of bytes it supports was not updated > in this driver config_structure. > The maximum jumbo frames the device supports: > 10240 bytes as per the device spec. > > While changing the MTU value greater than 1500, it threw error: > sudo ifconfig eth1 mtu 9000 > SIOCSIFMTU: Invalid argument > > Add this support to driver so that it works as expected and designed. > > Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl> Looks good indeed: Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Thanks, best regards, Nicolas > --- > drivers/net/ethernet/cadence/macb_main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c > index f06babec04a0..9fda16557509 100644 > --- a/drivers/net/ethernet/cadence/macb_main.c > +++ b/drivers/net/ethernet/cadence/macb_main.c > @@ -4841,10 +4841,11 @@ static const struct macb_config pc302gem_config = { > }; > > static const struct macb_config sama5d2_config = { > - .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII, > + .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII | MACB_CAPS_JUMBO, > .dma_burst_length = 16, > .clk_init = macb_clk_init, > .init = macb_init, > + .jumbo_max_len = 10240, > .usrio = &macb_default_usrio, > }; > > -- > 2.39.5 >
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 3 Oct 2024 19:19:41 +0200 you wrote: > As per the SAMA5D2 device specification it supports Jumbo frames. > But the suggested flag and length of bytes it supports was not updated > in this driver config_structure. > The maximum jumbo frames the device supports: > 10240 bytes as per the device spec. > > While changing the MTU value greater than 1500, it threw error: > sudo ifconfig eth1 mtu 9000 > SIOCSIFMTU: Invalid argument > > [...] Here is the summary with links: - [net-next] net: macb: Adding support for Jumbo Frames up to 10240 Bytes in SAMA5D2 https://git.kernel.org/netdev/net-next/c/8389cdb5c192 You are awesome, thank you!
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index f06babec04a0..9fda16557509 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4841,10 +4841,11 @@ static const struct macb_config pc302gem_config = { }; static const struct macb_config sama5d2_config = { - .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII, + .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII | MACB_CAPS_JUMBO, .dma_burst_length = 16, .clk_init = macb_clk_init, .init = macb_init, + .jumbo_max_len = 10240, .usrio = &macb_default_usrio, };
As per the SAMA5D2 device specification it supports Jumbo frames. But the suggested flag and length of bytes it supports was not updated in this driver config_structure. The maximum jumbo frames the device supports: 10240 bytes as per the device spec. While changing the MTU value greater than 1500, it threw error: sudo ifconfig eth1 mtu 9000 SIOCSIFMTU: Invalid argument Add this support to driver so that it works as expected and designed. Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl> --- drivers/net/ethernet/cadence/macb_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)