| Message ID | 20241004-b53_jumbo_fixes-v1-5-ce1e54aa7b3c@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: b53: assorted jumbo frame fixes | expand |
On 10/4/2024 1:47 AM, Jonas Gorski wrote: > All modern chips support and need the 10_100 bit set for supporting jumbo > frames on 10/100 ports, so instead of enabling it only for 583XX enable > it for everything except bcm63xx, where the bit is writeable, but does > nothing. > > Tested on BCM53115, where jumbo frames were dropped at 10/100 speeds > without the bit set. > > Fixes: 6ae5834b983a ("net: dsa: b53: add MTU configuration support") > Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 5b83f9b6cdac3de6c5e6e2164c78146d694674cd..c39cb119e760db5fcbfaaf44abe033f6977e7005 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -2264,7 +2264,7 @@ static int b53_change_mtu(struct dsa_switch *ds, int port, int mtu) return 0; enable_jumbo = (mtu > ETH_DATA_LEN); - allow_10_100 = (dev->chip_id == BCM583XX_DEVICE_ID); + allow_10_100 = !is63xx(dev); return b53_set_jumbo(dev, enable_jumbo, allow_10_100); }
All modern chips support and need the 10_100 bit set for supporting jumbo frames on 10/100 ports, so instead of enabling it only for 583XX enable it for everything except bcm63xx, where the bit is writeable, but does nothing. Tested on BCM53115, where jumbo frames were dropped at 10/100 speeds without the bit set. Fixes: 6ae5834b983a ("net: dsa: b53: add MTU configuration support") Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> --- drivers/net/dsa/b53/b53_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)