| Message ID | 20241004094134.113878-1-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | treewide: Switch to __pm_runtime_put_autosuspend() | expand |
On 04/10/2024 11:41, Sakari Ailus wrote: > pm_runtime_put_autosuspend() will soon be changed to include a call to > pm_runtime_mark_last_busy(). This patch switches the current users to Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > __pm_runtime_put_autosuspend() which will continue to have the > functionality of old pm_runtime_put_autosuspend(). > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > drivers/nfc/trf7970a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c > index 9e1a34e23af2..4549f1960a27 100644 > --- a/drivers/nfc/trf7970a.c > +++ b/drivers/nfc/trf7970a.c > @@ -1093,7 +1093,7 @@ static void trf7970a_switch_rf_off(struct trf7970a *trf) > trf->state = TRF7970A_ST_RF_OFF; > > pm_runtime_mark_last_busy(trf->dev); > - pm_runtime_put_autosuspend(trf->dev); > + __pm_runtime_put_autosuspend(trf->dev); But why? Nothing in commit msg explains why you cannot use the new API here. Best regards, Krzysztof
diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c index 9e1a34e23af2..4549f1960a27 100644 --- a/drivers/nfc/trf7970a.c +++ b/drivers/nfc/trf7970a.c @@ -1093,7 +1093,7 @@ static void trf7970a_switch_rf_off(struct trf7970a *trf) trf->state = TRF7970A_ST_RF_OFF; pm_runtime_mark_last_busy(trf->dev); - pm_runtime_put_autosuspend(trf->dev); + __pm_runtime_put_autosuspend(trf->dev); } static int trf7970a_switch_rf_on(struct trf7970a *trf)
pm_runtime_put_autosuspend() will soon be changed to include a call to pm_runtime_mark_last_busy(). This patch switches the current users to __pm_runtime_put_autosuspend() which will continue to have the functionality of old pm_runtime_put_autosuspend(). Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/nfc/trf7970a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)