From patchwork Fri Oct 4 16:15:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Chevallier X-Patchwork-Id: 13822703 X-Patchwork-Delegate: kuba@kernel.org Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F8321C75EF; Fri, 4 Oct 2024 16:16:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728058579; cv=none; b=D3M2GWV4Il47QtdXXE6tfu6VquvOu1Dhwrtqll2245JZm4ucPb8HNaediliETSLsQQ37+G5sZY2hKt8k6u3/SY8rThw0hD3YWA3ElUJE+VAqH5uBCn2FJej+esflmk1JZA4iNSYEhEEhORvc9b4egkLfjVTt9i7ii1MdvRlX6vo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728058579; c=relaxed/simple; bh=/t/i/v7Y4wFFXBA5yU25ZUKM1qTMIM422hMgQyatXM8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qWrlSmsEq3PPuB1L3YnPiCxZXs1A06lfmLEo19QvMaPTZjSO/WfwgXYlhHLD0PhSnTJSIvpcrcJkt7uPEcWuBVLCGOCc2V3HINdpsL0L5ezsH5qqEkGRClB06m1tU5bMF0qWTP68sB3HmIw+Www30Ndzk3IQtXDexpbNnFRWCzI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=QNpaTKOz; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="QNpaTKOz" Received: by mail.gandi.net (Postfix) with ESMTPSA id BE61520008; Fri, 4 Oct 2024 16:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1728058569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l94MYM9aLPoFsocgRBRMqaai5hzItvu6ewJPpEKL7nk=; b=QNpaTKOzl/37uWbR/6MeQsbwPIWLvqndTwQ++ICUhcct7Pw1conr08/X46fycgOrW/c1EZ hBlr1Xa3n6BrNPtFJmHfYxRiJAd+DikF4FdXXTcqPuegnspwpahzwtXXSXlf4P4p2Xpfn4 zVZmet0cMxUZUdTNi7Ui6nO5s96JM5q7WJczt8PMOvDgn7DrLbrbQvcm/MrzRh582Y1qz1 Be2czEbCDSI6fVAOBM9/AfmTtJl8K/9ApxRts9+uTctBFg62jtF5B3GMiE5+7W0SmVTWx7 B9Ws1iFtsoWLoStLhjPIfvlJzGKJ91qnSTkwYgx3XWDN0RYijr4FrdhWIkn9DA== From: Maxime Chevallier To: davem@davemloft.net Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?utf-8?q?Marek_Beh=C3=BAn?= , =?utf-8?q?K=C3=B6ry_Maince?= =?utf-8?q?nt?= , Oleksij Rempel Subject: [PATCH net-next v2 4/9] net: phy: lxt: Mark LXT973 PHYs as having a broken isolate mode Date: Fri, 4 Oct 2024 18:15:54 +0200 Message-ID: <20241004161601.2932901-5-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20241004161601.2932901-1-maxime.chevallier@bootlin.com> References: <20241004161601.2932901-1-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: maxime.chevallier@bootlin.com X-Patchwork-Delegate: kuba@kernel.org Testing showed that PHYs from the LXT973 family have a non-working isolate mode, where the MII lines aren't set in high-impedance as would be expected. Prevent isolating these PHYs. Signed-off-by: Maxime Chevallier --- V2 : Use callback instead of flag drivers/net/phy/lxt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/phy/lxt.c b/drivers/net/phy/lxt.c index e3bf827b7959..45f92451bee8 100644 --- a/drivers/net/phy/lxt.c +++ b/drivers/net/phy/lxt.c @@ -334,6 +334,7 @@ static struct phy_driver lxt97x_driver[] = { .read_status = lxt973a2_read_status, .suspend = genphy_suspend, .resume = genphy_resume, + .can_isolate = genphy_no_isolate, }, { .phy_id = 0x00137a10, .name = "LXT973", @@ -344,6 +345,7 @@ static struct phy_driver lxt97x_driver[] = { .config_aneg = lxt973_config_aneg, .suspend = genphy_suspend, .resume = genphy_resume, + .can_isolate = genphy_no_isolate, } }; module_phy_driver(lxt97x_driver);