diff mbox series

[net-next] caif: Remove unused cfsrvl_getphyid

Message ID 20241007004456.149899-1-linux@treblig.org (mailing list archive)
State Accepted
Commit 3fe3dbaf26723c473d42a58b636a2500586b821e
Delegated to: Netdev Maintainers
Headers show
Series [net-next] caif: Remove unused cfsrvl_getphyid | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 6 this patch: 6
netdev/build_tools success Errors and warnings before: 0 (+1) this patch: 0 (+1)
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 17 this patch: 17
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 19 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-10-08--00-00 (tests: 773)

Commit Message

Dr. David Alan Gilbert Oct. 7, 2024, 12:44 a.m. UTC 
From: "Dr. David Alan Gilbert" <linux@treblig.org>

cfsrvl_getphyid() has been unused since 2011's commit
f36214408470 ("caif: Use RCU and lists in cfcnfg.c for managing caif link layers")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 include/net/caif/cfsrvl.h | 1 -
 net/caif/cfsrvl.c         | 6 ------
 2 files changed, 7 deletions(-)

Comments

Simon Horman Oct. 8, 2024, 4:35 p.m. UTC | #1 
On Mon, Oct 07, 2024 at 01:44:56AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> cfsrvl_getphyid() has been unused since 2011's commit
> f36214408470 ("caif: Use RCU and lists in cfcnfg.c for managing caif link layers")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Reviewed-by: Simon Horman <horms@kernel.org>
patchwork-bot+netdevbpf@kernel.org Oct. 8, 2024, 11:20 p.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  7 Oct 2024 01:44:56 +0100 you wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> cfsrvl_getphyid() has been unused since 2011's commit
> f36214408470 ("caif: Use RCU and lists in cfcnfg.c for managing caif link layers")
> 
> Remove it.
> 
> [...]

Here is the summary with links:
  - [net-next] caif: Remove unused cfsrvl_getphyid
    https://git.kernel.org/netdev/net-next/c/3fe3dbaf2672

You are awesome, thank you!
diff mbox series

Patch

diff --git a/include/net/caif/cfsrvl.h b/include/net/caif/cfsrvl.h
index 5ee7b322e18b..a000dc45f966 100644
--- a/include/net/caif/cfsrvl.h
+++ b/include/net/caif/cfsrvl.h
@@ -40,7 +40,6 @@  void cfsrvl_init(struct cfsrvl *service,
 			struct dev_info *dev_info,
 			bool supports_flowctrl);
 bool cfsrvl_ready(struct cfsrvl *service, int *err);
-u8 cfsrvl_getphyid(struct cflayer *layer);
 
 static inline void cfsrvl_get(struct cflayer *layr)
 {
diff --git a/net/caif/cfsrvl.c b/net/caif/cfsrvl.c
index 9cef9496a707..171fa32ada85 100644
--- a/net/caif/cfsrvl.c
+++ b/net/caif/cfsrvl.c
@@ -183,12 +183,6 @@  bool cfsrvl_ready(struct cfsrvl *service, int *err)
 	return true;
 }
 
-u8 cfsrvl_getphyid(struct cflayer *layer)
-{
-	struct cfsrvl *servl = container_obj(layer);
-	return servl->dev_info.id;
-}
-
 bool cfsrvl_phyid_match(struct cflayer *layer, int phyid)
 {
 	struct cfsrvl *servl = container_obj(layer);