| Message ID | 20241007032435.787892-1-jacky_chou@aspeedtech.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 70a0da8c113555fe14bb6db8e5180f8fc2c18385 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: ftgmac100: fixed not check status from fixed phy | expand |
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 7 Oct 2024 11:24:35 +0800 you wrote: > Add error handling from calling fixed_phy_register. > It may return some error, therefore, need to check the status. > > And fixed_phy_register needs to bind a device node for mdio. > Add the mac device node for fixed_phy_register function. > This is a reference to this function, of_phy_register_fixed_link(). > > [...] Here is the summary with links: - [net] net: ftgmac100: fixed not check status from fixed phy https://git.kernel.org/netdev/net/c/70a0da8c1135 You are awesome, thank you!
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c index f3cc14cc757d..0b61f548fd18 100644 --- a/drivers/net/ethernet/faraday/ftgmac100.c +++ b/drivers/net/ethernet/faraday/ftgmac100.c @@ -1906,7 +1906,12 @@ static int ftgmac100_probe(struct platform_device *pdev) goto err_phy_connect; } - phydev = fixed_phy_register(PHY_POLL, &ncsi_phy_status, NULL); + phydev = fixed_phy_register(PHY_POLL, &ncsi_phy_status, np); + if (IS_ERR(phydev)) { + dev_err(&pdev->dev, "failed to register fixed PHY device\n"); + err = PTR_ERR(phydev); + goto err_phy_connect; + } err = phy_connect_direct(netdev, phydev, ftgmac100_adjust_link, PHY_INTERFACE_MODE_MII); if (err) {
Add error handling from calling fixed_phy_register. It may return some error, therefore, need to check the status. And fixed_phy_register needs to bind a device node for mdio. Add the mac device node for fixed_phy_register function. This is a reference to this function, of_phy_register_fixed_link(). Fixes: e24a6c874601 ("net: ftgmac100: Get link speed and duplex for NC-SI") Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com> --- drivers/net/ethernet/faraday/ftgmac100.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)