| Message ID | 20241007104317.3064428-1-daniel@0x0f.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 82c5b53140faf89c31ea2b3a0985a2f291694169 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: amd: mvme147: Fix probe banner message | expand |
On Mon, Oct 07, 2024 at 07:43:17PM +0900, Daniel Palmer wrote: > Currently this driver prints this line with what looks like > a rogue format specifier when the device is probed: > [ 2.840000] eth%d: MVME147 at 0xfffe1800, irq 12, Hardware Address xx:xx:xx:xx:xx:xx > > Change the printk() for netdev_info() and move it after the > registration has completed so it prints out the name of the > interface properly. > > Signed-off-by: Daniel Palmer <daniel@0x0f.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Mon, 7 Oct 2024 19:43:17 +0900 you wrote: > Currently this driver prints this line with what looks like > a rogue format specifier when the device is probed: > [ 2.840000] eth%d: MVME147 at 0xfffe1800, irq 12, Hardware Address xx:xx:xx:xx:xx:xx > > Change the printk() for netdev_info() and move it after the > registration has completed so it prints out the name of the > interface properly. > > [...] Here is the summary with links: - net: amd: mvme147: Fix probe banner message https://git.kernel.org/netdev/net/c/82c5b53140fa You are awesome, thank you!
diff --git a/drivers/net/ethernet/amd/mvme147.c b/drivers/net/ethernet/amd/mvme147.c index c156566c0906..f19b04b92fa9 100644 --- a/drivers/net/ethernet/amd/mvme147.c +++ b/drivers/net/ethernet/amd/mvme147.c @@ -105,10 +105,6 @@ static struct net_device * __init mvme147lance_probe(void) macaddr[3] = address&0xff; eth_hw_addr_set(dev, macaddr); - printk("%s: MVME147 at 0x%08lx, irq %d, Hardware Address %pM\n", - dev->name, dev->base_addr, MVME147_LANCE_IRQ, - dev->dev_addr); - lp = netdev_priv(dev); lp->ram = __get_dma_pages(GFP_ATOMIC, 3); /* 32K */ if (!lp->ram) { @@ -138,6 +134,9 @@ static struct net_device * __init mvme147lance_probe(void) return ERR_PTR(err); } + netdev_info(dev, "MVME147 at 0x%08lx, irq %d, Hardware Address %pM\n", + dev->base_addr, MVME147_LANCE_IRQ, dev->dev_addr); + return dev; }
Currently this driver prints this line with what looks like a rogue format specifier when the device is probed: [ 2.840000] eth%d: MVME147 at 0xfffe1800, irq 12, Hardware Address xx:xx:xx:xx:xx:xx Change the printk() for netdev_info() and move it after the registration has completed so it prints out the name of the interface properly. Signed-off-by: Daniel Palmer <daniel@0x0f.com> --- drivers/net/ethernet/amd/mvme147.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)