| Message ID | 20241009214847.67188-6-rosenp@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | devicetree: move nvmem-cells users to nvmem-layout | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 09/10/2024 23:48, Rosen Penev wrote: > nvmem-cells are deprecated and replaced with nvmem-layout. For these > examples, replace. They're not relevant to the main point of the > document anyway. > > Signed-off-by: Rosen Penev <rosenp@gmail.com> > --- Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters You already got this comment, is something unclear? > .../mtd/partitions/qcom,smem-part.yaml | 21 +++++++++++-------- > .../bindings/net/marvell,aquantia.yaml | 13 +++++++----- > 2 files changed, 20 insertions(+), 14 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml > index 1c2b4e780ca9..c2cc11286d80 100644 > --- a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml > +++ b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml > @@ -23,7 +23,7 @@ properties: > > patternProperties: > "^partition-[0-9a-z]+$": > - $ref: nvmem-cells.yaml > + $ref: nvmem-layout.yaml There is no such file here, so this should be full path /schemas/nvmem/.... but is this a nvmem? Looks like MTD and NAND. Previously this was a partition, now it is not. I don't understand what you are trying to achieve here. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml index 1c2b4e780ca9..c2cc11286d80 100644 --- a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml +++ b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml @@ -23,7 +23,7 @@ properties: patternProperties: "^partition-[0-9a-z]+$": - $ref: nvmem-cells.yaml + $ref: nvmem-layout.yaml required: - compatible @@ -45,17 +45,20 @@ examples: compatible = "qcom,smem-part"; partition-art { - compatible = "nvmem-cells"; - #address-cells = <1>; - #size-cells = <1>; label = "0:art"; - macaddr_art_0: macaddr@0 { - reg = <0x0 0x6>; - }; + nvmem-layout { + compatible = "fixed-layout"; + #address-cells = <1>; + #size-cells = <1>; + + macaddr_art_0: macaddr@0 { + reg = <0x0 0x6>; + }; - macaddr_art_6: macaddr@6 { - reg = <0x6 0x6>; + macaddr_art_6: macaddr@6 { + reg = <0x6 0x6>; + }; }; }; }; diff --git a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml index 9854fab4c4db..5d118553228b 100644 --- a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml +++ b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml @@ -98,15 +98,18 @@ examples: /* ... */ partition@650000 { - compatible = "nvmem-cells"; label = "0:ethphyfw"; reg = <0x650000 0x80000>; read-only; - #address-cells = <1>; - #size-cells = <1>; - aqr_fw: aqr_fw@0 { - reg = <0x0 0x5f42a>; + nvmem-layout { + compatible = "fixed-layout"; + #address-cells = <1>; + #size-cells = <1>; + + aqr_fw: aqr_fw@0 { + reg = <0x0 0x5f42a>; + }; }; };
nvmem-cells are deprecated and replaced with nvmem-layout. For these examples, replace. They're not relevant to the main point of the document anyway. Signed-off-by: Rosen Penev <rosenp@gmail.com> --- .../mtd/partitions/qcom,smem-part.yaml | 21 +++++++++++-------- .../bindings/net/marvell,aquantia.yaml | 13 +++++++----- 2 files changed, 20 insertions(+), 14 deletions(-)