From patchwork Mon Oct 14 14:47:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Hai X-Patchwork-Id: 13835163 X-Patchwork-Delegate: kuba@kernel.org Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84C92481B3; Mon, 14 Oct 2024 14:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728917299; cv=none; b=gHEVqhxxIXeE/jtJl5ajyWlI1KrdHA+Q9RaxGy/AD/C1v4eYQ79Sr9KIIMEJsg1a/OqAvxsnYb9PAYwLkvbyEwi/ZIg+PI8NYqU/mWzcsfsTv+Pxgej8yoE6gJGARbECVjLsNwWzfmJgmQcOcXlj6AjILjf/bKtpVW6hYf+BbI8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728917299; c=relaxed/simple; bh=9yYuJeielXEdoy9GKca9itYPLQsRpr9pPHpAg5r6IBo=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=stiktP16SMDKvi1LKshaKYK6/82vjetUE5kOTRHWBOKkw3eJmLbkt8TUk69ih4vQMOdtnT/CdzJOOBs9QZICG3wDI/Yg7AZaKNeHa3/k1gKWw3t5jmRhFp/6DCKiI8SHkC02m0Jt3tHyvDWD0aJwMrgThyqaxNpuP+Sge0gfRW4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4XS0Qh21dzzkWpD; Mon, 14 Oct 2024 22:45:48 +0800 (CST) Received: from kwepemm600001.china.huawei.com (unknown [7.193.23.3]) by mail.maildlp.com (Postfix) with ESMTPS id 727381800A7; Mon, 14 Oct 2024 22:48:14 +0800 (CST) Received: from huawei.com (10.175.113.133) by kwepemm600001.china.huawei.com (7.193.23.3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 14 Oct 2024 22:48:13 +0800 From: Wang Hai To: , , , , , , , , CC: , , Subject: [PATCH net] be2net: fix potential memory leak in be_xmit() Date: Mon, 14 Oct 2024 22:47:58 +0800 Message-ID: <20241014144758.42010-1-wanghai38@huawei.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600001.china.huawei.com (7.193.23.3) X-Patchwork-Delegate: kuba@kernel.org The be_xmit() returns NETDEV_TX_OK without freeing skb in case of be_xmit_enqueue() fails, add dev_kfree_skb_any() to fix it. Fixes: 760c295e0e8d ("be2net: Support for OS2BMC.") Signed-off-by: Wang Hai --- drivers/net/ethernet/emulex/benet/be_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index a8596ebcdfd6..80bbbbe75bc4 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -1392,10 +1392,12 @@ static netdev_tx_t be_xmit(struct sk_buff *skb, struct net_device *netdev) if (be_send_pkt_to_bmc(adapter, &skb)) { BE_WRB_F_SET(wrb_params.features, OS2BMC, 1); wrb_cnt = be_xmit_enqueue(adapter, txo, skb, &wrb_params); - if (unlikely(!wrb_cnt)) + if (unlikely(!wrb_cnt)) { + dev_kfree_skb_any(skb); goto drop; - else + } else { skb_get(skb); + } } if (be_is_txq_full(txo)) {