| Message ID | 20241015065708.3465151-2-leyfoon.tan@starfivetech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: stmmac: dwmac4: Fixes and improvements | expand |
On Tue, 15 Oct 2024 14:57:05 +0800 Ley Foon Tan wrote: > RTC fields are located in bits [1:0]. Correct the _MASK and _SHIFT > macros to use the appropriate mask and shift. > > Fixes: 35f74c0c5dce ("stmmac: add GMAC4 DMA/CORE Header File") > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> no empty line between Fixes and Signed-off-by lines, please. Please fix and resend with [PATCH net] in the title. All fixes which are needed in current Linus's tree need to go to net, rather than net-next, see: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#git-trees-and-patch-flow
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4.h index 93a78fd0737b..acbe5a027c85 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4.h +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4.h @@ -389,8 +389,8 @@ static inline u32 mtl_chanx_base_addr(const struct dwmac4_addrs *addrs, #define MTL_OP_MODE_EHFC BIT(7) -#define MTL_OP_MODE_RTC_MASK 0x18 -#define MTL_OP_MODE_RTC_SHIFT 3 +#define MTL_OP_MODE_RTC_MASK GENMASK(1, 0) +#define MTL_OP_MODE_RTC_SHIFT 0 #define MTL_OP_MODE_RTC_32 (1 << MTL_OP_MODE_RTC_SHIFT) #define MTL_OP_MODE_RTC_64 0
RTC fields are located in bits [1:0]. Correct the _MASK and _SHIFT macros to use the appropriate mask and shift. Fixes: 35f74c0c5dce ("stmmac: add GMAC4 DMA/CORE Header File") Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)