From patchwork Tue Oct 15 10:29:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Chia-Yu Chang (Nokia)" X-Patchwork-Id: 13836086 X-Patchwork-Delegate: kuba@kernel.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2059.outbound.protection.outlook.com [40.107.20.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DD161EF09D for ; Tue, 15 Oct 2024 10:30:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728988233; cv=fail; b=M6dIMzUio0KdQFcSWctdA03AGtw5t6Fzkp7GKE4p8b+YV+CDi8/HrFcu+oRrtexGaCRGXfSdHhw4F1A1JJlUVPy5IDt5Yu1M+qRQKe3nXckdA6KQkaKQPXWe+GRx0K9Jc9o4E8ho3Wm5XQ456ByL1CAYszmkshTbWEfE61YDXpU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728988233; c=relaxed/simple; bh=6W2eeaETfKUS7q+IQoIsmfag1icCOuuYUqd3t0j6JIY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=gx3WlKakguDZnaQbzvCCZJ+zIiCjrWzB8xccmFMsTe5uDOvLSzSEBaueOaErYIM/v6frSpsE/rQAdnsVTbvOOrkA6UDAU6i0SnhDSHJQY1mKmAhn9/o6OH1SkNZwrAsWu9ZcM48JBmGpKipjj6eoOL5QufmzLMV7KWjd44yUB5E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nokia-bell-labs.com; spf=fail smtp.mailfrom=nokia-bell-labs.com; dkim=pass (2048-bit key) header.d=nokia-bell-labs.com header.i=@nokia-bell-labs.com header.b=Nhr23cus; arc=fail smtp.client-ip=40.107.20.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nokia-bell-labs.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nokia-bell-labs.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nokia-bell-labs.com header.i=@nokia-bell-labs.com header.b="Nhr23cus" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KXNqV/IS25SmUKaE6TQpisQZYjvFEVxYWSp7ydRDNtnYyHPiEqXf8lex1ayxHbS8vihKSR51vW8ECU0gK2+1i/IlIC9PtM/t+Z54c4zOTdM15ORrbIRWIpDapEMpaplx0YySV1RhxoheZBYP2u7AOe8uL1cDbHRhHvy9RWX5p/Tc4ytYUAr5084AobczpFdj/kTr9Lg+rjUmWM4BxlNRdgTLnx8qNHtQpbnUfQwPMQSnG9l08iqv4mnA6bhNNOKLY5qXE9QDDBc0lLVV4PL44uqBOVNzVFlK4PEQyoFeMu+j3cZWgHHx/rXh09KaEFt4AyZGFE/pba8AsNGBgpoiqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dGUSvRQ5nvfxBGuWXThf9+eGeUp3Rb42NawIGNmq/ls=; b=LsP7Vl5FTjabvlEuV5rmBGP2vYbIQyUzmiDgFRuW6KAJuooyZVTsqMi9p+wiRyJOhvrxxjGi5jdkd7ldmT6FD2i/nb15P5GNpvZe6CW8nKRQF5gS1UhzKrko0Aec+KK7WBiAgTJarJioVjyv8jRzgXlZZxeFhwuYqPdaaNg1ESPFjDwLnZf3Yp6JHJYKVTFqSM31vyAzYB8JjRYOMD3rMHrm8+doolMT3OVjMbxrOR2o8AiK+hcIzIS1/yWW3HDoCqVEJYR4Rq+Wd7IcpQdjQT/l/WK/UjfJn+jFe/s1+25dqinX9bqiNGo7KRfYk6aoNxcv4CRwOQz7cWps64WYqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 131.228.6.101) smtp.rcpttodomain=nokia-bell-labs.com smtp.mailfrom=nokia-bell-labs.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nokia-bell-labs.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia-bell-labs.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dGUSvRQ5nvfxBGuWXThf9+eGeUp3Rb42NawIGNmq/ls=; b=Nhr23cusfl2oNN+7QTFQfmk57zIG8gdXScIO60xz9vcW01ukt72w3cUV32xcv4wJpCehotSS89I412LqXjoi7klJAxVPDjgvdSWat7N3T49Mrgu0XvnyEWqSRGmBOlba8Z+CKf4MIjJhNvMWUfMme2CbrSvPoN+ZqfJ4nn31V2+VqcSvqzPIJmT8ipKixKpHCbRAhoPiOqmx23Hd60ZYzQV/ZPPNdHdsI1hdGUkIr/fB/grjcyxrgxcgT7jx0L8jHxDWmeX/oIJN8KoV8xSIdKccIG5zpUexJXtByuIDDKVgj9V7IXwGI17KqRu2T+7z4lThiHLNh4vGyiQehhQEuQ== Received: from DUZP191CA0048.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f8::8) by DBAPR07MB6710.eurprd07.prod.outlook.com (2603:10a6:10:18a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.26; Tue, 15 Oct 2024 10:30:29 +0000 Received: from DU2PEPF00028D13.eurprd03.prod.outlook.com (2603:10a6:10:4f8:cafe::89) by DUZP191CA0048.outlook.office365.com (2603:10a6:10:4f8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.17 via Frontend Transport; Tue, 15 Oct 2024 10:30:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 131.228.6.101) smtp.mailfrom=nokia-bell-labs.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nokia-bell-labs.com; Received-SPF: Pass (protection.outlook.com: domain of nokia-bell-labs.com designates 131.228.6.101 as permitted sender) receiver=protection.outlook.com; client-ip=131.228.6.101; helo=fr712usmtp1.zeu.alcatel-lucent.com; pr=C Received: from fr712usmtp1.zeu.alcatel-lucent.com (131.228.6.101) by DU2PEPF00028D13.mail.protection.outlook.com (10.167.242.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.17 via Frontend Transport; Tue, 15 Oct 2024 10:30:29 +0000 Received: from sarah.nbl.nsn-rdnet.net (sarah.nbl.nsn-rdnet.net [10.0.73.150]) by fr712usmtp1.zeu.alcatel-lucent.com (GMO) with ESMTP id 49FATtnX029578; Tue, 15 Oct 2024 10:30:28 GMT From: chia-yu.chang@nokia-bell-labs.com To: netdev@vger.kernel.org, ij@kernel.org, ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com, g.white@CableLabs.com, ingemar.s.johansson@ericsson.com, mirja.kuehlewind@ericsson.com, cheshire@apple.com, rs.ietf@gmx.at, Jason_Livingood@comcast.com, vidhi_goel@apple.com Cc: Chia-Yu Chang Subject: [PATCH net-next 29/44] gro: flushing when CWR is set negatively affects AccECN Date: Tue, 15 Oct 2024 12:29:25 +0200 Message-Id: <20241015102940.26157-30-chia-yu.chang@nokia-bell-labs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241015102940.26157-1-chia-yu.chang@nokia-bell-labs.com> References: <20241015102940.26157-1-chia-yu.chang@nokia-bell-labs.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PEPF00028D13:EE_|DBAPR07MB6710:EE_ X-MS-Office365-Filtering-Correlation-Id: e09aa0fc-3bf9-499a-07d6-08dced046433 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|7416014|376014|82310400026|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?urAT3n2rxL3tCJRQEm6R+J51mRpgxBL?= =?utf-8?q?QSZmDr154fIcq7mlWtgVa0rpTGhboq1CSl33Q+Co0p5H+R9tfh9pmZK6zT4liE/7Y?= =?utf-8?q?2iXRuclTCwTPar0NT5rxs86sIMknHtfOsrKyEIPltAqsZoULqza3TY7JnUQVcdok0?= =?utf-8?q?D7QumS94Ls+av0BWY1ZWwwPc9xgUBGpoMqusfJmuY8L2lP83xe00qH4l/3x71R/LX?= =?utf-8?q?v5h7J8eyrlajShPoeCt5H6pVUjfydcsgwvfOYidilwRKElHCvfxMlrUKGa3d2zzEg?= =?utf-8?q?3Az6iVIXwhiMBOatFbZKd8wJxpBIE8fwj/GCvdYxS9pkMWFuKetSPmzwwkeQnwrrn?= =?utf-8?q?xO8rPXKokcCU9UcpeBJFhblTB37BxaV6vq5Esz9wm5VocedcC5Z3pLGjdpPiKthlG?= =?utf-8?q?DPeHR1TUB1BNIFX7QN0oTohvfCIaSwDfVcWBE32PwgCrFUKRJa0hEVHSPGcyop7jl?= =?utf-8?q?/KrWmuNdWuv3N5IpGfQEiqv4Eqkuh+Nlssc0F2hUL8ZDlKkCoT2k/ipBaY4u9Hskz?= =?utf-8?q?Mph9Ogp3ohUQdVZeNvqon6txaNYm2cOjGiU+C/HtQ/JmF6xEMnUDVMzhCD9drzxYC?= =?utf-8?q?1/facOkt2pbQymVLewijR28VzCsdKF6ljnn6c0gHYqPvpVsY6kYJ5rOweqftwa5Rw?= =?utf-8?q?LJmm0rRZsTKiXAE9ZHDD/Z0mNxQ/eIsUf/SedCy9jbp5iVJeIOxFLLLX1fFx1UyaW?= =?utf-8?q?gG7m8UFujjwyQh0nhHNGBkMxSJh0d/VNwOf8Rcjy+sFm5Y94w9PH2K2mj4lCKrlNu?= =?utf-8?q?7dNgtw+9MY2VDyDSgzlTKFq8MQHsi6ZTgvIlzWmJemM45BfIPHt1nkwwjWFz/Ii3l?= =?utf-8?q?m+gQjxlMjWg2p+KrDz6lXPUkb5wMpf7tjbKEVam4xE5pEYNaI05juAM7EH0RVkhSw?= =?utf-8?q?Ti6wbaKTtRtsPvHx46561s9UoQmRSWL+oyLvRN1H3SuGM3qSjI/KvmiSQCvj0BbgF?= =?utf-8?q?XMudSR+7B9nFtAfYuLGD28EAjyvBdVivGyFFJfI+tnZsy81goWY2cgIy4CnONsykv?= =?utf-8?q?+CX7lnmpBN7zQmtWPmSLUufyd3KezHFkr4G2CeGRcfQGaZVoHBO5+esscTfnB2ZSj?= =?utf-8?q?RXN+9kpG3Bzj/cjigIkJFj25/svrCnevJfXhenm+95yus+lgexxxyPj+WYEg/H/sS?= =?utf-8?q?LqwmWYgtMQ8uwx3N0alhAeMfbxzuKkUN0E2aYCkzuxzyK8ROtUWdD4xXl3zyEKv3F?= =?utf-8?q?Nj9lM2FtLF8VyOq9mxcY/LXAQVaJQ3IsJbrLXhud0386I0vu4zw2ejIMhqmenvHhz?= =?utf-8?q?Qhs1K7SiGh1A4RZSu59qXsdVRXKwQs6d0qRUy6U6qFESlOhurTCt1Ybzbf2dyPjJ2?= =?utf-8?q?FSpPan5ZR2tM?= X-Forefront-Antispam-Report: CIP:131.228.6.101;CTRY:FI;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:fr712usmtp1.zeu.alcatel-lucent.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(7416014)(376014)(82310400026)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: nokia-bell-labs.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2024 10:30:29.4923 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e09aa0fc-3bf9-499a-07d6-08dced046433 X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5d471751-9675-428d-917b-70f44f9630b0;Ip=[131.228.6.101];Helo=[fr712usmtp1.zeu.alcatel-lucent.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D13.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR07MB6710 X-Patchwork-Delegate: kuba@kernel.org From: Ilpo Järvinen As AccECN may keep CWR bit asserted due to different interpretation of the bit, flushing with GRO because of CWR may effectively disable GRO until AccECN counter field changes such that CWR-bit becomes 0. There is no harm done from not immediately forwarding the CWR'ed segment with RFC3168 ECN. Signed-off-by: Ilpo Järvinen Signed-off-by: Chia-Yu Chang --- net/ipv4/tcp_offload.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv4/tcp_offload.c b/net/ipv4/tcp_offload.c index f59762d88c38..6286488abeca 100644 --- a/net/ipv4/tcp_offload.c +++ b/net/ipv4/tcp_offload.c @@ -327,8 +327,7 @@ struct sk_buff *tcp_gro_receive(struct list_head *head, struct sk_buff *skb, goto out_check_final; th2 = tcp_hdr(p); - flush = (__force int)(flags & TCP_FLAG_CWR); - flush |= (__force int)((flags ^ tcp_flag_word(th2)) & + flush = (__force int)((flags ^ tcp_flag_word(th2)) & ~(TCP_FLAG_FIN | TCP_FLAG_PSH)); flush |= (__force int)(th->ack_seq ^ th2->ack_seq); for (i = sizeof(*th); i < thlen; i += 4)