diff mbox series

octeontx2-af: Use str_enabled_disabled()

Message ID 20241015121300.1601108-1-roheetchavan@gmail.com (mailing list archive)
State Rejected
Delegated to: Netdev Maintainers
Headers show
Series octeontx2-af: Use str_enabled_disabled() | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5 this patch: 5
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 10 of 10 maintainers
netdev/build_clang success Errors and warnings before: 3 this patch: 3
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 4 this patch: 4
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Rohit Chavan Oct. 15, 2024, 12:13 p.m. UTC 
Use str_enabled_disabled() helper instead of open coding the same.

Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski Oct. 16, 2024, 1:36 a.m. UTC | #1 
On Tue, 15 Oct 2024 17:43:00 +0530 Rohit Chavan wrote:
>  Use str_enabled_disabled() helper instead of open coding the same.

I think this falls under clean ups, please see:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
diff mbox series

Patch

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c
index 7498ab429963..5d09cb56e67a 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c
@@ -1251,7 +1251,7 @@  static int rvu_af_npc_exact_feature_get(struct devlink *devlink, u32 id,
 	enabled = rvu_npc_exact_has_match_table(rvu);
 
 	snprintf(ctx->val.vstr, sizeof(ctx->val.vstr), "%s",
-		 enabled ? "enabled" : "disabled");
+		 str_enabled_disabled(enabled));
 
 	return 0;
 }