| Message ID | 20241016-fec-cleanups-v1-2-de783bd15e6a@pengutronix.de (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: fec: cleanups, update quirk, update IRQ naming | expand |
> -----Original Message----- > From: Marc Kleine-Budde <mkl@pengutronix.de> > Sent: 2024年10月17日 5:52 > To: Wei Fang <wei.fang@nxp.com>; Shenwei Wang <shenwei.wang@nxp.com>; > Clark Wang <xiaoning.wang@nxp.com>; David S. Miller > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub > Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Richard > Cochran <richardcochran@gmail.com> > Cc: imx@lists.linux.dev; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; > kernel@pengutronix.de; Marc Kleine-Budde <mkl@pengutronix.de> > Subject: [PATCH net-next 02/13] net: fec: struct fec_enet_private: remove > obsolete comment > > In commit 4d494cdc92b3 ("net: fec: change data structure to support > multiqueue") the data structures were changed, so that the comment > about the sent-in-place skb doesn't apply any more. Remove it. > > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > --- > drivers/net/ethernet/freescale/fec.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/fec.h > b/drivers/net/ethernet/freescale/fec.h > index > 77c2a08d23542accdb85b37a6f86847d9eb56a7a..e55c7ccad2ec39a9f349213 > 5675d480a22f7032d 100644 > --- a/drivers/net/ethernet/freescale/fec.h > +++ b/drivers/net/ethernet/freescale/fec.h > @@ -614,7 +614,6 @@ struct fec_enet_private { > unsigned int num_tx_queues; > unsigned int num_rx_queues; > > - /* The saved address of a sent-in-place packet/buffer, for skfree(). */ > struct fec_enet_priv_tx_q *tx_queue[FEC_ENET_MAX_TX_QS]; > struct fec_enet_priv_rx_q *rx_queue[FEC_ENET_MAX_RX_QS]; > > > -- > 2.45.2 > Thanks. Reviewed-by: Wei Fang <wei.fang@nxp.com>
On Wed, Oct 16, 2024 at 11:51:50PM +0200, Marc Kleine-Budde wrote: > In commit 4d494cdc92b3 ("net: fec: change data structure to support > multiqueue") the data structures were changed, so that the comment > about the sent-in-place skb doesn't apply any more. Remove it. nit: wrap at 75 char Reviewed-by: Frank Li <Frank.Li@nxp.com> > > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > --- > drivers/net/ethernet/freescale/fec.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h > index 77c2a08d23542accdb85b37a6f86847d9eb56a7a..e55c7ccad2ec39a9f3492135675d480a22f7032d 100644 > --- a/drivers/net/ethernet/freescale/fec.h > +++ b/drivers/net/ethernet/freescale/fec.h > @@ -614,7 +614,6 @@ struct fec_enet_private { > unsigned int num_tx_queues; > unsigned int num_rx_queues; > > - /* The saved address of a sent-in-place packet/buffer, for skfree(). */ > struct fec_enet_priv_tx_q *tx_queue[FEC_ENET_MAX_TX_QS]; > struct fec_enet_priv_rx_q *rx_queue[FEC_ENET_MAX_RX_QS]; > > > -- > 2.45.2 > >
On 16.10.2024 21:55:09, Frank Li wrote: > On Wed, Oct 16, 2024 at 11:51:50PM +0200, Marc Kleine-Budde wrote: > > In commit 4d494cdc92b3 ("net: fec: change data structure to support > > multiqueue") the data structures were changed, so that the comment > > about the sent-in-place skb doesn't apply any more. Remove it. > > nit: wrap at 75 char fixed - my editor is set to auto-wrap at 70. Marc
diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h index 77c2a08d23542accdb85b37a6f86847d9eb56a7a..e55c7ccad2ec39a9f3492135675d480a22f7032d 100644 --- a/drivers/net/ethernet/freescale/fec.h +++ b/drivers/net/ethernet/freescale/fec.h @@ -614,7 +614,6 @@ struct fec_enet_private { unsigned int num_tx_queues; unsigned int num_rx_queues; - /* The saved address of a sent-in-place packet/buffer, for skfree(). */ struct fec_enet_priv_tx_q *tx_queue[FEC_ENET_MAX_TX_QS]; struct fec_enet_priv_rx_q *rx_queue[FEC_ENET_MAX_RX_QS];
In commit 4d494cdc92b3 ("net: fec: change data structure to support multiqueue") the data structures were changed, so that the comment about the sent-in-place skb doesn't apply any more. Remove it. Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> --- drivers/net/ethernet/freescale/fec.h | 1 - 1 file changed, 1 deletion(-)