| Message ID | 20241016-fec-cleanups-v1-3-de783bd15e6a@pengutronix.de (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: fec: cleanups, update quirk, update IRQ naming | expand |
> -----Original Message----- > From: Marc Kleine-Budde <mkl@pengutronix.de> > Sent: 2024年10月17日 5:52 > To: Wei Fang <wei.fang@nxp.com>; Shenwei Wang <shenwei.wang@nxp.com>; > Clark Wang <xiaoning.wang@nxp.com>; David S. Miller > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub > Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Richard > Cochran <richardcochran@gmail.com> > Cc: imx@lists.linux.dev; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; > kernel@pengutronix.de; Marc Kleine-Budde <mkl@pengutronix.de> > Subject: [PATCH net-next 03/13] net: fec: add missing header files > > The fec.h isn't self contained. Add missing header files, so that it > can be parsed by language servers without errors. > > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > --- > drivers/net/ethernet/freescale/fec.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/freescale/fec.h > b/drivers/net/ethernet/freescale/fec.h > index > e55c7ccad2ec39a9f3492135675d480a22f7032d..63744a86752540fcede7fc4c > 29865b2529492526 100644 > --- a/drivers/net/ethernet/freescale/fec.h > +++ b/drivers/net/ethernet/freescale/fec.h > @@ -15,7 +15,9 @@ > > /****************************************************************** > **********/ > > #include <linux/clocksource.h> > +#include <linux/ethtool.h> > #include <linux/net_tstamp.h> > +#include <linux/phy.h> > #include <linux/pm_qos.h> > #include <linux/bpf.h> > #include <linux/ptp_clock_kernel.h> > > -- > 2.45.2 > Thanks. Reviewed-by: Wei Fang <wei.fang@nxp.com>
On Wed, Oct 16, 2024 at 11:51:51PM +0200, Marc Kleine-Budde wrote: > The fec.h isn't self contained. Add missing header files, so that it > can be parsed by language servers without errors. nit: wrap at 75 char Reviewed-by: Frank Li <Frank.Li@nxp.com> > > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > --- > drivers/net/ethernet/freescale/fec.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h > index e55c7ccad2ec39a9f3492135675d480a22f7032d..63744a86752540fcede7fc4c29865b2529492526 100644 > --- a/drivers/net/ethernet/freescale/fec.h > +++ b/drivers/net/ethernet/freescale/fec.h > @@ -15,7 +15,9 @@ > /****************************************************************************/ > > #include <linux/clocksource.h> > +#include <linux/ethtool.h> > #include <linux/net_tstamp.h> > +#include <linux/phy.h> > #include <linux/pm_qos.h> > #include <linux/bpf.h> > #include <linux/ptp_clock_kernel.h> > > -- > 2.45.2 > >
On 16.10.2024 21:56:13, Frank Li wrote: > On Wed, Oct 16, 2024 at 11:51:51PM +0200, Marc Kleine-Budde wrote: > > The fec.h isn't self contained. Add missing header files, so that it > > can be parsed by language servers without errors. > > nit: wrap at 75 char Fixed, Marc
diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h index e55c7ccad2ec39a9f3492135675d480a22f7032d..63744a86752540fcede7fc4c29865b2529492526 100644 --- a/drivers/net/ethernet/freescale/fec.h +++ b/drivers/net/ethernet/freescale/fec.h @@ -15,7 +15,9 @@ /****************************************************************************/ #include <linux/clocksource.h> +#include <linux/ethtool.h> #include <linux/net_tstamp.h> +#include <linux/phy.h> #include <linux/pm_qos.h> #include <linux/bpf.h> #include <linux/ptp_clock_kernel.h>
The fec.h isn't self contained. Add missing header files, so that it can be parsed by language servers without errors. Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> --- drivers/net/ethernet/freescale/fec.h | 2 ++ 1 file changed, 2 insertions(+)