diff mbox series

[net] mctp i2c: handle NULL header address

Message ID 20241018-mctp-i2c-null-dest-v1-1-ba1ab52966e9@codeconstruct.com.au (mailing list archive)
State New
Delegated to: Netdev Maintainers
Headers show
Series [net] mctp i2c: handle NULL header address | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net
netdev/apply fail Patch does not apply to net-0

Commit Message

Matt Johnston via B4 Relay Oct. 18, 2024, 3:07 a.m. UTC 
From: Matt Johnston <matt@codeconstruct.com.au>

daddr can be NULL if there is no neighbour table entry present,
in that case the tx packet should be dropped.

Fixes: f5b8abf9fc3d ("mctp i2c: MCTP I2C binding driver")
Cc: stable@vger.kernel.org
Reported-by: Dung Cao <dung@os.amperecomputing.com>
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
---
 drivers/net/mctp/mctp-i2c.c | 3 +++
 1 file changed, 3 insertions(+)


---
base-commit: cb560795c8c2ceca1d36a95f0d1b2eafc4074e37
change-id: 20241018-mctp-i2c-null-dest-a0ba271e0c48

Best regards,
diff mbox series

Patch

diff --git drivers/net/mctp/mctp-i2c.c drivers/net/mctp/mctp-i2c.c
index 4dc057c121f5..e70fb6687994 100644
--- drivers/net/mctp/mctp-i2c.c
+++ drivers/net/mctp/mctp-i2c.c
@@ -588,6 +588,9 @@  static int mctp_i2c_header_create(struct sk_buff *skb, struct net_device *dev,
 	if (len > MCTP_I2C_MAXMTU)
 		return -EMSGSIZE;
 
+	if (!daddr || !saddr)
+		return -EINVAL;
+
 	lldst = *((u8 *)daddr);
 	llsrc = *((u8 *)saddr);