| Message ID | 20241022063453.103751-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next] octeon_ep: Remove unneeded semicolon | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
On Tue, Oct 22, 2024 at 02:34:53PM +0800, Yang Li wrote: > This patch removes an unneeded semicolon after a while statement. > > ./drivers/net/ethernet/marvell/octeon_ep/octep_rx.c:381:2-3: Unneeded semicolon > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11430 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Hi Yang Li, While I agree that this change is correct, and improves the code. Netdev discourages clean-ups along these lines that are not in the context of other work [1]. [1] https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches
diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_rx.c b/drivers/net/ethernet/marvell/octeon_ep/octep_rx.c index 8af75cb37c3e..d65d9572ffa6 100644 --- a/drivers/net/ethernet/marvell/octeon_ep/octep_rx.c +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_rx.c @@ -378,7 +378,7 @@ static void octep_oq_drop_rx(struct octep_oq *oq, while (data_len > 0) { octep_oq_next_pkt(oq, buff_info, read_idx, desc_used); data_len -= oq->buffer_size; - }; + } } /**
This patch removes an unneeded semicolon after a while statement. ./drivers/net/ethernet/marvell/octeon_ep/octep_rx.c:381:2-3: Unneeded semicolon Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11430 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/net/ethernet/marvell/octeon_ep/octep_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)