From patchwork Mon Nov 4 21:55:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Damato X-Patchwork-Id: 13862153 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7D411FEFB6 for ; Mon, 4 Nov 2024 21:56:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730757420; cv=none; b=nfzOeqqcQ/5A0oLKbsbIiKcP9Ooxg9lKm72jhw835/KkqxHuYy24bNdu4Qu/fDqjHuye2RkxJWqT7ids+B8nnLe908+BZuKRDVdrjyooqySevZDNbjolmbOVtBTBeiPlJicH7bascoGDX+UfixuRHVz0pNnCfm+bDR2r28Re0tE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730757420; c=relaxed/simple; bh=ZvawQy978AWawDyo2L5Npe51s7GUMbBNxiumv6HwfAk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hOC1c4jvdg44D8Z1e4VUlRpERFUi7yB3S7O0G03SwzHPWDG8OU40V+DfdH1ERP+yfonVKY9+n/8DyWZCth+ENShHA3o3xriKTHDg3CaeBW/L1HWRONJtLmEXzoQRFG9Wf09HqfckcARUz4+oanm4ummWQufcrI7yTXA1rnmfLN8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=jJEgP3sS; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="jJEgP3sS" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-20c7ee8fe6bso44342885ad.2 for ; Mon, 04 Nov 2024 13:56:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1730757418; x=1731362218; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U/mZBN4ImS6YyPeWvLF6rIBEjo5ZB0WxVpPyUomkuEI=; b=jJEgP3sSzB4zBbUJM4ZEQSZMZ6SPVxRfGqYfKMQMFy9GWk+EVXe8d4VZRnbyEr6RXa Pj/cDGkYzJ+rIksmLoQVLvIn9bmvcZrEVlBz/alsPkfQiNljqFXAdwbuucaDT9Rxkmmp Fe4XGqy9dKqhsSqvvmTvwET9/GJALQpIghiMo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730757418; x=1731362218; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U/mZBN4ImS6YyPeWvLF6rIBEjo5ZB0WxVpPyUomkuEI=; b=KpWAU7XFjaB5Z19IcTzluWYm7sSBF2eTd1I06NB4Km4NCHECK1o/EQq2ic/jX6rj/Y e+N7aUHzcUS+6pVv0DkMHmy4DCMVcGnjSHS5EmntKjV930uGrNiVJCWQK2bj7rxpN1pa QP4LNGQ77R3pvly0BBdW7Az9thIIjcllR7MRA7TuGsvINjk2xF6KimNzyq28RtxWi+zT kRFsfGh8qakxXrduDzoOF39loYYV7XP1dyjsdoc6TUFlnUqjv6/I4zmmgdfM943ro+R+ yKu09Ga6vXeDj0HNcfQZQpSx4rQZAf7BYqMK43WTW7+8Si5kfbT+IHrW35FeyTuakkAU 3zeg== X-Gm-Message-State: AOJu0YwapmyApvZwE47HR58LwN4kgox1/p2IY5eGXHdmTT0wCdFpJ18a ouiAFYpZmH2pTq2n+xezBw8KbTge8UIf6OhDohzcNzshUaOnci54C1NCdyzgnCD+h3Ak10lV8vo OfEJ9UljgqKG1GoOvi9HONI6rPknx9JBv2tzeI0ct8RkZEaZYTCSJuG3SaFsuk1JcrvH91K+n8B jdW1pV+G846mwsfQVixzSQ5zS1lWtMXINvcWI= X-Google-Smtp-Source: AGHT+IENlIsq8+IIDsyU+nhB9TYp003iEeEe93gLutUdQX68yVgJFPhwu5VGXlQldD52ko60WmxTLA== X-Received: by 2002:a17:902:d54a:b0:20c:d2d9:766f with SMTP id d9443c01a7336-210c68986efmr450019785ad.14.1730757417754; Mon, 04 Nov 2024 13:56:57 -0800 (PST) Received: from localhost.localdomain ([2620:11a:c019:0:65e:3115:2f58:c5fd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057062b8sm65860255ad.63.2024.11.04.13.56.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 13:56:57 -0800 (PST) From: Joe Damato To: netdev@vger.kernel.org Cc: corbet@lwn.net, hdanton@sina.com, bagasdotme@gmail.com, pabeni@redhat.com, namangulati@google.com, edumazet@google.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, sdf@fomichev.me, peter@typeblog.net, m2shafiei@uwaterloo.ca, bjorn@rivosinc.com, hch@infradead.org, willy@infradead.org, willemdebruijn.kernel@gmail.com, skhawaja@google.com, kuba@kernel.org, Martin Karsten , Joe Damato , Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure)), linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next v6 5/7] eventpoll: Control irq suspension for prefer_busy_poll Date: Mon, 4 Nov 2024 21:55:29 +0000 Message-Id: <20241104215542.215919-6-jdamato@fastly.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241104215542.215919-1-jdamato@fastly.com> References: <20241104215542.215919-1-jdamato@fastly.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Martin Karsten When events are reported to userland and prefer_busy_poll is set, irqs are temporarily suspended using napi_suspend_irqs. If no events are found and ep_poll would go to sleep, irq suspension is cancelled using napi_resume_irqs. Signed-off-by: Martin Karsten Co-developed-by: Joe Damato Signed-off-by: Joe Damato Tested-by: Joe Damato Tested-by: Martin Karsten Acked-by: Stanislav Fomichev Reviewed-by: Sridhar Samudrala --- v5: - Only call ep_suspend_napi_irqs when ep_send_events returns a positive value. IRQs are not suspended in error (e.g. EINTR) cases. This issue was pointed out by Hillf Danton. rfc -> v1: - move irq resume code from ep_free to a helper which either resumes IRQs or does nothing if !defined(CONFIG_NET_RX_BUSY_POLL). fs/eventpoll.c | 32 +++++++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index f9e0d9307dad..83bcb559b89f 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -457,6 +457,8 @@ static bool ep_busy_loop(struct eventpoll *ep, int nonblock) * it back in when we have moved a socket with a valid NAPI * ID onto the ready list. */ + if (prefer_busy_poll) + napi_resume_irqs(napi_id); ep->napi_id = 0; return false; } @@ -540,6 +542,22 @@ static long ep_eventpoll_bp_ioctl(struct file *file, unsigned int cmd, } } +static void ep_suspend_napi_irqs(struct eventpoll *ep) +{ + unsigned int napi_id = READ_ONCE(ep->napi_id); + + if (napi_id >= MIN_NAPI_ID && READ_ONCE(ep->prefer_busy_poll)) + napi_suspend_irqs(napi_id); +} + +static void ep_resume_napi_irqs(struct eventpoll *ep) +{ + unsigned int napi_id = READ_ONCE(ep->napi_id); + + if (napi_id >= MIN_NAPI_ID && READ_ONCE(ep->prefer_busy_poll)) + napi_resume_irqs(napi_id); +} + #else static inline bool ep_busy_loop(struct eventpoll *ep, int nonblock) @@ -557,6 +575,14 @@ static long ep_eventpoll_bp_ioctl(struct file *file, unsigned int cmd, return -EOPNOTSUPP; } +static void ep_suspend_napi_irqs(struct eventpoll *ep) +{ +} + +static void ep_resume_napi_irqs(struct eventpoll *ep) +{ +} + #endif /* CONFIG_NET_RX_BUSY_POLL */ /* @@ -788,6 +814,7 @@ static bool ep_refcount_dec_and_test(struct eventpoll *ep) static void ep_free(struct eventpoll *ep) { + ep_resume_napi_irqs(ep); mutex_destroy(&ep->mtx); free_uid(ep->user); wakeup_source_unregister(ep->ws); @@ -2005,8 +2032,11 @@ static int ep_poll(struct eventpoll *ep, struct epoll_event __user *events, * trying again in search of more luck. */ res = ep_send_events(ep, events, maxevents); - if (res) + if (res) { + if (res > 0) + ep_suspend_napi_irqs(ep); return res; + } } if (timed_out)