diff mbox series

[iproute2-next] bash-completion: devlink: fix port param name show completion

Message ID 20241115055848.2979328-1-saeed@kernel.org (mailing list archive)
State New
Delegated to: David Ahern
Headers show
Series [iproute2-next] bash-completion: devlink: fix port param name show completion | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Saeed Mahameed Nov. 15, 2024, 5:58 a.m. UTC 
From: Saeed Mahameed <saeedm@nvidia.com>

Port param names are found with "devlink port param show", and not
"devlink param show", fix that.

Port dev name can be a netdev, so find the actual port dev before
querying "devlink port params show | jq '... [$dev] ...'",
since "devlink port params show" doesn't return the netdev name,
but the actual port dev name.

Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 bash-completion/devlink | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/bash-completion/devlink b/bash-completion/devlink
index 52dc82b3..ac5ea62c 100644
--- a/bash-completion/devlink
+++ b/bash-completion/devlink
@@ -43,6 +43,15 @@  _devlink_direct_complete()
             value=$(devlink -j dev param show 2>/dev/null \
                     | jq ".param[\"$dev\"][].name")
             ;;
+        port_param_name)
+            dev=${words[4]}
+            # dev could be a port or a netdev so find the port
+            portdev=$(devlink -j port show dev $dev 2>/dev/null \
+                    | jq '.port as $ports | $ports | keys[] as $keys | keys[0] ')
+
+            value=$(devlink -j port param show 2>/dev/null \
+                    | jq ".param[$portdev][].name")
+            ;;
         port)
             value=$(devlink -j port show 2>/dev/null \
                     | jq '.port as $ports | $ports | keys[] as $key
@@ -401,7 +410,7 @@  _devlink_port_param()
             return
             ;;
         6)
-            _devlink_direct_complete "param_name"
+            _devlink_direct_complete "port_param_name"
             return
             ;;
     esac