diff mbox series

[net-next,01/14] netfilter: nfnetlink: Report extack policy errors for batched ops

Message ID 20241115133207.8907-2-pablo@netfilter.org (mailing list archive)
State Accepted
Commit 3f5495962824fbef3b9a577ccd9b02f967452c11
Delegated to: Netdev Maintainers
Headers show
Series [net-next,01/14] netfilter: nfnetlink: Report extack policy errors for batched ops | expand

Checks

Context Check Description
netdev/series_format success Pull request is its own cover letter
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 3 this patch: 3
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 3 maintainers not CCed: kadlec@netfilter.org horms@kernel.org coreteam@netfilter.org
netdev/build_clang success Errors and warnings before: 3 this patch: 3
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 4 this patch: 4
netdev/checkpatch warning WARNING: line length of 82 exceeds 80 columns
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-11-15--21-00 (tests: 789)

Commit Message

Pablo Neira Ayuso Nov. 15, 2024, 1:31 p.m. UTC
From: Donald Hunter <donald.hunter@gmail.com>

The nftables batch processing does not currently populate extack with
policy errors. Fix this by passing extack when parsing batch messages.

Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 net/netfilter/nfnetlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Nov. 15, 2024, 10:20 p.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Pablo Neira Ayuso <pablo@netfilter.org>:

On Fri, 15 Nov 2024 14:31:54 +0100 you wrote:
> From: Donald Hunter <donald.hunter@gmail.com>
> 
> The nftables batch processing does not currently populate extack with
> policy errors. Fix this by passing extack when parsing batch messages.
> 
> Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
> Reviewed-by: Simon Horman <horms@kernel.org>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> 
> [...]

Here is the summary with links:
  - [net-next,01/14] netfilter: nfnetlink: Report extack policy errors for batched ops
    https://git.kernel.org/netdev/net-next/c/3f5495962824
  - [net-next,02/14] netfilter: bpf: Pass string literal as format argument of request_module()
    https://git.kernel.org/netdev/net-next/c/8340b0056ac7
  - [net-next,03/14] netfilter: nf_tables: add nft_trans_commit_list_add_elem helper
    https://git.kernel.org/netdev/net-next/c/4ee29181216d
  - [net-next,04/14] netfilter: nf_tables: prepare for multiple elements in nft_trans_elem structure
    https://git.kernel.org/netdev/net-next/c/a8ee6b900c14
  - [net-next,05/14] netfilter: nf_tables: prepare nft audit for set element compaction
    https://git.kernel.org/netdev/net-next/c/466c9b3b2a92
  - [net-next,06/14] netfilter: nf_tables: switch trans_elem to real flex array
    https://git.kernel.org/netdev/net-next/c/b0c49466043a
  - [net-next,07/14] netfilter: nf_tables: allocate element update information dynamically
    https://git.kernel.org/netdev/net-next/c/508180850b73
  - [net-next,08/14] netfilter: ipv4: Convert ip_route_me_harder() to dscp_t.
    https://git.kernel.org/netdev/net-next/c/0608746f95b2
  - [net-next,09/14] netfilter: flow_offload: Convert nft_flow_route() to dscp_t.
    https://git.kernel.org/netdev/net-next/c/6f9615a6e686
  - [net-next,10/14] netfilter: rpfilter: Convert rpfilter_mt() to dscp_t.
    https://git.kernel.org/netdev/net-next/c/f694ce6de589
  - [net-next,11/14] netfilter: nft_fib: Convert nft_fib4_eval() to dscp_t.
    https://git.kernel.org/netdev/net-next/c/f12b67cc7d1b
  - [net-next,12/14] netfilter: nf_dup4: Convert nf_dup_ipv4_route() to dscp_t.
    https://git.kernel.org/netdev/net-next/c/f0d839c13ed5
  - [net-next,13/14] netfilter: bitwise: rename some boolean operation functions
    https://git.kernel.org/netdev/net-next/c/a12143e6084c
  - [net-next,14/14] netfilter: bitwise: add support for doing AND, OR and XOR directly
    https://git.kernel.org/netdev/net-next/c/b0ccf4f53d96

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c
index 7784ec094097..e598a2a252b0 100644
--- a/net/netfilter/nfnetlink.c
+++ b/net/netfilter/nfnetlink.c
@@ -517,7 +517,7 @@  static void nfnetlink_rcv_batch(struct sk_buff *skb, struct nlmsghdr *nlh,
 			err = nla_parse_deprecated(cda,
 						   ss->cb[cb_id].attr_count,
 						   attr, attrlen,
-						   ss->cb[cb_id].policy, NULL);
+						   ss->cb[cb_id].policy, &extack);
 			if (err < 0)
 				goto ack;