| Message ID | 20241120093904.8629-1-jerry.meng.lk@quectel.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v2] net: wwan: Add WWAN sahara port type | expand |
+Manivannan Hello Jerry, this version looks a way better, still there is one minor thing to improve. See below. Manivannan, Loic, could you advice is it Ok to export that SAHARA port as is? On 20.11.2024 11:39, Jerry Meng wrote: > Add a Sahara protocol-based interface for downloading ramdump > from Qualcomm modems in SBL ramdump mode. > > Signed-off-by: Jerry Meng <jerry.meng.lk@quectel.com> > --- > v1 -> v2: > - Fix errors checked by checkpatch.pl, mainly change indentation from space to tab > - change my email acount to fit git-send-email > > drivers/net/wwan/mhi_wwan_ctrl.c | 1 + > drivers/net/wwan/wwan_core.c | 4 ++++ > include/linux/wwan.h | 2 ++ > 3 files changed, 7 insertions(+) > > diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c b/drivers/net/wwan/mhi_wwan_ctrl.c > index e9f979d2d..082090ae5 100644 > --- a/drivers/net/wwan/mhi_wwan_ctrl.c > +++ b/drivers/net/wwan/mhi_wwan_ctrl.c > @@ -263,6 +263,7 @@ static const struct mhi_device_id mhi_wwan_ctrl_match_table[] = { > { .chan = "QMI", .driver_data = WWAN_PORT_QMI }, > { .chan = "DIAG", .driver_data = WWAN_PORT_QCDM }, > { .chan = "FIREHOSE", .driver_data = WWAN_PORT_FIREHOSE }, > + { .chan = "SAHARA", .driver_data = WWAN_PORT_SAHARA}, ^ The space is still missing between WWAN_PORT_SAHARA and trailing '}'. Please follow the format of existing table entries. > {}, > }; > MODULE_DEVICE_TABLE(mhi, mhi_wwan_ctrl_match_table); > diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c > index a51e27559..5eb0d6de3 100644 > --- a/drivers/net/wwan/wwan_core.c > +++ b/drivers/net/wwan/wwan_core.c > @@ -342,6 +342,10 @@ static const struct { > .name = "MIPC", > .devsuf = "mipc", > }, > + [WWAN_PORT_SAHARA] = { > + .name = "SAHARA", > + .devsuf = "sahara", > + }, > }; > > static ssize_t type_show(struct device *dev, struct device_attribute *attr, > diff --git a/include/linux/wwan.h b/include/linux/wwan.h > index 79c781875..b0ea276f2 100644 > --- a/include/linux/wwan.h > +++ b/include/linux/wwan.h > @@ -19,6 +19,7 @@ > * @WWAN_PORT_FASTBOOT: Fastboot protocol control > * @WWAN_PORT_ADB: ADB protocol control > * @WWAN_PORT_MIPC: MTK MIPC diagnostic interface > + * @WWAN_PORT_SAHARA: Sahara protocol-based interface for downloading ramdump from Qualcomm modems > * > * @WWAN_PORT_MAX: Highest supported port types > * @WWAN_PORT_UNKNOWN: Special value to indicate an unknown port type > @@ -34,6 +35,7 @@ enum wwan_port_type { > WWAN_PORT_FASTBOOT, > WWAN_PORT_ADB, > WWAN_PORT_MIPC, > + WWAN_PORT_SAHARA, > > /* Add new port types above this line */ >
On 11/20/2024 1:36 PM, Sergey Ryazanov wrote: > +Manivannan > > Hello Jerry, > > this version looks a way better, still there is one minor thing to > improve. See below. > > Manivannan, Loic, could you advice is it Ok to export that SAHARA port > as is? I'm against this. There is an in-kernel Sahara implementation, which is going to be used by QDU100. If WWAN is going to own the "SAHARA" MHI channel name, then no one else can use it which will conflict with QDU100. I expect the in-kernel implementation can be leveraged for this. -Jeff
diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c b/drivers/net/wwan/mhi_wwan_ctrl.c index e9f979d2d..082090ae5 100644 --- a/drivers/net/wwan/mhi_wwan_ctrl.c +++ b/drivers/net/wwan/mhi_wwan_ctrl.c @@ -263,6 +263,7 @@ static const struct mhi_device_id mhi_wwan_ctrl_match_table[] = { { .chan = "QMI", .driver_data = WWAN_PORT_QMI }, { .chan = "DIAG", .driver_data = WWAN_PORT_QCDM }, { .chan = "FIREHOSE", .driver_data = WWAN_PORT_FIREHOSE }, + { .chan = "SAHARA", .driver_data = WWAN_PORT_SAHARA}, {}, }; MODULE_DEVICE_TABLE(mhi, mhi_wwan_ctrl_match_table); diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c index a51e27559..5eb0d6de3 100644 --- a/drivers/net/wwan/wwan_core.c +++ b/drivers/net/wwan/wwan_core.c @@ -342,6 +342,10 @@ static const struct { .name = "MIPC", .devsuf = "mipc", }, + [WWAN_PORT_SAHARA] = { + .name = "SAHARA", + .devsuf = "sahara", + }, }; static ssize_t type_show(struct device *dev, struct device_attribute *attr, diff --git a/include/linux/wwan.h b/include/linux/wwan.h index 79c781875..b0ea276f2 100644 --- a/include/linux/wwan.h +++ b/include/linux/wwan.h @@ -19,6 +19,7 @@ * @WWAN_PORT_FASTBOOT: Fastboot protocol control * @WWAN_PORT_ADB: ADB protocol control * @WWAN_PORT_MIPC: MTK MIPC diagnostic interface + * @WWAN_PORT_SAHARA: Sahara protocol-based interface for downloading ramdump from Qualcomm modems * * @WWAN_PORT_MAX: Highest supported port types * @WWAN_PORT_UNKNOWN: Special value to indicate an unknown port type @@ -34,6 +35,7 @@ enum wwan_port_type { WWAN_PORT_FASTBOOT, WWAN_PORT_ADB, WWAN_PORT_MIPC, + WWAN_PORT_SAHARA, /* Add new port types above this line */
Add a Sahara protocol-based interface for downloading ramdump from Qualcomm modems in SBL ramdump mode. Signed-off-by: Jerry Meng <jerry.meng.lk@quectel.com> --- v1 -> v2: - Fix errors checked by checkpatch.pl, mainly change indentation from space to tab - change my email acount to fit git-send-email drivers/net/wwan/mhi_wwan_ctrl.c | 1 + drivers/net/wwan/wwan_core.c | 4 ++++ include/linux/wwan.h | 2 ++ 3 files changed, 7 insertions(+)