From patchwork Thu Nov 28 01:24:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ihor Solodrai X-Patchwork-Id: 13887516 Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3705B20328 for ; Thu, 28 Nov 2024 01:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.40.134 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732757054; cv=none; b=CSKENetp2B1zeHZQTl1nK/vodGqhHMraY/xUvSBzpSZ4Dzaiv5hFEd0C2ihYO//obuRJ4SVTxqiZUtt24bmGtMnyXdhyecBPUWRySphJma5smYuCy/qtxAdiNfPhNZo2cAQb5jzD+/CDNcvECyTwdg6FoIGJwy8Wjb/JrRszK7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732757054; c=relaxed/simple; bh=BnWwXROR2X2195O5Cz/zW3eOHyBTPxvpTZVyL8M+SK4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SAywf4reyaA1s6szEma2B1DOXNHZzwLtlUiT7jQvMbvBoz7wgD0NYf3kypgEqY039bS1kRolFo8xvXKtKVxI76lyPpa6RrAq3FMZRbf0WBFOsiUuLGq5BPDa7Z+th32PoP7hxggsS+L/ZGQr7LjmtY0AGBmn33GjED+E64DmQbg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pm.me; spf=pass smtp.mailfrom=pm.me; dkim=pass (2048-bit key) header.d=pm.me header.i=@pm.me header.b=ZZLifAn9; arc=none smtp.client-ip=185.70.40.134 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pm.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pm.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pm.me header.i=@pm.me header.b="ZZLifAn9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail3; t=1732757049; x=1733016249; bh=zL986JE9ZKQsRcp97zfsphYsYM0KbMTdRoWVjWjNXKE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=ZZLifAn9dmRQZnxA/VCdNzoahrVLIEu9Q4h3r/Qn8GyDRkhiRQdgZERR4c0rkAU3R fkokbV2KyQOjTt6AgYXUqZG9BKjR7Sz1EfKnXckfEe6++5ps2xjy3i+Xk+4KX3UKFd pGZZjYtJNWAzVqv0E3NA7s89SQXZszzfOmtR25nc9kC5VnNxvCfy56fHQpPXZix+ck o7ilUAj6fH/Kgr70Lk5Zkxtr4JgfYMpk3rKHS/f+ssr0gdNFEerbbIzBwTmyTrhA0a 7kA2afO8z1PakTsVajv4Jy2XlTmCfG45ECP8B42H40O8WuIDq/I/fsV7JzB+xej8Ka mMaz0Sb/f+tGw== Date: Thu, 28 Nov 2024 01:24:05 +0000 To: dwarves@vger.kernel.org, acme@kernel.org From: Ihor Solodrai Cc: bpf@vger.kernel.org, alan.maguire@oracle.com, eddyz87@gmail.com, andrii@kernel.org, mykolal@fb.com Subject: [RFC PATCH 5/9] btf_encoder: introduce elf_functions struct type Message-ID: <20241128012341.4081072-6-ihor.solodrai@pm.me> In-Reply-To: <20241128012341.4081072-1-ihor.solodrai@pm.me> References: <20241128012341.4081072-1-ihor.solodrai@pm.me> Feedback-ID: 27520582:user:proton X-Pm-Message-ID: 5cd7877b1b7649a8fe84eb05156f5774e565f4ac Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-State: RFC Extract elf_functions struct type from btf_encoder. Replace methods operating functions table in btf_encoder by methods operating on elf_functions: - btf_encoder__collect_function -> elf_functions__collect_function - btf_encoder__collect_symbols -> elf_functions__collect Now these functions do not depend on btf_encoder being passed to them as a parameter. Signed-off-by: Ihor Solodrai --- btf_encoder.c | 125 ++++++++++++++++++++++++++------------------------ 1 file changed, 66 insertions(+), 59 deletions(-) diff --git a/btf_encoder.c b/btf_encoder.c index 6114cc8..8331efe 100644 --- a/btf_encoder.c +++ b/btf_encoder.c @@ -102,6 +102,13 @@ struct elf_secinfo { struct gobuffer secinfo; }; +struct elf_functions { + struct elf_symtab *symtab; + struct elf_function *entries; + int cnt; + int suffix_cnt; /* number of .isra, .part etc */ +}; + /* * cu: cu being processed. */ @@ -128,13 +135,7 @@ struct btf_encoder { size_t seccnt; int encode_vars; struct list_head func_states; - struct { - struct elf_function *entries; - int allocated; - int cnt; - int suffix_cnt; /* number of .isra, .part etc */ - uint64_t base_addr; - } functions; + struct elf_functions functions; }; struct btf_func { @@ -1226,16 +1227,6 @@ static int functions_cmp(const void *_a, const void *_b) #define max(x, y) ((x) < (y) ? (y) : (x)) #endif -static void *reallocarray_grow(void *ptr, int *nmemb, size_t size) -{ - int new_nmemb = max(1000, *nmemb * 3 / 2); - void *new = realloc(ptr, new_nmemb * size); - - if (new) - *nmemb = new_nmemb; - return new; -} - static int saved_functions_cmp(const void *_a, const void *_b) { struct btf_encoder_func_state * const *a = _a; @@ -1339,47 +1330,34 @@ static int btf_encoder__add_saved_funcs(struct btf_encoder *encoder) return 0; } -static int btf_encoder__collect_function(struct btf_encoder *encoder, GElf_Sym *sym) +static int elf_functions__collect_function(struct elf_functions *functions, GElf_Sym *sym) { - struct elf_function *new; + struct elf_function *func; const char *name; uint64_t addr; if (elf_sym__type(sym) != STT_FUNC) return 0; - name = elf_sym__name(sym, encoder->symtab); + + name = elf_sym__name(sym, functions->symtab); if (!name) return 0; - if (encoder->functions.cnt == encoder->functions.allocated) { - new = reallocarray_grow(encoder->functions.entries, - &encoder->functions.allocated, - sizeof(*encoder->functions.entries)); - if (!new) { - /* - * The cleanup - delete_functions is called - * in btf_encoder__encode_cu error path. - */ - return -1; - } - encoder->functions.entries = new; - } - - memset(&encoder->functions.entries[encoder->functions.cnt], 0, - sizeof(*new)); - encoder->functions.entries[encoder->functions.cnt].name = name; + func = &functions->entries[functions->cnt]; + func->name = name; /* convert to absoulte address for DWARF/ELF matching. */ addr = elf_sym__value(sym); - encoder->functions.entries[encoder->functions.cnt].addr = (uint32_t)addr; + func->addr = (uint32_t)addr; if (strchr(name, '.')) { const char *suffix = strchr(name, '.'); - - encoder->functions.suffix_cnt++; - encoder->functions.entries[encoder->functions.cnt].prefixlen = suffix - name; + functions->suffix_cnt++; + func->prefixlen = suffix - name; } else { - encoder->functions.entries[encoder->functions.cnt].prefixlen = strlen(name); + func->prefixlen = strlen(name); } - encoder->functions.cnt++; + + functions->cnt++; + return 0; } @@ -2132,31 +2110,59 @@ int btf_encoder__encode(struct btf_encoder *encoder) return err; } - -static int btf_encoder__collect_symbols(struct btf_encoder *encoder) +static int elf_functions__collect(struct elf_functions *functions) { - bool base_addr_set = false; - uint32_t sym_sec_idx; + uint32_t nr_symbols = elf_symtab__nr_symbols(functions->symtab); + struct elf_function *tmp; + Elf32_Word sym_sec_idx; uint32_t core_id; GElf_Sym sym; + int err; + + /* We know that number of functions is less than number of symbols, + * so we can overallocate temporarily. + */ + functions->entries = calloc(nr_symbols, sizeof(struct elf_function)); + if (!functions->entries) { + err = -ENOMEM; + goto out_free; + } - elf_symtab__for_each_symbol_index(encoder->symtab, core_id, sym, sym_sec_idx) { - if (!base_addr_set && sym_sec_idx && sym_sec_idx < encoder->seccnt) { - encoder->functions.base_addr = encoder->secinfo[sym_sec_idx].addr; - base_addr_set = true; + functions->cnt = 0; + elf_symtab__for_each_symbol_index(functions->symtab, core_id, sym, sym_sec_idx) { + if (elf_functions__collect_function(functions, &sym)) { + err = -1; + goto out_free; } - if (btf_encoder__collect_function(encoder, &sym)) - return -1; } - if (encoder->functions.cnt) { - qsort(encoder->functions.entries, encoder->functions.cnt, sizeof(encoder->functions.entries[0]), + if (functions->cnt) { + qsort(functions->entries, + functions->cnt, + sizeof(functions->entries[0]), functions_cmp); - if (encoder->verbose) - printf("Found %d functions!\n", encoder->functions.cnt); + } else { + err = 0; + goto out_free; + } + + /* Reallocate to the exact size */ + tmp = realloc(functions->entries, functions->cnt * sizeof(struct elf_function)); + if (tmp) { + functions->entries = tmp; + } else { + fprintf(stderr, "could not reallocate memory for elf_functions table\n"); + err = -ENOMEM; + goto out_free; } return 0; + +out_free: + free(functions->entries); + functions->entries = NULL; + functions->cnt = 0; + return err; } static bool ftype__has_arg_names(const struct ftype *ftype) @@ -2417,6 +2423,7 @@ struct btf_encoder *btf_encoder__new(struct cu *cu, const char *detached_filenam printf("%s: '%s' doesn't have symtab.\n", __func__, cu->filename); goto out; } + encoder->functions.symtab = encoder->symtab; /* index the ELF sections for later lookup */ @@ -2455,7 +2462,7 @@ struct btf_encoder *btf_encoder__new(struct cu *cu, const char *detached_filenam if (!found_percpu && encoder->verbose) printf("%s: '%s' doesn't have '%s' section\n", __func__, cu->filename, PERCPU_SECTION); - if (btf_encoder__collect_symbols(encoder)) + if (elf_functions__collect(&encoder->functions)) goto out_delete; if (encoder->verbose) @@ -2486,7 +2493,7 @@ void btf_encoder__delete(struct btf_encoder *encoder) encoder->btf = NULL; elf_symtab__delete(encoder->symtab); - encoder->functions.allocated = encoder->functions.cnt = 0; + encoder->functions.cnt = 0; free(encoder->functions.entries); encoder->functions.entries = NULL;