diff mbox series

[5.4/5.10/5.15,1/1] net/tls: tls_is_tx_ready() checked list_entry

Message ID 20241128183509.23236-2-n.zhandarovich@fintech.ru (mailing list archive)
State New
Delegated to: Netdev Maintainers
Headers show
Series Backport fix for CVE-2023-1075 | expand

Checks

Context Check Description
netdev/tree_selection success Guessing tree name failed - patch did not apply

Commit Message

Nikita Zhandarovich Nov. 28, 2024, 6:35 p.m. UTC 
From: Pietro Borrello <borrello@diag.uniroma1.it>

[ Upstream commit ffe2a22562444720b05bdfeb999c03e810d84cbb ]

tls_is_tx_ready() checks that list_first_entry() does not return NULL.
This condition can never happen. For empty lists, list_first_entry()
returns the list_entry() of the head, which is a type confusion.
Use list_first_entry_or_null() which returns NULL in case of empty
lists.

Fixes: a42055e ("net/tls: Add support for async encryption of records for performance")
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
Link: https://lore.kernel.org/r/20230128-list-entry-null-check-tls-v1-1-525bbfe6f0d0@diag.uniroma1.it
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[Nikita: since tls_is_tx_ready() exists only as is_tx_ready() in
include/net/tls.h, fix the issue there instead.]
Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
---
 include/net/tls.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/include/net/tls.h b/include/net/tls.h
index 7f220e03ebb2..e6836a5dfb6e 100644
--- a/include/net/tls.h
+++ b/include/net/tls.h
@@ -427,7 +427,7 @@  static inline bool is_tx_ready(struct tls_sw_context_tx *ctx)
 {
 	struct tls_rec *rec;
 
-	rec = list_first_entry(&ctx->tx_list, struct tls_rec, list);
+	rec = list_first_entry_or_null(&ctx->tx_list, struct tls_rec, list);
 	if (!rec)
 		return false;