Message ID | 20241202-fix-oops-__smc_diag_dump-v2-1-119736963ba9@iiitd.ac.in (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [net-next,RESEND,v2] net/smc: Remove unused function parameter in __smc_diag_dump | expand |
On 12/2/24 11:10, Manas via B4 Relay wrote: > From: Manas <manas18244@iiitd.ac.in> > > The last parameter in __smc_diag_dump (struct nlattr *bc) is unused. > There is only one instance of this function being called and its passed > with a NULL value in place of bc. > > Reviewed-by: Simon Horman <horms@kernel.org> > Signed-off-by: Manas <manas18244@iiitd.ac.in> The signed-off-by tag must include your full name, see: https://elixir.bootlin.com/linux/v6.11.8/source/Documentation/process/submitting-patches.rst#L440 Thanks, Paolo
diff --git a/net/smc/smc_diag.c b/net/smc/smc_diag.c index 6fdb2d96777ad704c394709ec845f9ddef5e599a..8f7bd40f475945171a0afa5a2cce12d9aa2b1eb4 100644 --- a/net/smc/smc_diag.c +++ b/net/smc/smc_diag.c @@ -71,8 +71,7 @@ static int smc_diag_msg_attrs_fill(struct sock *sk, struct sk_buff *skb, static int __smc_diag_dump(struct sock *sk, struct sk_buff *skb, struct netlink_callback *cb, - const struct smc_diag_req *req, - struct nlattr *bc) + const struct smc_diag_req *req) { struct smc_sock *smc = smc_sk(sk); struct smc_diag_fallback fallback; @@ -199,7 +198,6 @@ static int smc_diag_dump_proto(struct proto *prot, struct sk_buff *skb, struct smc_diag_dump_ctx *cb_ctx = smc_dump_context(cb); struct net *net = sock_net(skb->sk); int snum = cb_ctx->pos[p_type]; - struct nlattr *bc = NULL; struct hlist_head *head; int rc = 0, num = 0; struct sock *sk; @@ -214,7 +212,7 @@ static int smc_diag_dump_proto(struct proto *prot, struct sk_buff *skb, continue; if (num < snum) goto next; - rc = __smc_diag_dump(sk, skb, cb, nlmsg_data(cb->nlh), bc); + rc = __smc_diag_dump(sk, skb, cb, nlmsg_data(cb->nlh)); if (rc < 0) goto out; next: