| Message ID | 20241205072048.1397570-2-jacky_chou@aspeedtech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add Aspeed G7 FTGMAC100 support | expand |
On Thu, 05 Dec 2024 15:20:42 +0800, Jacky Chou wrote: > The AST2700 is the 7th generation SoC from Aspeed. > Add compatible support and resets property for AST2700 in > yaml. > > Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > --- > .../bindings/net/faraday,ftgmac100.yaml | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml: then:properties:resets: {'maxItems': 1, 'items': [{'description': 'MAC IP reset for AST2700'}]} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241205072048.1397570-2-jacky_chou@aspeedtech.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Thu, Dec 05, 2024 at 03:20:42PM +0800, Jacky Chou wrote: > The AST2700 is the 7th generation SoC from Aspeed. > Add compatible support and resets property for AST2700 in > yaml. > > Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> Your changelog in cover letter does not mention received ack. When did it happen? > --- > .../bindings/net/faraday,ftgmac100.yaml | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml > index 9bcbacb6640d..3bba8eee83d6 100644 > --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml > +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml > @@ -21,6 +21,7 @@ properties: > - aspeed,ast2400-mac > - aspeed,ast2500-mac > - aspeed,ast2600-mac > + - aspeed,ast2700-mac > - const: faraday,ftgmac100 > > reg: > @@ -33,7 +34,7 @@ properties: > minItems: 1 > items: > - description: MAC IP clock > - - description: RMII RCLK gate for AST2500/2600 > + - description: RMII RCLK gate for AST2500/2600/2700 > > clock-names: > minItems: 1 > @@ -73,6 +74,20 @@ required: > > unevaluatedProperties: false > > +if: > + properties: > + compatible: > + contains: > + const: aspeed,ast2700-mac 1. That's a signigicant change. *Drop ack.* 2. Test your bindings. 3. Put if: block under allOf: and move entire allOf just above your unevaluatedProperties... if this stays. 4. But you cannot define properties in if:then. They must be defined in top level. You can disallow them for variants in if:then: with :false" Even exmaple schema has exactly this case: https://elixir.bootlin.com/linux/v5.19/source/Documentation/devicetree/bindings/example-schema.yaml#L212 Best regards, Krzysztof
On Thu, Dec 05, 2024 at 03:20:42PM +0800, Jacky Chou wrote: > The AST2700 is the 7th generation SoC from Aspeed. > Add compatible support and resets property for AST2700 in > yaml. > > Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > --- You were asked to post upstream DTS. Hold with your new versions till you have DTS ready. Best regards, Krzysztof
Hi Rob Thank you for you reply. > > The AST2700 is the 7th generation SoC from Aspeed. > > Add compatible support and resets property for AST2700 in yaml. > > > > Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > --- > > .../bindings/net/faraday,ftgmac100.yaml | 17 > ++++++++++++++++- > > 1 file changed, 16 insertions(+), 1 deletion(-) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ > faraday,ftgmac100.yaml: then:properties:resets: {'maxItems': 1, 'items': > [{'description': 'MAC IP reset for AST2700'}]} should not be valid under > {'required': ['maxItems']} > hint: "maxItems" is not needed with an "items" list > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > > doc reference errors (make refcheckdocs): > > See > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/202412050720 > 48.1397570-2-jacky_chou@aspeedtech.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above error(s), > then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. Thank you for your kind reminder. I will run 'make dt_binding_check' and confirm there is no error or warning. Thanks, Jacky
Hi Krzysztof, Thank you for your reply. > On Thu, Dec 05, 2024 at 03:20:42PM +0800, Jacky Chou wrote: > > The AST2700 is the 7th generation SoC from Aspeed. > > Add compatible support and resets property for AST2700 in yaml. > > > > Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > Your changelog in cover letter does not mention received ack. When did it > happen? I am really sorry for forgetting to remove this 'acked-by'. I will drop it. > > > --- > > .../bindings/net/faraday,ftgmac100.yaml | 17 > ++++++++++++++++- > > 1 file changed, 16 insertions(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml > > b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml > > index 9bcbacb6640d..3bba8eee83d6 100644 > > --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml > > +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml > > @@ -21,6 +21,7 @@ properties: > > - aspeed,ast2400-mac > > - aspeed,ast2500-mac > > - aspeed,ast2600-mac > > + - aspeed,ast2700-mac > > - const: faraday,ftgmac100 > > > > reg: > > @@ -33,7 +34,7 @@ properties: > > minItems: 1 > > items: > > - description: MAC IP clock > > - - description: RMII RCLK gate for AST2500/2600 > > + - description: RMII RCLK gate for AST2500/2600/2700 > > > > clock-names: > > minItems: 1 > > @@ -73,6 +74,20 @@ required: > > > > unevaluatedProperties: false > > > > +if: > > + properties: > > + compatible: > > + contains: > > + const: aspeed,ast2700-mac > > 1. That's a signigicant change. *Drop ack.* > > 2. Test your bindings. > 3. Put if: block under allOf: and move entire allOf just above your > unevaluatedProperties... if this stays. > 4. But you cannot define properties in if:then. They must be defined in top level. > You can disallow them for variants in if:then: with :false" > > Even exmaple schema has exactly this case: > https://elixir.bootlin.com/linux/v5.19/source/Documentation/devicetree/bindin > gs/example-schema.yaml#L212 Thank you for the information. I will correct my patch and hold it before the DTS is ready. Thanks, Jacky
diff --git a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml index 9bcbacb6640d..3bba8eee83d6 100644 --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml @@ -21,6 +21,7 @@ properties: - aspeed,ast2400-mac - aspeed,ast2500-mac - aspeed,ast2600-mac + - aspeed,ast2700-mac - const: faraday,ftgmac100 reg: @@ -33,7 +34,7 @@ properties: minItems: 1 items: - description: MAC IP clock - - description: RMII RCLK gate for AST2500/2600 + - description: RMII RCLK gate for AST2500/2600/2700 clock-names: minItems: 1 @@ -73,6 +74,20 @@ required: unevaluatedProperties: false +if: + properties: + compatible: + contains: + const: aspeed,ast2700-mac +then: + properties: + resets: + maxItems: 1 + items: + - description: MAC IP reset for AST2700 + required: + - resets + examples: - | ethernet@1e660000 {