From patchwork Mon Dec 9 08:53:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Quartulli X-Patchwork-Id: 13899114 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5808D215F78 for ; Mon, 9 Dec 2024 08:53:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733734387; cv=none; b=nypOggH5ocg+xRr0/HRC9iQZdBr3kXvrCo7zPovnvznaoNsor124+NM/1ZC023rcD1Tqcx0SwwVLPYMOW11wC+A+TXAUrZdPorzQrbzt8HGo7kY0yijCIRFmFCRJZJ8lQ/XzS9bFq5uy8ZiLv6jzSkeLn/cDx4IRPNA99hdJ1TA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733734387; c=relaxed/simple; bh=GchxL43RZVWbeeTak50ypiKEh4su8ul45OjPZ601Tf0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t4LgJxNrv3257Txorqdxq1C0NW36lc1y6XUavCP01UyDqxtonaIwzCCn/s+2m9lghke0CzQIb8wcTJfSqambuV9bBueWqo+iQAnH4InXwvlQipdLU73U/8l0YCEDpHqIt49uAB+yhkPc9TvmhQEcYbCnNLrKuhDX08YZI7i7UwM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=EOYT8OZu; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="EOYT8OZu" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-385dece873cso1833160f8f.0 for ; Mon, 09 Dec 2024 00:53:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1733734384; x=1734339184; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=eFk85mO/CYRQjFZfRXq+/JqMZn31zCiBs+VMv6XbtEo=; b=EOYT8OZuMBsgMsJ05yWKFXBld0TvrR7CjRZJiTyoREtbroMl2Cn+z5k4JYAKKoynvy luINcZkGjJRBJSjdE4AeRKLSDzkGStvCHHasCtTqvLBWqAMMV/+FBC6n356rjVA92+yj WtGMTIcXT72eQCfjKqSZfpx4zhHe66Qd7Ay36En+lNH1ik9cdgbuA73ePJV/zKds8A7S z/fR2NrQCIqaXHECOfoUs//HgnLoSXrq31V1TuX7X8hSTgjIV1GOhEoclqvDURZCYDjX rruiSDEpBToSK9BAyB7Jayus9h0A+U43An2DNeeG+Lt2SRFMwNL77l+zWu2GdhkasZcG uPKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733734384; x=1734339184; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eFk85mO/CYRQjFZfRXq+/JqMZn31zCiBs+VMv6XbtEo=; b=qE7//qA7Dh9XF2BICX5iTmFPex4fXBqIaJYV2a6WLNK94zY1ZEIxEptb+vVUIMv1JH fESoLUJoFv7B65PQ19nnY4GEDP2lb5B3pEcjKtebIj2VkA2IMDN1Djtzebs+wXHrMAwS CDWYUUpW7i1TMmu+q8FzJWekDk74FjoLvaFjQ4kSFw0fBYy9+eiGqdqahpgHRO8n43NG 8SI6hVxGRSh882MJGm9uEK6FnOAPFVRUTA6krewWufZtQd00n/fCYh5GXlKcYTBw5qUF 9hlQTnd/CVgmcfQPhsNhsMRBxXLzBNiHth3DNhateLzPEBcygB7m8sDG8Q9Uf88/J4Vr zynA== X-Gm-Message-State: AOJu0YwB/IdLTw6fLMeWR6lJLNTMfiL00lLYdJhJKZdfpLLnOCMoZf6x x2YZaSgE8wLhCf39nobQtX+K+Nfn5jVi6ePK8MV75hnlpxon9PFifRaj4PuOTDs= X-Gm-Gg: ASbGncvqDqcVGooWBdDFEzUKCGCD0KAeCN9QHFe0N0IOfAD4AV5D+Q1SmveKwyw59LN DcrzTY9sW7mh2Tjnd5O3vhsVCeaMZn77t593jNYGy4cTuBa757Mqy8Y1b7DmiuFcIxdRu3vy6Ya kU6SB5aBUnHzVmKDksjLN2RqU2YyUNcDT4J++wdnFTyXon0O84DJHqfS33oqKeqQXoXeZmaYHXN JbwB0A7E2VPuutks/hdYY6BZ9VYpmZr6hqoaVek7QQ2Or20FezPSOli8KSG X-Google-Smtp-Source: AGHT+IEOo8lJu6ltoloAZKaIKq8yD7VNGVZMekepTQg9gVI4jPg2IADyotdzduN6daaNkU7mBVSWNw== X-Received: by 2002:a5d:6c69:0:b0:385:e0d6:fb48 with SMTP id ffacd0b85a97d-3862b33f30fmr7387491f8f.7.1733734383645; Mon, 09 Dec 2024 00:53:03 -0800 (PST) Received: from serenity.mandelbit.com ([2001:67c:2fbc:1:c60f:6f50:7258:1f7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38621fbbea8sm12439844f8f.97.2024.12.09.00.53.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 00:53:03 -0800 (PST) From: Antonio Quartulli Date: Mon, 09 Dec 2024 09:53:13 +0100 Subject: [PATCH net-next v14 04/22] ovpn: keep carrier always on for MP interfaces Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241209-b4-ovpn-v14-4-ea243cf16417@openvpn.net> References: <20241209-b4-ovpn-v14-0-ea243cf16417@openvpn.net> In-Reply-To: <20241209-b4-ovpn-v14-0-ea243cf16417@openvpn.net> To: netdev@vger.kernel.org, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Antonio Quartulli , Shuah Khan , sd@queasysnail.net, ryazanov.s.a@gmail.com, Andrew Lunn Cc: Simon Horman , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1056; i=antonio@openvpn.net; h=from:subject:message-id; bh=GchxL43RZVWbeeTak50ypiKEh4su8ul45OjPZ601Tf0=; b=owEBbQGS/pANAwAIAQtw5TqgONWHAcsmYgBnVrASuhJ8SomcRw/Bzmzr2Y19hlA+33/f0cqS/ GKIlPy9JieJATMEAAEIAB0WIQSZq9xs+NQS5N5fwPwLcOU6oDjVhwUCZ1awEgAKCRALcOU6oDjV h1QQB/40+Wah9gEJn6mPhTzYiTdwQIjnvBWxFDS8MIvjoF7o4G7K1E+NXhKKaSTIkrJ6qEhnfGi ESnpi8UQCPf8jqbzXXqxeY//DHM0uTJU/oDzUIDEgBozH60h+lTkDHxL3Nyrcey8NluK60C+h0R CSSQbE84dyB51WkbHToLg06AcBo2b4r8cBEA26lZW9MQ/l5oqEfotrA8g/xiFxjfnAfbGQ31G7l TsYhJbFfosxAI0ggWGunwvPUaYgk03YF8j/DS3q5l/YK+QYqFm9SdW/wQQmDTUIA9j0/Q2RWoCf G5yQh/78yKCqpp/q/vjaAadZ9/wOvex72nYI/cIeo1hgJKH8 X-Developer-Key: i=antonio@openvpn.net; a=openpgp; fpr=CABDA1282017C267219885C748F0CCB68F59D14C X-Patchwork-Delegate: kuba@kernel.org An ovpn interface configured in MP mode will keep carrier always on and let the user decide when to bring it administratively up and down. This way a MP node (i.e. a server) will keep its interface always up and running, even when no peer is connected. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/main.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/ovpn/main.c b/drivers/net/ovpn/main.c index 60954c5b2b9254db1d24d01ac383935765c7ce5b..274d6166741ef2d6275a252d0c042bc66f8f41f7 100644 --- a/drivers/net/ovpn/main.c +++ b/drivers/net/ovpn/main.c @@ -23,6 +23,15 @@ static int ovpn_net_open(struct net_device *dev) { + struct ovpn_priv *ovpn = netdev_priv(dev); + + /* carrier for P2P interfaces is switched on and off when + * the peer is added or deleted. + * + * in case of P2MP interfaces we just keep the carrier always on + */ + if (ovpn->mode == OVPN_MODE_MP) + netif_carrier_on(dev); netif_tx_start_all_queues(dev); return 0; }