From patchwork Fri Dec 13 00:32:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduard Zingerman X-Patchwork-Id: 13906129 X-Patchwork-Delegate: bpf@iogearbox.net Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00B88DDBE for ; Fri, 13 Dec 2024 00:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734049972; cv=none; b=mXJcnYnid9jJSGHkZKbC2t8KTRu3ExLvS3//PEh4+JMfoqP0nrTbwxMzZ3wH22TMTKntq80a/uHnFoH2phsMbmVZwFyZ3lxRf9ogzka75GmEzGI90sLZHMzLfd0x7ilIYp5ZyJdBzbNNgUr24ZzsJ1/TzVtW6WHduQho5PUEkzo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734049972; c=relaxed/simple; bh=rUeT54e2y7JuZi4XvefWUnxBNFwd0BvkDEp4drRoVHQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XFP9/8b8iBtvoCkqPmEgB+p5nseb1glatrBtRKVRBwHYO+UAdYkq4sMHTxc9oHaKCL8h474kbxi2rDCM+kOXSV9565IZ93X5RD1tuCChwUNyH2dbNJ+VdNbYR1QgU2L7IfZNJT2dZ9iBCWTecbzVDcNm4AZOS89Bov1gcZCa1F4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aR2HbLYV; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aR2HbLYV" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-21669fd5c7cso10975325ad.3 for ; Thu, 12 Dec 2024 16:32:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734049970; x=1734654770; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CANy1t28FhFY0VoMXykBEq6yj4clQ7BB5SeQkAkJcc8=; b=aR2HbLYVtNiHXHoPMFoDhNSmyqvuNa5aDr3Nw01QgcbUyy9/oFGGL7+zKuQQHK/lKZ JGVC7h+Y2UpyJWcYLa3BH9MxrelE4gBIBS9SCixg2peP5uZ6hMOI5OWoeSW7Kg5FPirD nj+F5Nvx1E4JZT6mgWyjk41kbP4Wzc19OezVEjXy0KUw8GCcjOhYMCywNAhYh+DD1ZAP oBd7y4NQx5SRNe/nNJFxUOozvrFUqairoRqD7yAzvy3F8ZkkAGzyuZbZ8yS/8MfzY63I iKhi5NPnMHsGESe36flaA8RKd3P/eX9n1+pmLG6jEFTBU6RrvQ4VZDzs7XcYaLiNwFj1 y4+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734049970; x=1734654770; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CANy1t28FhFY0VoMXykBEq6yj4clQ7BB5SeQkAkJcc8=; b=VqtFnR1Eopxc53AsEeJsbSobG/tKthlYYm/eFHrE5dABxPZB8u42pmGsxAx0TIq+Zu picCNT0YOKqfufnbkfabKoYi2ggQv3/gGBZg+l9rOG2sBA0Qymg7pjsE1Z8jrok3xhGZ cspXnb96K9HjTYguTkr57muyGio5td2mGDitsXGdQN2SLfQ6kTb3G8kFuboy4WUpdOEb m0ctsRXNGK7ZxMW6zjPZc6vTsv8ID2JL6VK/gdAgKgEQ8bOGv6s4EOJfAz7fqQ7RiS9Q 1CZ9FheAhKKrI0VEak+5kV64elP8IfTc1HyGWSyu0/3ZVJ910TcpdJ1P3uDlAfv0Pbh6 QL1Q== X-Gm-Message-State: AOJu0YxOImv6zMdapFJ6oDC4M3dfkUuSeGOpnzjaDoNLIODqLND0KQMr NUcGIYH714xug7M9OuUHy3vSR2YnNy0B+6xO8S56qt9zd5ZQZJQlSzwWRg== X-Gm-Gg: ASbGncsz3NS/1wBPcPg1y4kn0eeq3vlqaT5N6HslGyRWacxs2YgOZPlm38FjyWlDEVE RVGBQWLRy22J8v+dIO88tzK1jjTkkZffzJSh0QVtGPOqTiezNqjU3Ni4tcTM3LA4jq+I6iR8Vwb SJd7sL720LhZmug7HGF95fpc3lK+Zq8dxkxhBE1MAtJVblsPurnZeT1EMzMbbTMSAFQCf+dFqG7 qvpCUj9MtrdIRBtQq4I3Rlyj/UutP6j62TZj27eDQhRvLQKKxWt X-Google-Smtp-Source: AGHT+IHJKtPZYUlO55NjiBcXJrzxzBXWPwcShkKsehOfZbuPCLZ2m+ZJvv+5NRyanwF6F1rUCqFcPg== X-Received: by 2002:a17:902:eccc:b0:215:a2e2:53fe with SMTP id d9443c01a7336-21892a59712mr11358685ad.40.1734049969869; Thu, 12 Dec 2024 16:32:49 -0800 (PST) Received: from honey-badger.. ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2164ec76eb8sm74931945ad.179.2024.12.12.16.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Dec 2024 16:32:49 -0800 (PST) From: Eduard Zingerman To: bpf@vger.kernel.org, ast@kernel.org Cc: andrii@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev, kernel-team@fb.com, yonghong.song@linux.dev, Eduard Zingerman Subject: [PATCH bpf] selftests/bpf: make BPF_TARGET_ENDIAN non-recursive to speed up *.bpf.o build Date: Thu, 12 Dec 2024 16:32:24 -0800 Message-ID: <20241213003224.837030-1-eddyz87@gmail.com> X-Mailer: git-send-email 2.47.0 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: bpf@iogearbox.net BPF_TARGET_ENDIAN is used in CLANG_BPF_BUILD_RULE and co macros. It is defined as a recursively expanded variable, meaning that it is recomputed each time the value is needed. Thus, it is recomputed for each *.bpf.o file compilation. The variable is computed by running a C compiler in a shell. This significantly hinders parallel build performance for *.bpf.o files. This commit changes BPF_TARGET_ENDIAN to be a simply expanded variable. # Build performance stats before this commit $ git clean -xfd; time make -j12 real 1m0.000s ... # Build performance stats after this commit $ git clean -xfd; time make -j12 real 0m43.605s ... Signed-off-by: Eduard Zingerman Acked-by: Yonghong Song --- tools/testing/selftests/bpf/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index bb8cf8f5bf11..9e870e519c30 100644 --- a/tools/testing/selftests/bpf/Makefile +++ b/tools/testing/selftests/bpf/Makefile @@ -461,10 +461,10 @@ $(shell $(1) $(2) -dM -E -