From patchwork Mon Dec 16 07:58:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shinas Rasheed X-Patchwork-Id: 13909344 X-Patchwork-Delegate: kuba@kernel.org Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 090F9171BB; Mon, 16 Dec 2024 07:59:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.156.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734335954; cv=none; b=FvqVJ41+csWsNgpUQGLhD6piBdAOvKEWfYrhXo+5GMOjm86XOCiqlxz6/kHs3R1tLb+BYBlR30dkYqisz6yP4my5LNubJzaorRuiJct7nrfoufd/hsYXxq+VNBC7pZ0w3C64u0//cUnYqlGpyW6AehQe3EFPBVZtrI1a0N0JM/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734335954; c=relaxed/simple; bh=YT4MhSWXLaJ4G19F08MIiBjpl/rMd8bcQ3wsbLUKSqY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=o7oFiVGA6n3p5+0wToVAQkiNK4Rme9iwd4KuX+J277f0GNCfFdQQOGYLb7nK4W++DB5N/26Bwx8NG3mK8J03BQsSRuMFgcaddHEJBF85A9uiGAj/odhvkN9DJUiGAKugXuDoe8DEbJEtsdMp3dEVAFSAeDFw8oV/CKaPvJmc/6U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com; spf=pass smtp.mailfrom=marvell.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=DWg4xv8m; arc=none smtp.client-ip=67.231.156.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marvell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="DWg4xv8m" Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BG7D0BT019859; Sun, 15 Dec 2024 23:58:49 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=R SFaqyBXq4nDGx2YR/iyM/tbb/ts8LDzba8h7rO1Q3s=; b=DWg4xv8m5nclFp4Zo JT4TTrl2zj8idlReIVWwYamH0UZTtMaM/ej7ziFHIwMwiSzu/QB0rOcYUoRcZMrx O9C1MZ05cr5IY+oDHOUg4V2BrQaKjfjKdEJIG03V3On5Xw356sq6bK9yaChGbKS4 YYBlipJMw84IgafuGA+KhSTzgnq/9Z6b78gM0tq8OfDt0owT+eEDl7JJotohGzqM ZMGOQi8aLrnTiVswybkySBcwMLT89+EdWSGVX9+JRgedh3FE60/Y4P/rBeQrrS8c xi9rm1ln93iP4DK/T3C/4XXsRbceYspF0T7jEomJCwyCKU67AoC9qV8K11429Eic HT5zA== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 43hadjrgtw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 15 Dec 2024 23:58:49 -0800 (PST) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 15 Dec 2024 23:58:48 -0800 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Sun, 15 Dec 2024 23:58:48 -0800 Received: from ubuntu-PowerEdge-T110-II.sclab.marvell.com (unknown [10.106.27.86]) by maili.marvell.com (Postfix) with ESMTP id E3F9D3F708E; Sun, 15 Dec 2024 23:58:47 -0800 (PST) From: Shinas Rasheed To: , CC: , , , , , , , , , "Shinas Rasheed" , Veerasenareddy Burru , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Paolo Abeni" , Satananda Burla , "Abhijit Ayarekar" Subject: [PATCH net v2 2/4] octeon_ep: remove firmware stats fetch in ndo_get_stats64 Date: Sun, 15 Dec 2024 23:58:40 -0800 Message-ID: <20241216075842.2394606-3-srasheed@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241216075842.2394606-1-srasheed@marvell.com> References: <20241216075842.2394606-1-srasheed@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: x2Aq5uedk_wEw3fmgBMOfZSiUmQ60VHL X-Proofpoint-ORIG-GUID: x2Aq5uedk_wEw3fmgBMOfZSiUmQ60VHL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Patchwork-Delegate: kuba@kernel.org The per queue stats are available already and are retrieved from register reads during ndo_get_stats64. The firmware stats fetch call that happens in ndo_get_stats64() is currently not required Fixes: 6a610a46bad1 ("octeon_ep: add support for ndo ops") Signed-off-by: Shinas Rasheed --- V2: - No changes V1: https://lore.kernel.org/all/20241203072130.2316913-3-srasheed@marvell.com/ drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c index 941bbaaa67b5..6400d6008097 100644 --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c @@ -996,12 +996,6 @@ static void octep_get_stats64(struct net_device *netdev, struct octep_device *oct = netdev_priv(netdev); int q; - if (netif_running(netdev)) - octep_ctrl_net_get_if_stats(oct, - OCTEP_CTRL_NET_INVALID_VFID, - &oct->iface_rx_stats, - &oct->iface_tx_stats); - tx_packets = 0; tx_bytes = 0; rx_packets = 0; @@ -1019,10 +1013,6 @@ static void octep_get_stats64(struct net_device *netdev, stats->tx_bytes = tx_bytes; stats->rx_packets = rx_packets; stats->rx_bytes = rx_bytes; - stats->multicast = oct->iface_rx_stats.mcast_pkts; - stats->rx_errors = oct->iface_rx_stats.err_pkts; - stats->collisions = oct->iface_tx_stats.xscol; - stats->tx_fifo_errors = oct->iface_tx_stats.undflw; } /**